PDA

View Full Version : Please check my coding - Should I also use em for padding?



rubbed
Feb 25th, 2012, 07:51 PM
Ok I just designed a new layout hoping to make it cleaner and the use of more div classes and em as I was using alot of div Id's and px for everything.
http://pokerslice.net/help/new.html
Coding here:
http://pokerslice.net/help/new.css

I am now using em for font size.
For padding should I also use em or stick to pixels?

Code:
.nav_top li {
padding-left:1em;
}

What is the benefit of doing this over px?

I checked and zoomed in and out of my page but couldn't notice any difference.

If anyone else has any more suggestions on how to make my coding better I would really appreciate it! Does everything look okay?

BlueLinkStudios
Feb 25th, 2012, 08:47 PM
Your website looks really good, however... without seeming rude.... Its a bit like every other website >.< I am guessing you are going to add something good later though (Seeming that is only the header/navigation bar) Keep it up :D

rubbed
Feb 25th, 2012, 08:58 PM
Thanks!

I'm still learning, but I made the design in photoshop now I am trying to copy it onto html.

Any suggestions on how to make it better and unique?

I have the whole content and footer to code but I wan't to see how my coding is so far and what to improve on.

felgall
Feb 25th, 2012, 10:20 PM
px will change size based on the screen size and resolution

em will change size relative to the surrounding text

% will change size relative to the browser viewport size.

Use the one that most closely reflects which one you want to relate it to - the text size or the viewport size.