View Full Version : form validation problems

09-02-2008, 07:58 PM
hi forum
i have been trying to use a way to validate my form but i was unable to use it properly
pls rectify my mistakes.

i m using input type as a button and calling a function to save the form data.
now i want to check if all fields are entered properly before submitting the form

the javascript function i m using is

<script language="JavaScript">
function formCheck(formobj){
// Enter name of mandatory fields
var fieldRequired = Array("txtddate", "txtspid");
// Enter field description to appear in the dialog box
var fieldDescription = Array("Delivery Date", "Sales Person Name");
// dialog message
var alertMsg = "Please complete the following fields:\n";

var l_Msg = alertMsg.length;

for (var i = 0; i < fieldRequired.length; i++){
var obj = formobj.elements[fieldRequired[i]];
if (obj){
case "select-one":
if (obj.selectedIndex == -1 || obj.options[obj.selectedIndex].text == ""){
alertMsg += " - " + fieldDescription[i] + "\n";
case "select-multiple":
if (obj.selectedIndex == -1){
alertMsg += " - " + fieldDescription[i] + "\n";
case "text":
case "textarea":
if (obj.value == "" || obj.value == null){
alertMsg += " - " + fieldDescription[i] + "\n";
if (obj.type == undefined){
var blnchecked = false;
for (var j = 0; j < obj.length; j++){
if (obj[j].checked){
blnchecked = true;
if (!blnchecked){
alertMsg += " - " + fieldDescription[i] + "\n";

if (alertMsg.length == l_Msg){
return true;
return false;

and form details are

<form name="outputForm1" >
<td>Delivery Date</td>
<td><input type="text" name="txtddate" tabindex="1" size="20" ></td>
<td>Sales Person Name</td>
<td><select name="txtspid" tabindex="2">
<option selected>Pls. Choose</option>
<option value="1">Hemant</option>
<option value="2">Rajan</option>
<option value="3">Ranjan Kumar</option>
<option value="4">Sanjay Parwani</option>
<option value="5">Santosh</option>
<option value="6">Rajesh</option>
<td><input type="button" value="Save" name="btnSave" tabindex="21" onclick = "SaveForm();"></td>

if you want to see the save form function,pls check the attachment

i m not able to put the function before the saveform function runs
pls advice how i should go ahead:)

smile always:)

Philip M
09-02-2008, 08:13 PM
<td><input type="button" value="Save" name="btnSave" tabindex="21" onclick = "return formCheck(this.form); SaveForm()"></td>

I would alter var l_Msg = alertMsg.length; to var msgLen or something as the initial letter l is too easily confused with the numeral 1 (which is not valid).