Hello and welcome to our community! Is this your first visit?
Register
Enjoy an ad free experience by logging in. Not a member yet? Register.
Results 1 to 13 of 13
  1. #1
    XSL
    XSL is offline
    New Coder
    Join Date
    Sep 2004
    Location
    Dublin, Ireland
    Posts
    13
    Thanks
    0
    Thanked 0 Times in 0 Posts

    http://funkonline.shyper.com/

    http://funkonline.shyper.com/ - What do you think?
    Area for text known as signature. Images may be used too.

  • #2
    Senior Coder
    Join Date
    Jul 2004
    Location
    New Zealand
    Posts
    1,315
    Thanks
    0
    Thanked 2 Times in 2 Posts
    • Your XHTML doesn't validate;
    • your pages are sent as text/html;
    • inline styles;
    • font tags;
    • non-semantic markup;
    • lists not used where necessary;
    • no seperation between structure/data and presentation and
    • tables used for layout
    Looks pants in Firefox.

  • #3
    Senior Coder gsnedders's Avatar
    Join Date
    Jan 2004
    Posts
    2,340
    Thanks
    1
    Thanked 7 Times in 7 Posts
    I'll add looks pants in Safari, does this mean it's a site which only looks as intended in a browser which has only been updated once this millenium...

    Now, replace text/html in the Meta tag with
    PHP Code:
    <?php
    $mime 
    "text/html";
    if(
    stristr($_SERVER["HTTP_ACCEPT"],"application/xhtml+xml")) {
            if(
    preg_match("/application\/xhtml\+xml;q=([01]|0\.\d{1,3}|1\.0)/i",$_SERVER["HTTP_ACCEPT"],$matches)) {
                    
    $xhtml_q $matches[1];
                    if(
    preg_match("/text\/html;q=q=([01]|0\.\d{1,3}|1\.0)/i",$_SERVER["HTTP_ACCEPT"],$matches)) {
                            
    $html_q $matches[1];
                            if((float)
    $xhtml_q >= (float)$html_q) {
                            
    $mime "application/xhtml+xml";
                            }
                    }
            } else {
                    
    $mime "application/xhtml+xml";
                    }
    }
    echo 
    $mime;
    ?>
    Last edited by gsnedders; 09-18-2004 at 12:30 AM.

  • #4
    XSL
    XSL is offline
    New Coder
    Join Date
    Sep 2004
    Location
    Dublin, Ireland
    Posts
    13
    Thanks
    0
    Thanked 0 Times in 0 Posts
    What does that do?

    btw, I am just learning. At least my CSS validates

    The weird thing is, I am using Firefox and it looks fine for me. (1.0 pr)
    Area for text known as signature. Images may be used too.

  • #5
    Senior Coder
    Join Date
    Oct 2003
    Location
    Australia
    Posts
    1,963
    Thanks
    0
    Thanked 0 Times in 0 Posts
    Quote Originally Posted by Error 404
    Now, replace text/html in the Meta tag with ....
    ..but delete the 'fix_code' function - it isn't being used.

    **edit: "What does that do?"
    ---------------
    It is a PHP script that detects whether the User Agent (browser) is capable of handling true XHTML - XHTML served with a content-type of application/xhtml+xml. Those that are, get XHTML. The others (IE) get it sent to them how you're doing it now.
    Issue: XHTML served properly MUST be well formed. Well formed doesn't just mean proper nesting and closing of tags, either. It means all url's that contain query strings need the ampersand encoded (&amp; instead of just & ) and no copy/paste from MS Word or similar as their 'smart quotes' are invalid and will give users the Yellow Screen of Death.
    Last edited by mindlessLemming; 09-18-2004 at 12:25 AM.

    I take no responsibility for the above nonsense.


    Left Justified

  • #6
    XSL
    XSL is offline
    New Coder
    Join Date
    Sep 2004
    Location
    Dublin, Ireland
    Posts
    13
    Thanks
    0
    Thanked 0 Times in 0 Posts
    what does it do?

    **Edit Thanks
    Last edited by XSL; 09-18-2004 at 03:13 PM.
    Area for text known as signature. Images may be used too.

  • #7
    Senior Coder
    Join Date
    Oct 2003
    Location
    Australia
    Posts
    1,963
    Thanks
    0
    Thanked 0 Times in 0 Posts
    we're playing question/answer leap-frog. See **edit in post above

    I take no responsibility for the above nonsense.


    Left Justified

  • #8
    XSL
    XSL is offline
    New Coder
    Join Date
    Sep 2004
    Location
    Dublin, Ireland
    Posts
    13
    Thanks
    0
    Thanked 0 Times in 0 Posts
    Ok. I put that in. Did I put it in the right place?

    **Edit: Wait. You can't see PHP. So that question is unanswerable. Is this right:

    Code:
    <meta http-equiv="EXPIRES" content="0" />
    <meta http-equiv="Content-Type" content="<?php
    $mime = "text/html";
    if(stristr($_SERVER["HTTP_ACCEPT"],"application/xhtml+xml")) {
            if(preg_match("/application\/xhtml\+xml;q=([01]|0\.\d{1,3}|1\.0)/i",$_SERVER["HTTP_ACCEPT"],$matches)) {
                    $xhtml_q = $matches[1];
                    if(preg_match("/text\/html;q=q=([01]|0\.\d{1,3}|1\.0)/i",$_SERVER["HTTP_ACCEPT"],$matches)) {
                            $html_q = $matches[1];
                            if((float)$xhtml_q >= (float)$html_q) {
                            $mime = "application/xhtml+xml";
                            }
                    }
            } else {
                    $mime = "application/xhtml+xml";
                    }
    }
    echo $mime;
    ?> ; charset=iso-8859-1" />
    
    <link rel="stylesheet" type="text/css" href="sheet.css" media="all" />
    </head>
    Last edited by XSL; 09-18-2004 at 04:16 PM.
    Area for text known as signature. Images may be used too.

  • #9
    Regular Coder
    Join Date
    Jun 2002
    Location
    Sheffield, UK
    Posts
    552
    Thanks
    0
    Thanked 0 Times in 0 Posts
    so what browsers does it look right in?

    I looked in IE6 and Moz1.8a3. They render it completely differently and neither of them look right.
    "To be successful in IT you don't need to know everything - just where to find it in under 30 seconds"

    (Me Me Me Me Me Me Me Me Me)

  • #10
    XSL
    XSL is offline
    New Coder
    Join Date
    Sep 2004
    Location
    Dublin, Ireland
    Posts
    13
    Thanks
    0
    Thanked 0 Times in 0 Posts
    I dunno. It works in Firefox 1.0 pr for me.
    Area for text known as signature. Images may be used too.

  • #11
    Senior Coder
    Join Date
    Feb 2003
    Location
    Ontario, Canada
    Posts
    1,223
    Thanks
    0
    Thanked 0 Times in 0 Posts
    Well I'm at 1600x1200 and it's quite clear that this design was designed for a specific resolution and a maximized window. What resolution that is exactly, I don't know... I'm going to guess 1152x864 but I dunno for sure.

  • #12
    Regular Coder
    Join Date
    May 2004
    Location
    San Jose, CA
    Posts
    388
    Thanks
    0
    Thanked 0 Times in 0 Posts
    The site does not look good in IE6/pc. The content area of the blog, where the actual entries are, is too wide to fit next to the left sidebar, so IE just drops all those entires to the bottom of the screen, beneath the left sidebar. I think it has to do with your widths bein percentages, but there is never a pixel declaration for those areas to be percentages of. 99.8% of *what*? Just a guess, but try to put a width into the body CSS declarations, something like a pixel or em width, and see if that fixes the trouble.

    The design holds in NS7.1/pc, except there is plenty of white space at the bottom of the screen. Even going to the comments on the entries, where there is a scroll bar, there is a big white space at the bottom of the screen in NS. Also, the design fails when I shrink the window. Seems like you created this site to fit 1024x768, but anything less than that and it doesn't work. Look into a liquid design for the site so it will work no matter the resolution.

    Also, you don't have a background color declared for the body. You will want to change that, probably. Someone else on here said that the default background on his screen is a bright orange. Think of how awful that would look with your design...
    -ts
    -Challenge The Status Quo
    -www.toddseal.com/rodin

  • #13
    New Coder
    Join Date
    Aug 2004
    Posts
    46
    Thanks
    0
    Thanked 0 Times in 0 Posts
    I'm using FF 1.0PR as well and that's not working, dude. Sorry. Whatever resolution you are using is probably the only resolution it works in. What I get is as follows:

    800x600
    • valid CSS icon pushes into the side border
    • blog comments area scrolls horizontally
    • "Funk Online Shoutbox" falls down below all content and reads as "Funk Online Shout"


    1024x768
    • "Funk Online Shoutbox" falls down below all content but displays full image width


    1600x1200
    • left background repeats and covers up your menu items
    • looks like right background repeats with right icons over top of it, looks odd
    • Shoutbox is to the right of all of that, in a black border, but with some right-padding, it appears
    • comments text isn't flowing with the width of that area


    And you haven't set a background colour and I get a worthy-of-self-inflicted-eye-gouging mix of your browns/beiges with a bright cyan background.

    You should really validate your HTML before posting a site for review. If it bungs up in a browser when someone sees it, that's usually the first thing you hear and it's hard to help someone along without that critical step in place.

    Hope that helped.


  •  

    Posting Permissions

    • You may not post new threads
    • You may not post replies
    • You may not post attachments
    • You may not edit your posts
    •