Hello and welcome to our community! Is this your first visit?
Register
Enjoy an ad free experience by logging in. Not a member yet? Register.
Page 1 of 3 123 LastLast
Results 1 to 15 of 41

Thread: My portfolio

  1. #1
    Regular Coder
    Join Date
    Mar 2005
    Posts
    735
    Thanks
    4
    Thanked 1 Time in 1 Post

    My portfolio

    I would like to hear all the worst criticism (along with tips to make it better of course!) on my portfolio:
    http://205.205.200.231/~h806209/

    Many thanks!

    ps. I use Firefox for it so anyone who has IE 5, 6 or 7, I would like to hear you out as well.
    Compare bible texts (and other tools):
    TheWheelofGod

  • #2
    God Emperor Fou-Lu's Avatar
    Join Date
    Sep 2002
    Location
    Saskatoon, Saskatchewan
    Posts
    16,987
    Thanks
    4
    Thanked 2,660 Times in 2,629 Posts
    There is no data, which is my major criticism >.<. Lol, I'm guessing you're just showing the layout and scheme right now though.
    It also doesn't pass markup validation: http://validator.w3.org/check?uri=ht...Inline&group=0

    I'm red/green colour blind (which is why I don't generally do design work). The layout is nice, its simplistic and elegant, but the colours look terrible to me. I'd lighten it up a bit even if you stick with the scheme you have, it has a 'stuffy' sort of feel to it. I think you may want to shrink down the size of the main content block and increase the width of the side bars.

    Edit:
    On further inspection of the source, I found out why you have no data. You'll need to choose a newer xml framework to work with, it fails to produce any data in FF3. Works on IE 6 though. The split in the content block is odd, the left aligned data is alright, but you have an odd orange block sitting in the corner. I'm guessing its an overflow control thats breaking that one, I'll advanced edit this and add a screeny. Maybe add some images as well, its a little on the plain side. Something simple, gradients or rounded border edges to give some more depth to the screen.
    Attached Thumbnails Attached Thumbnails My portfolio-wierdblock.jpg  
    Last edited by Fou-Lu; 08-20-2008 at 09:10 PM.
    PHP Code:
    header('HTTP/1.1 420 Enhance Your Calm'); 

  • #3
    Regular Coder
    Join Date
    May 2008
    Location
    Lost in Localhost...
    Posts
    702
    Thanks
    3
    Thanked 43 Times in 42 Posts
    In my browser (Firefox 3 on Linux) there is what I must say almost 100px gap between the left side of the screen and where the content starts. Causing a horizontal scrollbar.

  • #4
    New Coder
    Join Date
    Aug 2008
    Posts
    34
    Thanks
    0
    Thanked 2 Times in 2 Posts
    Ok...since you've asked for the brutal truth, here it is.

    1) Your page has horizontal and vertical scrolling. That's a BIG Turnoff. Pick one (usually vertical) and stick to it. Your page seems optimized for 1200+ width which is not what most people use. Personally, if I have to scroll across a page and also down it to see content, I'm just going to close that site and move to something more accessible.

    2) You have an embedded scroll bar inside your window. Not sure why because it only compounds the problem stated in 1). Too many scroll bars is the best way to lose potential viewers and in your case it does absolutely nothing to enhance the browsing experience.

    3) The colors you have used are (in my opinion) atrocious. Yellow in small doses adds impact, but when you use it as the background and then use black text over it the overall effect reads something like DANGER DANGER DO NOT READ FURTHER. It hurts the eye and isn't soothing at all. Added to that you have a very odd pairing of dirty green / yellow which makes the page look very unappealing. I'm not sure why you chose those two colors but I'd reevaluate those choices. From a readability point you page does not fare well, from an aesthetic point it's down right ugly. There are many sites and web resources you can look to to gain an understanding of how people interpret colors and what kind of emotions they conjure up. Arbitrarily using two colors because they are different is a good way to lose users before they even have a chance to look at your site.

    4) Your layout of 3 columns doesn't suit the content. Your work is what you want to display...so why is it a small 150x150 box in the first column ? Presentation of your content in a portfolio site is what's going to get you work, you want it to be front and centre. Look around the web and you'll find some great examples of portfolio sites that have dramatic impact and make you want to know more about the designer. Your site at the moment conjures up some very negative feelings about your skills.

    5) You've got 14 Validation errors and I would use a STRICT doctype instead of a transitional one. Also, stick your CSS into a separate file instead of having it inline. Seperation of content and presentation is a good professional habit to get into.

    Overall, the way i see it your site needs a good re-think. I personally don't like the basic design, the colors you've used or the method in which you've coded. Harsh...perhaps. But if you take heed of some of my points I'm confident your next revision will fair a lot better.

    Good luck, and keep your chin up.

    Regards,

    Sid
    Last edited by ThirdDash; 08-20-2008 at 09:35 PM.

  • #5
    The Apostate Apostropartheid's Avatar
    Join Date
    Oct 2007
    Posts
    3,215
    Thanks
    16
    Thanked 265 Times in 263 Posts
    *cough* ThirdDash's review was very thorough. There's not much to add, but why on gods earth is your content added by JavaScript? That's really not a good idea--what if I had it disabled? How would a search engine index it?

  • #6
    Regular Coder
    Join Date
    Mar 2005
    Posts
    735
    Thanks
    4
    Thanked 1 Time in 1 Post
    Quote Originally Posted by Fou-Lu View Post
    There is no data, which is my major criticism >.<. Lol, I'm guessing you're just showing the layout and scheme right now though.
    It also doesn't pass markup validation: http://validator.w3.org/check?uri=ht...Inline&group=0
    Does the validation consider JavaScript? I will have to look into that. Thanks.
    Compare bible texts (and other tools):
    TheWheelofGod

  • #7
    Regular Coder
    Join Date
    Mar 2005
    Posts
    735
    Thanks
    4
    Thanked 1 Time in 1 Post
    Quote Originally Posted by Fou-Lu View Post
    Edit:
    On further inspection of the source, I found out why you have no data. You'll need to choose a newer xml framework to work with, it fails to produce any data in FF3. Works on IE 6 though. The split in the content block is odd, the left aligned data is alright, but you have an odd orange block sitting in the corner. I'm guessing its an overflow control thats breaking that one, I'll advanced edit this and add a screeny. Maybe add some images as well, its a little on the plain side. Something simple, gradients or rounded border edges to give some more depth to the screen.
    There's a swf file which has to appear there. There's a div tag and by AJAX I made it load into that. So I guess besides Firefox 2.0 it's giving problems. Hmmm...
    Compare bible texts (and other tools):
    TheWheelofGod

  • #8
    Regular Coder
    Join Date
    Mar 2005
    Posts
    735
    Thanks
    4
    Thanked 1 Time in 1 Post
    Quote Originally Posted by Millenia View Post
    In my browser (Firefox 3 on Linux) there is what I must say almost 100px gap between the left side of the screen and where the content starts. Causing a horizontal scrollbar.
    Can you post a screen cap? Thanks.
    Compare bible texts (and other tools):
    TheWheelofGod

  • #9
    Regular Coder
    Join Date
    Mar 2005
    Posts
    735
    Thanks
    4
    Thanked 1 Time in 1 Post
    Quote Originally Posted by CyanLight View Post
    *cough* ThirdDash's review was very thorough. There's not much to add, but why on gods earth is your content added by JavaScript? That's really not a good idea--what if I had it disabled? How would a search engine index it?
    Would you consider most of the surfers have JavaScript turned off?
    Compare bible texts (and other tools):
    TheWheelofGod

  • #10
    God Emperor Fou-Lu's Avatar
    Join Date
    Sep 2002
    Location
    Saskatoon, Saskatchewan
    Posts
    16,987
    Thanks
    4
    Thanked 2,660 Times in 2,629 Posts
    This really depends on you're target audience. I find that developer based sites have a lower probability of JS enabled versus non-developer audience. I personally only enable my JS if I suspect its actually required to view particular data, I otherwise have it off. I did enable it for you're site, and it still wouldn't load. I find that too often JS is abused, visual animations, those bloody popup windows for Ads, and form validation (especially if its poor validation, I ran across an email what wouldn't validate first.last@domain.com -_-).
    I would NOT use JS to import data. If you are storing XML data you would be better off processing it on the server side and returning it as html to the client. This will ensure that the data is correctly populated (but not necessarily formated!), regardless of the browser. The only exception to this is AJAX, which handles the intermediate requests between the server process and the client. Its still generally server handled though.
    PHP Code:
    header('HTTP/1.1 420 Enhance Your Calm'); 

  • #11
    Master Coder
    Join Date
    Dec 2007
    Posts
    6,682
    Thanks
    436
    Thanked 890 Times in 879 Posts
    Quote Originally Posted by gilgalbiblewhee View Post
    I would like to hear all the worst criticism (along with tips to make it better of course!) on my portfolio:
    http://205.205.200.231/~h806209/

    Many thanks!

    ps. I use Firefox for it so anyone who has IE 5, 6 or 7, I would like to hear you out as well.
    remove position: absolute; left: 150px; and top: 0; from body style. After you validate the page will be simple to center content without using position absolute.
    Edit: hmm, I lied when I said simple,

    About 5&#37; or less of the user have javascript disabled/blocked and some of them, I don't know how many, disable/block flash. I'm one of them,
    Last time when I look to your site flash was working but now ask me to install adobe flash.
    In this situation I think is better to notify the user that he/she need javascript and/or flash enabled to see the content.
    I don't know who make this to change, you or me? It's probably me.
    color problems:

    http://colorfilter.wickline.org/

    http://colorvisiontesting.com/

    this can help you to see how it looks in other browsers.

    http://browsershots.org/

    flash, js, .... :

    http://blog.deconcept.com/swfobject/
    http://onlinetools.org/articles/unob...ipt/index.html
    http://en.wikipedia.org/wiki/Progressive_Enhancement

    best regards
    Last edited by oesxyl; 08-21-2008 at 03:34 AM.

  • #12
    Regular Coder
    Join Date
    Mar 2005
    Posts
    735
    Thanks
    4
    Thanked 1 Time in 1 Post
    Quote Originally Posted by oesxyl View Post
    remove position: absolute; left: 150px; and top: 0; from body style. After you validate the page will be simple to center content without using position absolute.
    Code:
    <body style="background-color: #808000; display: block; text-align: center;"
    But Firefox doesn't center it for some reason. I don't remember how but in one case when I put display: block and then Text-align: center it worked but not when it's applied to the body.
    Compare bible texts (and other tools):
    TheWheelofGod

  • #13
    Regular Coder
    Join Date
    Mar 2005
    Posts
    735
    Thanks
    4
    Thanked 1 Time in 1 Post
    Quote Originally Posted by Fou-Lu View Post
    There is no data, which is my major criticism >.<. Lol, I'm guessing you're just showing the layout and scheme right now though.
    It also doesn't pass markup validation: http://validator.w3.org/check?uri=ht...Inline&group=0
    It shows 14 errors beginning with the JavaScript. I don't know why it's picking on the for loop. Maybe it shouldn't be "transitional" but something else.
    Compare bible texts (and other tools):
    TheWheelofGod

  • #14
    Supreme Master coder! _Aerospace_Eng_'s Avatar
    Join Date
    Dec 2004
    Location
    In a place far, far away...
    Posts
    19,291
    Thanks
    2
    Thanked 1,043 Times in 1,019 Posts
    Get rid of ALL your absolute positioning. You are abusing it. Float your side bar to the left as well as the content area. Set the width of #master to 900px and add margin:auto;

    Again don't use absolute positioning if you don't need to. If this is a portfolio for web development then you have a lot to learn.
    ||||If you are getting paid to do a job, don't ask for help on it!||||

  • #15
    Regular Coder
    Join Date
    Mar 2005
    Posts
    735
    Thanks
    4
    Thanked 1 Time in 1 Post
    Quote Originally Posted by _Aerospace_Eng_ View Post
    Get rid of ALL your absolute positioning. You are abusing it. Float your side bar to the left as well as the content area. Set the width of #master to 900px and add margin:auto;

    Again don't use absolute positioning if you don't need to. If this is a portfolio for web development then you have a lot to learn.
    Speaking of width, what is the best width? 955px? 900px?...or 100%?
    Compare bible texts (and other tools):
    TheWheelofGod


  •  
    Page 1 of 3 123 LastLast

    Posting Permissions

    • You may not post new threads
    • You may not post replies
    • You may not post attachments
    • You may not edit your posts
    •