Hello and welcome to our community! Is this your first visit?
Register
Enjoy an ad free experience by logging in. Not a member yet? Register.
Page 1 of 2 12 LastLast
Results 1 to 15 of 25

Thread: My first site.

  1. #1
    New to the CF scene
    Join Date
    Jul 2008
    Posts
    5
    Thanks
    2
    Thanked 0 Times in 0 Posts

    My first site.

    http://www.graphic-goodies.com/

    This is my first website and any suggestions to improve it are appreciated.

  • #2
    Supreme Master coder! _Aerospace_Eng_'s Avatar
    Join Date
    Dec 2004
    Location
    In a place far, far away...
    Posts
    19,291
    Thanks
    2
    Thanked 1,043 Times in 1,019 Posts
    In Firefox 3 your content is below your navigation rather than next to it. Funny how you say this
    Quote Originally Posted by GraphicGoodies
    Best viewed in Firefox 3, Internet Explorer 7, and Opera 9 browsers in a maximized window.
    I'm using a 1280x800 resolution at full screen.

    I don't like how the text moves on your navigation when you mouseover the links.

    Why do you have two navigations?

    And your code doesn't validate. See your errors here.
    ||||If you are getting paid to do a job, don't ask for help on it!||||

  • #3
    Regular Coder
    Join Date
    Mar 2007
    Location
    Quebec
    Posts
    261
    Thanks
    6
    Thanked 7 Times in 7 Posts
    I use a 1280x1024 resolution and there is a massive purple space between the header and the content, both don't actually fit on my screen at the same time - I have to scroll down quite a bit to see content.

  • #4
    Regular Coder BWiz's Avatar
    Join Date
    Mar 2006
    Location
    Sol System
    Posts
    471
    Thanks
    7
    Thanked 21 Times in 21 Posts
    It's pretty slick for a first page. My didn't look half as good as that. But then again, my first web page's layout didn't break. Was there supposed to be a huge gap between the header image and the actual content. It seems that your first navigation, to the right, prevents the actual content from following the header image. I couldn't take an image of the break, because it is so huge, but here: an image of the gap.

    Your color scheme leaves a little to be desired. Sure, using shades of one color can do the job, but in your case, you have a lot of content, and all of it following this burgandy and white (plus a little green) color scheme makes the site a little visually boring. May I suggest visitng ColorSchemer or ColorLovers? Both are great tools for web designers when choosing color schemes. ColorLovers is better, as you don't have to purcahse any software to use it, and download options include the HEX value (as far as I can remember).

    You have far too many advertisments in your page. They bog it down, and are complete eyesores to the rest of your site. Sure, you want to make money of your site, but you have so many adverstisments that it detracts from thr purpose of an advertisment.

    I would remove the entire links section and place it on a seperate page. At first glance, they looked like mini advertisments. Still, their flashiness is slightly nauseating.
    BWiz :: Happy Coding!
    2006
    2007 2008 2009
    2010 2011
    Irrational numbers make no sense.

  • #5
    New to the CF scene
    Join Date
    Jul 2008
    Posts
    5
    Thanks
    2
    Thanked 0 Times in 0 Posts
    Thanks for the reviews...

    I added some things to my CSS which should fix the problems with other resolutions. How does it look now? I also moved the Links to a new page.

  • #6
    Regular Coder ArcticFox's Avatar
    Join Date
    Jan 2004
    Location
    Vostok Station, AQ
    Posts
    602
    Thanks
    35
    Thanked 3 Times in 3 Posts

    Question

    Quote Originally Posted by _Aerospace_Eng_ View Post
    And your code doesn't validate. See your errors here.
    Did you actually look at what the validation errors showed?!


    Error Line 9, Column 84: document type does not allow element "LINK" here.
    Line 10, Column 76: document type does not allow element "LINK" here.
    Aren't links suppose to be between <head></head>?

    Line 37, Column 6: end tag for element "HEAD" which is not open.
    Interesting, because when I view source, I CLEARLY see an opening <head> tag at the top of the page.

    Line 38, Column 5: document type does not allow element "BODY" here.
    Oh, that's right, the body goes here... </html><body>

    Line 124, Column 65: cannot generate system identifier for general entity "zs".
    Line 124, Column 65: general entity "zs" not defined and no default entity.
    Line 124, Column 67: reference to entity "zs" for which no system identifier could be generated.
    "[...]caused by unencoded ampersands" - riiiight. It's a frigg'n src link, leave it alone!


    Validation is for chumps who can't think for themselves.
    <div> - putting your mind in a box since 1997

  • #7
    Supreme Master coder! _Aerospace_Eng_'s Avatar
    Join Date
    Dec 2004
    Location
    In a place far, far away...
    Posts
    19,291
    Thanks
    2
    Thanked 1,043 Times in 1,019 Posts
    @ArticFox Yes I looked at the errors. That first one is because of this.
    Code:
    <meta name="verify-v1" content="VopB68SBL9/ssg6ietju8lvu3fUV4USs/WsadAYGBcc=" />
    They are using the wrong syntax to close a meta tag. They aren't using XHTML so no need for the /> part.

    The rest can be solved by simply using &amp; instead of &.
    ||||If you are getting paid to do a job, don't ask for help on it!||||

  • #8
    Regular Coder ArcticFox's Avatar
    Join Date
    Jan 2004
    Location
    Vostok Station, AQ
    Posts
    602
    Thanks
    35
    Thanked 3 Times in 3 Posts
    @AE: Do you know what that code is for?

    Code:
    <meta name="verify-v1" content="VopB68SBL9/ssg6ietju8lvu3fUV4USs/WsadAYGBcc=" />
    <div> - putting your mind in a box since 1997

  • #9
    Supreme Master coder! _Aerospace_Eng_'s Avatar
    Join Date
    Dec 2004
    Location
    In a place far, far away...
    Posts
    19,291
    Thanks
    2
    Thanked 1,043 Times in 1,019 Posts
    Yeah I do. Its for google analytics. Google is just verifying the name and content. It doesn't need the /> part.
    ||||If you are getting paid to do a job, don't ask for help on it!||||

  • #10
    Regular Coder ArcticFox's Avatar
    Join Date
    Jan 2004
    Location
    Vostok Station, AQ
    Posts
    602
    Thanks
    35
    Thanked 3 Times in 3 Posts
    Does that /> being in the code affect the look, feel, accessibility in any browser out there?

    No.

    But according to the "validator" it's an error/problem and needs to be corrected or you won't get your W3 graphic cookie. Why?
    <div> - putting your mind in a box since 1997

  • #11
    Supreme Master coder! _Aerospace_Eng_'s Avatar
    Join Date
    Dec 2004
    Location
    In a place far, far away...
    Posts
    19,291
    Thanks
    2
    Thanked 1,043 Times in 1,019 Posts
    Because its XHTML self closing syntax. They OP isn't using XHTML. They are using HTML.
    ||||If you are getting paid to do a job, don't ask for help on it!||||

  • #12
    Regular Coder ArcticFox's Avatar
    Join Date
    Jan 2004
    Location
    Vostok Station, AQ
    Posts
    602
    Thanks
    35
    Thanked 3 Times in 3 Posts
    Is that really a problem for visitors? That /> would keep pages from loading, colours from showing correctly, positioning issues or text readers from pronouncing things...?

    I'm not understanding what the actual problem is.
    <div> - putting your mind in a box since 1997

  • #13
    Supreme Master coder! _Aerospace_Eng_'s Avatar
    Join Date
    Dec 2004
    Location
    In a place far, far away...
    Posts
    19,291
    Thanks
    2
    Thanked 1,043 Times in 1,019 Posts
    He asked for a review and from a review in a "coding" forum you usually get your coding errors pointed out to you...
    ||||If you are getting paid to do a job, don't ask for help on it!||||

  • #14
    Regular Coder ArcticFox's Avatar
    Join Date
    Jan 2004
    Location
    Vostok Station, AQ
    Posts
    602
    Thanks
    35
    Thanked 3 Times in 3 Posts
    Ah yes, the left turn at Albuquerque.

    Got it.
    <div> - putting your mind in a box since 1997

  • #15
    Rockstar Coder
    Join Date
    Jun 2002
    Location
    USA
    Posts
    9,074
    Thanks
    1
    Thanked 328 Times in 324 Posts
    Quote Originally Posted by _Aerospace_Eng_ View Post
    He asked for a review and from a review in a "coding" forum you usually get your coding errors pointed out to you...
    Agreed.

    @ArcticFox, Please stop trying to create a flame war. Asking about the validation errors is one thing, discussing the importance and relevance of valid code is not appropriate for a site review.
    OracleGuy


  •  
    Page 1 of 2 12 LastLast

    Posting Permissions

    • You may not post new threads
    • You may not post replies
    • You may not post attachments
    • You may not edit your posts
    •