Hello and welcome to our community! Is this your first visit?
Register
Enjoy an ad free experience by logging in. Not a member yet? Register.
Results 1 to 6 of 6
  1. #1
    Banned
    Join Date
    Jul 2007
    Posts
    2
    Thanks
    0
    Thanked 0 Times in 0 Posts

    Question Please review my first site

    Please review,

    CoolestOne

  • #2
    Senior Coder ahallicks's Avatar
    Join Date
    May 2006
    Location
    Lancaster, UK
    Posts
    1,134
    Thanks
    1
    Thanked 57 Times in 55 Posts
    Woah woah woah! Where to begin.

    Validation. Firstly you have:

    Code:
    <style type="text/css">
    body{ font-family: arial; font-size: 12px; color: rgb(0,0,0) }
    td{ font-family: arial; font-size: 12px; color: rgb(0,0,0) }
    input{ font-family: arial; font-size: 12px; color: rgb(0,0,0) }
    select{ font-family: arial; font-size: 12px; color: rgb(0,0,0) }
    a:link { text-decoration: none; color: RGB(0,0,255);}
    a:active { text-decoration: none; color: RGB(0,0,255);}
    a:visited { text-decoration: none; color: RGB(0,0,255);}
    .gridTitle{ border-top: 1px #FFFFFF solid;  border-bottom: 1px #C1C1C1 solid; border-left: 1px #C1C1C1 solid; border-right: 1px #FFFFFF solid; }
    .gridRow{ border-bottom: 1px #E7E7E7 solid; }
    </style>
    
    <body background="grains3.jpg">
    ..ABOVE the <html>, which is a big no no as it will render IE in quirks mode making it very difficult to have any cross-browser compliancy. Second, you should have a doctype (the only thing allowed above the html), which will help you create a better web site that is standards compliant and cross-browser compatible.

    There's plenty more on the code, but I'd suggest you do the changes listed above, validate, and then correct the hundreds of errors you get.

    Now for style.

    There is no indication of what your site does. No intro, no welcome, no content at all really. There is no structure, no proper navigation. No graphics, no colour and nothing that is going to make me click that link EVER again! I hate to sound harsh, and I understand it is your first site, but you truly have a long way to go. Have a look at BonRouge's tutorials on HTML and CSS and find out how to code properly. Look for articles on creating web sites with structure and how to use graphics programs to jazz them up. Also look at why tables for layout is bad, why they should ONLY be used for tabular data!

    Find lots of tutorials on creating semantic and stylish web sites... look at sites you like, view the source and see how they're made. Read some books about HTML and CSS and how to implement them in a clean precise manner.

    You have a long way to go, but if you're serious about web design then get some learning and practise and ask here for any help you need.
    "write it for FireFox then hack it for IE."
    Quote Originally Posted by Mhtml View Post
    Domains are like women - all the good ones are taken unless you want one from some foreign country.
    Reputation is your friend

    Development & SEO Tools

  • #3
    Banned
    Join Date
    Jul 2007
    Posts
    2
    Thanks
    0
    Thanked 0 Times in 0 Posts
    Thanks ahallicks for the detailed review. I don't know much about php & don't know what you mean by validate. Anyhow I have made many changes. Please review it again.

    I am unable to place google ads in the centre place. Can you plz recommend me something?


    Thanks for the review

    Site: CoolestOne
    Last edited by SUNNY ARSLAN; 07-13-2007 at 05:19 PM.

  • #4
    Regular Coder BWiz's Avatar
    Join Date
    Mar 2006
    Location
    Sol System
    Posts
    471
    Thanks
    7
    Thanked 21 Times in 21 Posts
    Validation means to have your page validated by the w3.org validator which can be found here: http://validator.w3.org. This is the URL for the validation of your page: http://validator.w3.org/check?uri=ht...lestone.com%2F

    Last time I checked, you had 203 errors - you may want to correct them.
    Last edited by BWiz; 07-16-2007 at 03:55 AM.
    BWiz :: Happy Coding!
    2006
    2007 2008 2009
    2010 2011
    Irrational numbers make no sense.

  • #5
    New Coder
    Join Date
    Jun 2007
    Posts
    23
    Thanks
    0
    Thanked 0 Times in 0 Posts
    Hi
    Just to encourage you. The validator does say lots of errors but it also tells you how to solve them. Just work slowly through them and you will know lots about coding by the end of the page.
    Mark Wiseman
    allthewikis.com
    Enjoy your life and each moment in it,
    Know the purpose of every minute.

  • #6
    Senior Coder ahallicks's Avatar
    Join Date
    May 2006
    Location
    Lancaster, UK
    Posts
    1,134
    Thanks
    1
    Thanked 57 Times in 55 Posts
    First things first, the start of your page needs to look like:

    Code:
    <!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
    <html xmlns="http://www.w3.org/1999/xhtml">
    <head>
    
    <title>CoolestOne.com - Home of Funny Pictures</title>
    
    <link rel="Shortcut Icon" href="/favicon.ico" />
    
    <style type="text/css">
    body{ font-family: arial; font-size: 12px; color: rgb(0,0,0) }
    td{ font-family: arial; font-size: 12px; color: rgb(0,0,0) }
    input{ font-family: arial; font-size: 12px; color: rgb(0,0,0) }
    select{ font-family: arial; font-size: 12px; color: rgb(0,0,0) }
    a:link { text-decoration: none; color: RGB(0,0,255);}
    a:active { text-decoration: none; color: RGB(0,0,255);}
    a:visited { text-decoration: none; color: RGB(0,0,255);}
    .gridTitle{ border-top: 1px #FFFFFF solid;  border-bottom: 1px #C1C1C1 solid; border-left: 1px #C1C1C1 solid; border-right: 1px #FFFFFF solid; }
    .gridRow{ border-bottom: 1px #E7E7E7 solid; }
    </style>
    
    </head>
    
    <body>
    You might want to put a couple of <meta> tags in there too to describe the content-type and some keywords/site description.
    "write it for FireFox then hack it for IE."
    Quote Originally Posted by Mhtml View Post
    Domains are like women - all the good ones are taken unless you want one from some foreign country.
    Reputation is your friend

    Development & SEO Tools


  •  

    Posting Permissions

    • You may not post new threads
    • You may not post replies
    • You may not post attachments
    • You may not edit your posts
    •