Correct syntax for document.write

[croniccoder]

document.write += ('<a href="'+ ads[adNumber].href +'" \n')
document.write += ('onMouseOver="status=\''+ ads[adNumber].mouseover +'\';return true" \n')
document.write += ('onMouseOut="status=\'\'"> \n')
document.write += ('<img src="' + ads[adNumber].src + '" width=' + ads[adNumber].width)
document.write += (' onLoad="setTimeout(\'newAd();\',' + refreshTime + ');"')
document.write += ('\n height=' + ads[adNumber].height + ' border=0 >')
document.write += ('</a>')

Can anyone possibly see a problem with the syntax of the above code?

The setTimeout function is never run so something is wrong with the syntax.

[croniccoder]

document.write += (' onLoad="setTimeout(\'newAd();\',' + refreshTime + ');"')

Actually it's just this line that isn't working. Any thoughts?

I've tried this 50 different ways already so it's not like I'm not trying to get this right.

[Scriptbanger]

Try this:

document.write("<a href=\'"+ ads[adNumber].href +"\'\n");

Notice also the double quotes and single quotes have been reversed and the single quotes have been 'escaped' [that means that a \ has been put in front of each single quote so that the parser ignores it]. While some browsers/parsers can handle messy scripts others choke on it if everything isn't correct.

Also terminate the end of each line with a semicolon as in the example. Do this throughout your script and it should work fine. That is unless you have other errors.

[croniccoder]

I tried that and it still doesn't work. I know its a incorrect syntax problem because in the original code:

document.write += ('<a href="'+ ads[adNumber].href +'" \n')
document.write += ('onMouseOver="status=\''+ ads[adNumber].mouseover +'\';return true" \n')
document.write += ('onMouseOut="status=\'\'"> \n')
document.write += ('<img src="' + ads[adNumber].src + '" width=' + ads[adNumber].width)
document.write += (' onLoad="setTimeout(\'newAd();\',' + refreshTime + ');"')
document.write += ('\n height=' + ads[adNumber].height + ' border=0 >')
document.write += ('</a>')

the images is being displayed, but the setTimeout function is never invoked.

[zcorpan]

Get rid of +=.

[Scriptbanger]

Gotta watch all the quotes/double quotes and escapes.

Try this:

document.write("onLoad=\'setTimeout(\"newAd()\"," + refreshTime + ");\n\'");

Also, what does the 'newAd()' function you are calling look like?