Embedding Javascript inside PHP script

[Hardeep_S]

Hi. I'm fairly new to PHP and i was writing a script in which i wanted to have some javascript included. I was wondering if someone could look this piece of the code over and tell me if this is even valid..

PHP Code:

for($k = 0; $k < count($terrArray); $k++){
    if($armiesArray[$k] != NULL || $armiesArray[$k] != 0){
    ?>
    <script language="JavaScript">
    var terrname = <?php echo $terrArray[$k]?>
    document.getElementById(terrname).style.visibility = "hidden";
    </script>
    <?php    
    }else if{
    ?>
    <script language="JavaScript">
    var terrname = <?php echo $terrArray[$k]?>
    var numarmy = <?php echo $armiesArray[$k]?>
    var player = <?php echo $playerArray[$k]?>
    var bcolor;
    if(player = 1){
        bcolor = "red"
    }else{
        bcolor = "aqua"
    }//if
    document.getElementById(terrname).style.visibility = "visible";
    document.getElementById(terrname).value = numarmy;
    document.getElementById(terrname).style.background-color = bcolor;
    </script>
    <?php
    }//if
}//for

[Fou-Lu]

Umm, well not quite. I wouldn't use a NULL attribute at all, I'd use an isset() or !empty() function instead. I'd also adjust your <?php echo $var?> to simply adding a semi colon at the end of the variable. Don't think a one liner would cause problems, but I've never done it without so I'm not sure.
As for your javascript, I cannot help you validate that, I'm not much of a javascripter. What I can say, is depending on what you are doing there may be a different way to do the same thing using arrays in javascript. Simply due to $terrArray, if its like 20 for instance then you are going to have a lot of code which surely can be arranged in another way. Best to check with the js guys though for that one.

[Extreme43]

is it possible to use a javascript variable with php?
like echo "javavariable";
i tried something similar to that and failed

[marek_mar]

PHP has very little (if nothing) to do with JS. PHP just generates the code that is passed to the browser. If you print JS, JS will be sent and if that JS works it will be executed by the browser.

[Fou-Lu]

yeah, JS cannot comunicate with php, but they can work together. PHP can dynamically generate the information that you need, but you cannot set a php variable with javascript. Now, there is I suppose one way to do it, you can use js to set cookies, and you can retrieve these with php. I've never done this before, as I mentioned, I'm not much of a javascripter, and don't know how everything works with it. The question is, do you really need javascript at all? I mean, I find more an more visitors to my sites do not support javascript with their browsers, and therefore I refuse to use it at all, at least for things that need to be done by php, but can shortcut with javascript (checking form fields for example). Otherwise, I find it pretty much useless.

[Extreme43]

well it was actually for a countdown script
i will find a way around it...