Java questions.

[Johnny Redburn]

hi,
I've been starting to go through my programs by doing one part at a time so i dont run into as many errors :/
can someone please look over my open/read method?
im getting 1 error when i attempt to compile it ive marked in code where it is
it says this when i try to compile

Prog3test.java:28: openread(java.io.File) in Prog3test cannot be applied to (java.lang.String)
String in = openread("input.txt");

-thanks

import java.io.*;
import B102.*;

class Prog3
{
          public String openread(File inputfile)
          {
          System.out.println("Opening File: " + inputfile.getName());
          BufferedReader input = null;
          String line;    
          try {
              input = new BufferedReader(new FileReader(inputfile));
              while((line = input.readLine())!= null)
                {
                break;
                }
          } catch(IOException in) {
                  System.out.println("There has been an error.");
          } finally { // closing file, even on exception
                try { input.close(); }
                catch (Exception e) {}
                }
            return(line);
          }
          
          public static void main(String[] args)
          {
          	String in = openread("input.txt");  *******error here*******
          }
}

[shmoove]

Your openread method accepts a File argument but you are sending it a string. I'm not that well-versed in J2SE but from looking at your code it looks like openread should be accepting a String:

public String openread(String inputfile)

shmoove

Edit:
One more thing. If you make that change then this line:

System.out.println("Opening File: " + inputfile.getName());

will give you an error, so you'll probably want to change it to:

System.out.println("Opening File: " + inputfile);

[Johnny Redburn]

Thankyou for your reply,

however i am still getting the same error as i stated above :[
any other suggestions?

-thanks in advance

[Antoniohawk]

The object that you're returning shouldn't be in parentheses should it?

return(line);
...
return line;

Try the following code.

import java.io.*;
import B102.*;

class Prog3
{
          public String openread(File inputfile)
          {
          System.out.println("Opening File: " + inputfile.getName());
          BufferedReader input = null;
          String line;    
          try {
              input = new BufferedReader(new FileReader(inputfile));
              while((line = input.readLine())!= null)
                {
                break;
                }
          } catch(IOException in) {
                  System.out.println("There has been an error.");
          } finally { // closing file, even on exception
                try { input.close(); }
                catch (Exception e) {}
                }
            return line;
          }
          
          public static void main(String[] args)
          {
                File inputFile = new File("input.txt");
          	String in = openread(inputFile);
          }
}