Go Back   CodingForums.com > :: Client side development > General web building > Site reviews

Before you post, read our: Rules & Posting Guidelines

Reply
 
Thread Tools Rate Thread
Enjoy an ad free experience by logging in. Not a member yet? Register.
Old 04-20-2004, 01:02 PM   PM User | #1
sharkey182uk
New Coder

 
Join Date: Dec 2003
Location: UK
Posts: 39
Thanks: 0
Thanked 0 Times in 0 Posts
sharkey182uk is an unknown quantity at this point
Please review my web site?

Hey ive recently designed a website for a phone company and well am here so you peeps can review it.

Here are my problems which i would like to fix-

1. I would like the main menu to be centered but i cant seem to get it so as a temporary work around i just set the right margin to make it look center.

2. At 800*600 the left hand columns cut off for some reason.

3. In Mozilla its an absolute mess because of my propreity ie coding but if anyone can find work arounds i would be extremely greatful see the client doesnt know about other browsers and that but he made me start coding it in IE and its all went from there. But i would like to keep the same look as it does in IE becuase the client likes it.

4. Ohh yeah i created another big sin by using an ID twice but that is another temporary work around as i wanted them links styled the same.

5. Valid CSS but not Valid XHTML becuase of the flash banner is there a way to get that to validate.

Any help/ info is appreacited

Last edited by sharkey182uk; 04-20-2004 at 01:10 PM..
sharkey182uk is offline   Reply With Quote
Old 04-20-2004, 01:47 PM   PM User | #2
mindlessLemming
Senior Coder

 
Join Date: Oct 2003
Location: Australia
Posts: 1,963
Thanks: 0
Thanked 0 Times in 0 Posts
mindlessLemming is an unknown quantity at this point
You know what would really help? A link.

4. Make it a class. Multiple use of the same ID won't validate. (if I remember correctly)
5. Valid Flash: A List Apart: Flash Satay.
__________________

I take no responsibility for the above nonsense.


Left Justified

Last edited by mindlessLemming; 04-20-2004 at 01:52 PM..
mindlessLemming is offline   Reply With Quote
Old 04-20-2004, 02:36 PM   PM User | #3
ronaldb66
Senior Coder

 
Join Date: Jun 2002
Location: The Netherlands, Baarn, Ut.
Posts: 4,253
Thanks: 0
Thanked 0 Times in 0 Posts
ronaldb66 is an unknown quantity at this point
Episode 1 through 3...

This is beginning to look like star wars:
  1. If it's in a block element, use margin-left: auto and margin-right: auto and set a specific width; as a hack for IE5.x/Win, specify text-align: center for the parent element, and adjust text alignment for the menu if needed.
  2. ??? (Yeah, a link would be handy).
  3. Code for standards, hack for IE. There are plenty of hacks/filters/fixes available to make IE play nice; things IE really doesn't support, and proprietary stuff only IE supports should be avoided. Don't tell your client about it, just do it. If he doesn't know and it doesn't show, he couldn't care less.
__________________
Regards,
Ronald.
ronaldvanderwijden.com
ronaldb66 is offline   Reply With Quote
Old 04-20-2004, 04:02 PM   PM User | #4
sharkey182uk
New Coder

 
Join Date: Dec 2003
Location: UK
Posts: 39
Thanks: 0
Thanked 0 Times in 0 Posts
sharkey182uk is an unknown quantity at this point
Opps sorry guys my bad Phone site

Cheers for your help.
sharkey182uk is offline   Reply With Quote
Old 04-20-2004, 10:15 PM   PM User | #5
JAVAEOC
Regular Coder

 
Join Date: Oct 2003
Location: SC
Posts: 936
Thanks: 0
Thanked 0 Times in 0 Posts
JAVAEOC is an unknown quantity at this point
It looks very nice in IE, but in NS, Moz, nothin shows up, the top menu is messed up, all the content is way to far down.... its bad, in NS
__________________
http://www.bluephoenix.uni.cc/
JAVAEOC is offline   Reply With Quote
Old 04-21-2004, 12:07 AM   PM User | #6
l3vi
Regular Coder

 
Join Date: Jan 2003
Posts: 400
Thanks: 0
Thanked 0 Times in 0 Posts
l3vi is an unknown quantity at this point
It looks good in IE, like JAVAOEC said, but it still looks kinda not that great in MOZ. THe top Glam part is a bit screwed up. Way too small. Id recommend downloading MOZ for next websites you do:

www.mozilla.org
l3vi is offline   Reply With Quote
Old 04-21-2004, 06:41 AM   PM User | #7
ionsurge
Senior Coder

 
Join Date: Aug 2002
Location: A 4D universe
Posts: 1,337
Thanks: 0
Thanked 0 Times in 0 Posts
ionsurge is an unknown quantity at this point
It looks a total mess in Opera....

In regards to source code, not much to say apart from the fact that you have used a few deprecated tags, e.g. <center>, missing alt="" attributes in images, and you use the align="center" tag. It needs a lot of work.
__________________
http://www.mudsplat.com - Web design, print, and marketing solutions.
ionsurge is offline   Reply With Quote
Old 04-21-2004, 10:53 AM   PM User | #8
sharkey182uk
New Coder

 
Join Date: Dec 2003
Location: UK
Posts: 39
Thanks: 0
Thanked 0 Times in 0 Posts
sharkey182uk is an unknown quantity at this point
Yeah the depeciated tags were just a temp workaround i do have mozilla and realise its a mess but is there anyway i can change it without changing the look of it in IE.

Thanks for all the input guys.
sharkey182uk is offline   Reply With Quote
Old 04-21-2004, 02:10 PM   PM User | #9
ronaldb66
Senior Coder

 
Join Date: Jun 2002
Location: The Netherlands, Baarn, Ut.
Posts: 4,253
Thanks: 0
Thanked 0 Times in 0 Posts
ronaldb66 is an unknown quantity at this point
Not perfect

The basic idea is pretty nice; for a start, you didn't use tables for layout ( ), and most of the code looks pretty sound.
However, using IE5.5/Win, most of the text in the various link lists is tiny and illegible, and the center content area is too far to the left, running over the left navs.
although a different source order would be preferable, if you stick with floating the navs left and right, specify sufficient left and right margin for your content area to clear the navs and set its width to "auto". Oh, and use fixed widths for the navs; no need to have those scale.

Since your top nav bar is a list and is in itself inside a div, there should be no problem centering it as I mentioned before.
Also, I don't know what's causing it, but your layout just won't fit the window; if there are any window-wide elements specified with "width: 100%", try 99%. Having page elements butting up to the window chrome is something I'm not at all fond of anyway.

Lastly, don't specify heights for any elements unless it's certain what height its contents are; simply letting the content decide an element's height works almost always, and usually better than set heights.
__________________
Regards,
Ronald.
ronaldvanderwijden.com
ronaldb66 is offline   Reply With Quote
Old 04-21-2004, 03:43 PM   PM User | #10
sharkey182uk
New Coder

 
Join Date: Dec 2003
Location: UK
Posts: 39
Thanks: 0
Thanked 0 Times in 0 Posts
sharkey182uk is an unknown quantity at this point
Hey yeah ill try those things thanks again mate
sharkey182uk is offline   Reply With Quote
Old 04-24-2004, 06:48 PM   PM User | #11
surgeproof
New to the CF scene

 
Join Date: Mar 2004
Posts: 5
Thanks: 0
Thanked 0 Times in 0 Posts
surgeproof is an unknown quantity at this point
Question phone site


looks pretty much the same in IE and in FireFox, apart from the menus are a bit mucked up, like some move slightly on hover, while others don't. Havn't looked at your coding!
__________________
surgeproof
ithium is the best web host around.

google | mudsplat
surgeproof is offline   Reply With Quote
Old 04-26-2004, 05:40 PM   PM User | #12
redhead
Regular Coder

 
Join Date: Jun 2002
Location: United Kingdom Confused: Often
Posts: 859
Thanks: 0
Thanked 0 Times in 0 Posts
redhead is an unknown quantity at this point
Looks good. The menu item's shrink on :hover... intentional? They are too long to fit under it's heading... but you probably know all this already. That's in firefox 0.8.

Yeah, other than them little layout hiccups it looks good.
__________________
redhead
redhead is offline   Reply With Quote
Reply

Bookmarks

Jump To Top of Thread


Thread Tools
Rate This Thread
Rate This Thread:

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT +1. The time now is 10:55 AM.


Advertisement
Log in to turn off these ads.