Site Review!

[lnxusr86]

http://www.i-guru.tk/ - This is my first personal website, its not yet complete but i would like a review of it so far so i can improve it.

[ionsurge]

You've got the following issues in your site:

1. Your site does not validate @ xhtml 1.0.
2. You used frames.
3. You specified the font size - a big no no.
4. You have included your styles in the actual page, another no no.
5. Ditto but with scripts.
6. You've added a preloader - it is more annoying than anything, and sometimes it doesn't go away.
7. Your menu overlaps on to that picture of the server, or whatever it may be.
8. You've used a fixed layout.
9. The link to the W3C CSS validator should be:

<a href="http://jigsaw.w3.org/css-validator/check/referer">xxx</a>

What you have done doesn't validate the css on your page.
10. You've got a sp error, Curriculum Vitae is what it is meant to be, not Curiculam Vitae.
11. Latest, latest what? Try to say what a menu item points to. It removes any sense of confusion.
12. The menu isn't very neat, try using same-width tabs, or decent padding on both sides. The way it is just looks sort of messy.
13. It doesn't fit into an 800 x 600 screen - get a horizontal scrollbar.

In terms of design, it does look fine, but it needs all the above ammending.



------------------------------------
Edit: By the way, never say that you love your own designs...

[skinme!]

Just a quickie ionsurge: Why is inline CSS a no-no? I always use external CSS so that the style sheet can be cached and to reduce the html filesize. Is that what you mean? Or are there some other implications?

[ionsurge]

Exactly as you say, you only then need to load it once, instead of wasting time loading it every time you go to a page. There aren't any other implications, apart from the possibility of a lack of continuity.

[lnxusr86]

oooh boy lol, okay thankyou for u comments i'll try and fix the problems and by the way i havnt used frames, ive used the object tag instead which is supported by xhtml where as iframe isnt

[Paul Jr]

1. You're using tables for your layout.
2. You're using JS to do something that could be accomplished much more easily with CSS
3. Spacer .gif's... Ick
4. You have an external stylesheet -- excellent, but you still have all, or some, of your styles embedded -- bad.
5. There are all sorts of weird spaces and breaks in your images. I'm using Moz FireBird 0.7
6. The preloader isn't necessary, and quite annoying.
7. You have a linked image on your site, whose appearance indicates the site is authored with Valid XHTML -- which it is not.

[lnxusr86]

There are all sorts of weird spaces and breaks in your images. I'm using Moz FireBird 0.7

and how do i fix that?

[me']

Originally posted by skinme!
Just a quickie ionsurge: Why is inline CSS a no-no? I always use external CSS so that the style sheet can be cached and to reduce the html filesize. Is that what you mean? Or are there some other implications?

*cough*

Seperation and style and content? The entire driving motive behind XML and CSS?

[mindlessLemming]

Originally posted by lnxusr86
and how do i fix that?

You go to Mozilla.org and get a better browser for testing your work.


I've attached a screen shot of what it looks like in Moz 1.6

[skinme!]

Originally posted by me'
*cough*

Seperation and style and content? The entire driving motive behind XML and CSS?

Separation of style and content does not have to mean a two-file solution. Inline CSS in the HEAD of a document is still style separated from content.

[Paul Jr]

Yes, but embedding your styles is shooting yourself in the foot. One of the advantages with CSS, is using an external stylesheet that only has to be loaded once, thus cutting down the loading time of your site. If you're just embedding it all, you're not helping, and you might even be hurting.

[skinme!]

Which is what I said in my original question. I apologise for the stupid question. It just occurred to me that inline isn't as big a no-no as no CSS.

[lnxusr86]

Originally posted by mindlessLemming
You go to Mozilla.org and get a better browser for testing your work.


I've attached a screen shot of what it looks like in Moz 1.6

yeah i got mozzilla firebird... im staring at the screen what to i do to fix the prob i mean in the coding like...

[me']

Originally posted by skinme!
Separation of style and content does not have to mean a two-file solution. Inline CSS in the HEAD of a document is still style separated from content.

Inline styles are applied using the style attribute of elements. Styles contained within <style> and </style> are embedded, not inline. Hope that clears things up.

[skinme!]

Thanks for clearing that up.