PHP script not working - what is going wrong?

[howard-moore]

Hi,

I have the following bit of PHP that is not working. I am basically trying to put together a menu structure:

<?php
	$sql = "SELECT * FROM PCNET_$filename WHERE page_type='TOP_PAGE' AND live='checked' AND page_order!='x' ORDER BY parent_code, ABS(page_order), title";
	$sql_result = mysql_query ($sql, $connection ) or die ('request "Could not execute SQL query" '.$sql);
	while ($row = mysql_fetch_assoc($sql_result)) {
		echo '<dt><a href="'.($row["link"]).'?id='.($row["id"]).'">'.($row["menu_title"]).'</a></dt>';
			if ($row["parent_live"]=='checked') {
				include ('subgridmenu.php?parent_code=';
				echo	($row["id"])'');
			};
		};
?>

It shows all the pages in the menu list OK, but will not display anything in the subgridmenu.php file, which is as follows:

<?php
	$sql = "SELECT * FROM PCNET_$filename WHERE page_type='SUB_PAGE' AND live='checked' AND page_order!='x' ORDER BY ABS(page_order), title";
	$sql_result = mysql_query ($sql, $connection ) or die ('request "Could not execute SQL query" '.$sql);
	while ($row = mysql_fetch_assoc($sql_result)) {
		echo '<dd><a href="'.($row["link"]).'?id='.($row["id"]).'">'.($row["menu_title"]).'</a></dd>';
		}
?>

Can anyone give me any pointers as to why?

Thanks,
Neil

[tangoforce]

Have you tried running the second subgrid query through phpmyadmin to check that it runs? I've never trusted the or die() method, it's a bit flawed and doesn't always work.

[Fou-Lu]

You can't do this:

PHP Code:

                include ('subgridmenu.php?parent_code=';
                echo    ($row["id"])''); 


querystrings are HTTP, not FILE protocol based. You can assign $parent_code prior to the include of the subgridmenu.php, or even $_GET['parent_code'].

[sunfighter]

In top php this line

PHP Code:

include ('subgridmenu.php?parent_code='; 


is missing a closing parenthese.

PHP Code:

include ('subgridmenu.php?parent_code='); 


and shouldn't it have the parent_code variable?

This line

PHP Code:

echo    ($row["id"])''); 


At first I'd say it has an extra parenthese, but then I've never seen parentheses like that in an echo.

So I'm guessing:

PHP Code:

if ($row["parent_live"]=='checked') {
    include ('subgridmenu.php?parent_code='.$row["id"]);
    //echo ($row["id"]).'';
}; 


[tangoforce]

Originally Posted by sunfighter

So I'm guessing:

PHP Code:

if ($row["parent_live"]=='checked') {
    include ('subgridmenu.php?parent_code='.$row["id"]);
    //echo ($row["id"]).'';
}; 


As fou says, you can't use parameters on file system calls, only urls. Why? With the file system there is no webserver to deal with the parameters.

@Fou: Good catch.. I missed another glaringly obvious issue

I think I'm going to take a week or two off... I'm clearly loosing the plot

[howard-moore]

Originally Posted by tangoforce

As fou says, you can't use parameters on file system calls, only urls. Why? With the file system there is no webserver to deal with the parameters.

@Fou: Good catch.. I missed another glaringly obvious issue

I think I'm going to take a week or two off... I'm clearly loosing the plot

Thanks - that was exactly the issue!

Really appreciate your help.

Neil

[tangoforce]

It's Fou you need to thank - go up and click his big green "Thank User for this post" button