Checking for Upper-Case

[doubledee]

I am reviewing some old code that checks for Password Strength.

(My goal was to do the checks WITHOUT using Regular Expressions.)

The code below is supposed to check for at least one Uppercase Letter, but I don't think it works like the person who suggested it thought...

PHP Code:

    // Check for Uppercase Letter.
    if (empty($errors)){
        if (strtolower($newPass1) == $newPass1){
            $errors['newPass'] = 'Password must have at least 1 Uppercase Letter.';
        }
    } 


The last row is where it seems to fail...

$newPass1	strtolower($newPass1)	IF()
----------	----------------------	------
debbie		debbie			TRUE
Debbie		debbie			FALSE
DEBBIE		debbie			FALSE

Any suggestions?


Debbie

[Fou-Lu]

Okay, so what's the problem? With the code you have and that output chart assuming the comparison is done on equality is correct. 'DEBBIE' <> 'debbie', so comparing them for equality would come to false.
So if the goal is simply to determine if all characters as lower case, than that will do the job.

[doubledee]

Originally Posted by Fou-Lu

Okay, so what's the problem? With the code you have and that output chart assuming the comparison is done on equality is correct. 'DEBBIE' <> 'debbie', so comparing them for equality would come to false.
So if the goal is simply to determine if all characters as lower case, than that will do the job.

My brain wasn't working last night.

BTW, so what would happen if I used this instead... (3 equal signs)

PHP Code:

        if (strtolower($newPass1) === $newPass1){
            $errors['newPass'] = 'Password must have at least 1 Uppercase Letter.';
        } 


Debbie

[Fou-Lu]

Nothing different; these are already both strings, so the results would be the same. Identical is used for conflicting datatypes like checking 0 === false which is false, while 0 == false is true.

[doubledee]

Originally Posted by Fou-Lu

Nothing different; these are already both strings, so the results would be the same. Identical is used for conflicting datatypes like checking 0 === false which is false, while 0 == false is true.

Okay, that is what I thought.

Thanks for the help!


Debbie