Possible function problem, data not entering.

[paddyfields]

Hello.

I'm really really stuck on this and can't see where I'm going wrong. The idea is you click the button 'save search' and it enters two bits of information.. 'memberid' and 'location' into the database, via AJAX and displays a 'saved!' message after it's clicked.

I've debugged it as much as i know how.. echoing the $location and $memberid[0] which both show up correctly, and also testing the php address with the values just typed in, and it enters into the database correctly (ie http://mywebsite.com/savesearch_save...camden&mem=165 directly into the browser address).

Can anyone see what I've missed? At the moment you just click the button and nothing happens.

Cheers
Pat.

HTML

<div id="saveSearch"><button onclick="ajaxSaveSearch(true,<?php echo $location;?>,<?php echo $memberid[0];?>)">save search</button></div>

JAVASCRIPT

function ajaxSaveSearch(doSave, location, memberid) {
    var ajaxRequest; // The variable that makes Ajax possible!
    try {
        // Opera 8.0+, Firefox, Safari
        ajaxRequest = new XMLHttpRequest();
    } catch (e) {
        // Internet Explorer Browsers
        try {
            ajaxRequest = new ActiveXObject("Msxml2.XMLHTTP");
        } catch (e) {
            try {
                ajaxRequest = new ActiveXObject("Microsoft.XMLHTTP");
            } catch (e) {
                // Something went wrong
                alert("Your browser broke!");
                return false;
            }
        }
    }
    // Create a function that will receive data sent from the server
    ajaxRequest.onreadystatechange = function () {
        var div = document.getElementById("saveSearch");
        if (ajaxRequest.readyState == 4) {
            div.innerHTML = ajaxRequest.responseText;
        } else {
            div.innerHTML = "<img src='Images/icons/loading.gif' />";
        }
    }
    var queryString = "?location=" + location + "&mem=" + memberid;
    var url = doSave ? "savesearch_save.php" : "savesearch_forget.php";
    ajaxRequest.open("GET", url + queryString, true);
    ajaxRequest.send(null);
}

savesearch_save.php

PHP Code:

include("connect.php");

$location = $_GET['location'];
$themember = $_GET['mem'];

$sql = "INSERT IGNORE INTO savedsearch (memberid, location) VALUES ('$themember','$location')";
if (!mysql_query($sql, $con)) {
    die('Error: '.mysql_error());
}
echo "saved!"; 


[paddyfields]

solved it... should have concentrated on the html

ajaxSaveSearch('location',memberid)

[felgall]

That's one reason why you shouldn't jumble JavaScript with HTML and should keep all the JavaScript in a separate file instead.