Why does this function run twice on one click?

m2244 · 10-05-2012, 01:44 PM

I have a jQuery function that I finally got to work, the problem is that it seems to run twice, I get the alert twice. In FF it I get this alert up to 5 times!

Code:

<ul>
  <li>
    	(U) Spiral 1.5: <a class="glossaryLink" href="#">SCCVI</a> and <a class="glossaryLink" href="#">SCRI</a>  </li>
  <li> (U) Spiral 2:  <a class="glossaryLink" href="#">HBSS</a>  </li>
</ul>

Code:

function setGlossLinkListeners()
{
	$('a.glossaryLink').live("click", function(event){
		onRollOverPULink();
	});
}

This function runs multiple times.

Code:

function onRollOverPULink() 
{
	alert("onRollOverPULink");
}

m2244 · 10-05-2012, 01:59 PM

Well, I guess I fixed it, not sure why 'return false' fixes it though.

Code:

$('a.glossaryLink').live("click", function(event){
		onRollOverPULink();
		return false;
	});

VIPStephan · 10-05-2012, 02:04 PM

The best would be to remove the href attributes from the links in the first place. After all, you’re not linking anything anyway, so why the href? And when we’re thinking this further if a link isn’t linking anything, why have an anchor in the first place? These could very well be any type of element, e. g. spans.

m2244 · 10-05-2012, 02:21 PM

Quote:

Originally Posted by VIPStephan

The best would be to remove the href attributes from the links in the first place. After all, you’re not linking anything anyway, so why the href? And when we’re thinking this further if a link isn’t linking anything, why have an anchor in the first place? These could very well be any type of element, e. g. spans.

I think that if I took the href out it I would get the hand cursor.

xelawho · 10-05-2012, 02:53 PM

you can control the cursor style for any element you like, using css:

Code:

<style>
span{
cursor:pointer;
}
</style>

DanInMa · 10-05-2012, 06:11 PM

Code:

$('a.glossaryLink').live("click", function(event){
       event.preventDefault();
		onRollOverPULink();

	});