Resolved Javascript not working on IE8??

bigcasey123 · 09-21-2012, 04:30 PM

I keep getting this error "Expected identifier, string or number
index.php line: 61"

and here is my code

Code:

<script type="text/javascript">
(function( )
  {
  function doGoogle( searchFor ) { this.location.href="https://www.google.com/search?q="+searchFor; }
  function doYahoo( searchFor ) { this.location.href="http://search.yahoo.com/search?p="+searchFor; }
  function doBing( searchFor ) { this.location.href="http://www.bing.com/search?q="+searchFor; }
  function doAsk( searchFor ) { this.location.href="http://www.ask.com/web?q="+searchFor; }
      var choices = {
          "google" : { "logo" : "images/google.png", "code" : doGoogle },
          "yahoo" : { "logo" : "images/yahoo.png", "code" : doYahoo },
		  "bing" : { "logo" : "images/bing.png", "code" : doBing },
		  "ask" : { "logo" : "images/ask.png", "code" : doAsk },
		 
      }
	  
	  var form = document.getElementById("theForm");
      var engineCode = null;

      form.engine.onchange = function( )
      {
          var choice = this.value;
          if ( choice == "" ) return; // "choose one" selected?
          document.getElementById("theImage").src = choices[choice].logo;   
          engineCode = choices[choice].code;
     }
     
     form.doit.onclick = function( ) 
     {
         if ( engineCode != null )
         {
            engineCode( form.search.value );
         }
     }
  }
)( ); // self-invoke anonymous function
</script>

This is line 67

Quote:

66: form.engine.onchange = function( )
67: {

DaveyErwin · 09-21-2012, 05:01 PM

among other problems
you may have, this code
must not be executed before
window.onload(or body.onload)
has fired, also you must
have a form element
with the name (not id)
"engine"

raja.krishnan3 · 09-21-2012, 05:40 PM

Hi the below script is not working form me. Please any one help to find the issue.

<!DOCTYPE html>
<html>

<body>

<form method="post" name="input1" onsubmit="return validateinputs()">
<STRONG>Question 1</STRONG>: <br />
<input type="radio" name="q1" value="male" /> choice1<br />
<input type="radio" name="q1" value="female" /> choice2<br />
<STRONG>Question 2</STRONG>: <br />
<input type="radio" name="q2" value="male" /> choice1<br />
<input type="radio" name="q2" value="female" /> choice2<br />
<STRONG>Question 3</STRONG>: <br />
<input type="radio" name="q3" value="male" /> choice1<br />
<input type="radio" name="q3" value="female" /> choice2<br />
<input type="submit" value="Submit" />
</form>

<script language="JavaScript" type="text/javascript">




</script>

</body>
</html>

DanInMa · 09-21-2012, 05:55 PM

Quote:

Originally Posted by raja.krishnan3

Hi the below script is not working form me. Please any one help to find the issue.......

Please read the posting rules :
http://www.codingforums.com/showthread.php?t=82672
http://www.codingforums.com/showthread.php?t=2090

Philip M · 09-21-2012, 07:43 PM

raja.krishnan3 - please do not hijack someone else's thread. Prefer to start a new thread of your own.

Before posting again please read and comply with the forum rules and posting guideines.

bigcasey123 · 09-21-2012, 08:41 PM

Quote:

Originally Posted by DaveyErwin

among other problems
you may have, this code
must not be executed before
window.onload(or body.onload)
has fired, also you must
have a form element
with the name (not id)
"engine"

This code isn't executed before window.onload (or body.onload) and i had a name "engine" not id. Here is my body code

Code:

<body>
 
 
 
 
 
 <div id="header">
 <b>  &nbsp
      &nbsp
 <a href="index.php" class="links" style="color:white">Web</a> &nbsp &nbsp
 <a href="image.php" class="links">Images</a> &nbsp &nbsp
 <a href="videos.php" class="links">Videos</a> &nbsp &nbsp
 <a href="adult videos.php" class="links">Adult Videos</a> &nbsp &nbsp
 </b>
 </div>
 
 
 <img id="theImage" name="theImage" />
 
<form id="theForm" onSubmit="return doSearch()" name="theForm">
<input name="search" id="searchbox"/>
<br/>
Use what engine:
    <select name="engine">
	<option> Choose one</option>
    <option value="google">Google</option>
    <option value="yahoo">Yahoo</option>
    <option value="ask">ask</option>
	<option value="bing">bing</option>
    </select>
<br/>
<br />
<center><input type="button" value="Search!" name="doit"/></center>
</form>

<script type="text/javascript">
(function( )
  {
  function doGoogle( searchFor ) { this.location.href="https://www.google.com/search?q="+searchFor; }
  function doYahoo( searchFor ) { this.location.href="http://search.yahoo.com/search?p="+searchFor; }
  function doBing( searchFor ) { this.location.href="http://www.bing.com/search?q="+searchFor; }
  function doAsk( searchFor ) { this.location.href="http://www.ask.com/web?q="+searchFor; }
      var choices = {
          "google" : { "logo" : "images/google.png", "code" : doGoogle },
          "yahoo" : { "logo" : "images/yahoo.png", "code" : doYahoo },
		  "bing" : { "logo" : "images/bing.png", "code" : doBing },
		  "ask" : { "logo" : "images/ask.png", "code" : doAsk },
		 
      }
	  
	  var form = document.getElementById("theForm");
      var engineCode = null;

      form.engine.onchange = function( )
      {
          var choice = this.value;
          if ( choice == "" ) return; // "choose one" selected?
          document.getElementById("theImage").src = choices[choice].logo;   
          engineCode = choices[choice].code;
     }
     
     form.doit.onclick = function( ) 
     {
         if ( engineCode != null )
         {
            engineCode( form.search.value );
         }
     }
  }
)( ); // self-invoke anonymous function
</script>

 </body>

xelawho · 09-21-2012, 08:46 PM

oh, I see the problem. Trailing comma. Delete the comma at the end of this line:

Code:

"ask" : { "logo" : "images/ask.png", "code" : doAsk },

bigcasey123 · 09-21-2012, 08:48 PM

Yaaa thanks xelawho

xelawho · 09-21-2012, 08:49 PM

No, it's the comma. Works fine in IE. You wouldn't even get that error if you had javascript turned off.