Resolved using data from mysql_fetch_array

[jake66]

Hi,
I have taken data from MySQL in the standard way and have $row['datefield'] etc to use in a table. Depending on a specific column value, some of the records are editable and so an edit link should be shown only next to those records in a separate column. I don't really understand how I can make this happen.
Here's my code

while($rows=mysql_fetch_array($result)){
	$rows['date'] = date( "d/m/Y", $rows['date_ts'] );
?>
<tr>
<td nowrap><? echo $rows['datefield']; ?></td>
<td nowrap><? echo $rows['shift']; ?></td>
<td nowrap> <? echo $rows['reason'];?></td>
<td nowrap> <? echo $rows['person_covering']; ?></td>
<td nowrap> &pound;<? echo $rows['cost']; ?></td>
<td nowrap> <? 	if(  substr( trim( $rows['staff_approved'] ), 0, 3)  === "Yes"){ }
else { ?> <a href="updaterecord.php?id=<? echo $rows['id'];?>">Edit<? }?>

I am checking whether the staff approved column starts with Yes and if it does not then showing an edit link. However this seems to show edit links for all of them....

Any help gratefully welcomed,
Jake

[_Aerospace_Eng_]

What kind of data is contained in 'staff_approved'? Why can't you just check the value rather than trying to do a substr?

PHP Code:

<?php
while($rows=mysql_fetch_array($result))
{
    $rows['date'] = date( "d/m/Y", $rows['date_ts'] );
?>
    <tr>
        <td nowrap><?php echo $rows['datefield']; ?></td>
        <td nowrap><?php echo $rows['shift']; ?></td>
        <td nowrap> <?php echo $rows['reason'];?></td>
        <td nowrap> <?php echo $rows['person_covering']; ?></td>
        <td nowrap> &pound;<?php echo $rows['cost']; ?></td>
        <td nowrap><?php if(strncasecmp(trim($rows['staff_approved']),'yes') != 0)
        {
            ?>
            <a href="updaterecord.php?id=<?php echo $rows['id'];?>">Edit</a>
            <?php
        }
        ?>
        </td>
    </tr>
<?php
}
?>

[Old Pedant]

First of all, this makes no sense:

	$rows['date'] = date( "d/m/Y", $rows['date_ts'] );
        ...
     <td nowrap><? echo $rows['datefield']; ?></td>

You create a new element in the array--"date"--but then never use it. Instead, you use something called "datefield"??? What is going on?

*********

Another way to do this, though, would be to enhance your SQL query. And in the process get rid of the need to convert the date in PHP.

You don't bother to show that to us, but just as an example (and guessing about your date vs. datefield funniness):

SELECT DATE_FORMAT(date_ts,'%d/%m/%Y') AS datefield,
       datefield, shift, reason, person_covering, cost,
       IF ( staff_approved LIKE 'yes%', 'yes', 'no' ) AS doEdit
FROM yourtable
WHERE ...

My "doEdit" may be backwards. If so, just swap the 2nd and 3rd arguments of the if.

Then, in the PHP code:

<?php
while($rows=mysql_fetch_array($result))
{
?>
    <tr>
        <td nowrap><?php echo $rows['datefield']; ?></td>
        <td nowrap><?php echo $rows['shift']; ?></td>
        <td nowrap> <?php echo $rows['reason'];?></td>
        <td nowrap> <?php echo $rows['person_covering']; ?></td>
        <td nowrap> &pound;<?php echo $rows['cost']; ?></td>
        <td nowrap><?php if($rows['doEdit'] == 'yes')
        {
            ?>
            <a href="updaterecord.php?id=<?php echo $rows['id'];?>">Edit</a>
            <?php
        }
        ?>
        </td>
    </tr>
<?php
}
?>

[jake66]

Thanks Old Pedant, as ever. To your first point - sorry that was a copy and paste mistake - different versions....long story.
Thanks so much for your query and the if which was very useful and solved my problem!
Jake