syntax error??

[realzahed]

Can someone point where i'm going wrong? I want to evaluate the values of 'miles' to be >=0 and 'putime' to between 0 and 24 only.

<script type = "text/javascript">
	function TaxiFare() {
	// calculates taxi fare based upon miles travelled
	// and the hour of the day in military time (0-23).

	var baseFare = 2.50;
	var costPerMile = 2.00;
	var nightSurcharge = 0.50; // 8pm to 6am, every night

	var milesTravelled = Number(document.getElementById("miles").value);
	var pickupTime = Number(document.getElementById("putime").value);

	var cost = baseFare + (costPerMile * milesTravelled);

	// add the nightSurcharge to the cost if it is after
	// 10pm or before 6am
	if (pickupTime >= 22 || pickupTime < 6) {
	cost += nightSurcharge;
	}
	if((document.getElementById('miles').value>=0)&&(document.getElementById('putime').value>=0||<=24) {
	alert("Your taxi fare is $"  + cost.toFixed(2));
	}
	else{return 0;}
	}

	</script>

[Philip M]

You already have a thread on this topic!

if((document.getElementById('miles').value>=0)&&(document.getElementById('putime').value>=0||<=24) {

Use your error console to identify syntax errors! And inform the user what the problem is.

var milesTravelled = Number(document.getElementById("miles").value) || 0;
if ((milesTravelled < 1) || (milesTravelled > 200)) {
alert ("You must enter 1 - 200 miles");
document.getElementById("miles").focus();
return false;
}

var pickupTime = Number(document.getElementById("putime").value) || 0;
if ((pickupTime < 0) || (pickupTime > 23)) {  // note the hours are 0-23.  There is no 24 hour, midnight is 0 hours
alert ("The time must be 0-23 hours");
document.getElementById("putime").focus();
return false;
}

var cost = baseFare + (costPerMile * milesTravelled);

If I were you I would check the assignment to confirm that the extra night charge is supposed to be a flat $0.50 and not $0.50 per mile which is what I would expect.

[realzahed]

yes it's a flat $0.50 and not $0.50 per mile.