Sorting Ip address within array

[sephlaire]

I am trying to make an addition to a .js plugin for a wiki. Currently it does not support sorting my IP address. So far I have created the below code which does more than the script initially did, but is still not sorting 100% correctly.

Any tips?

sort_ipaddr: function(a,b){
	aa = a[0].split(".",4);
	bb = b[0].split(".",4);
	var counti = 0;
	
	for (var i=0; i<4; i++) {
        	if (parseInt(parseFloat(aa[i])) == parseInt(parseFloat(bb[i]))){}
		if (parseInt(parseFloat(aa[i])) < parseInt(parseFloat(bb[i]))){counti--}
		if (parseInt(parseFloat(aa[i])) > parseInt(parseFloat(bb[i]))){counti++}
	}
    return counti;
  },

EDIT

I've also tried this which is closer but still not there.

sort_ipaddr: function(a,b){
	aa = a[0].split(".",4);
	bb = b[0].split(".",4);
	
	var resulta = (aa[3]+(aa[2]*256)+(aa[1]*256*256)+(aa[0]*256*256*256));
	var resultb = (bb[3]+(bb[2]*256)+(bb[1]*256*256)+(bb[0]*256*256*256));
	
	return resulta-resultb;
  },

This results in a list like so:
10.1.15.22
10.1.16.22
10.1.15.23
10.1.15.24
10.1.16.24
10.1.15.25

[Old Pedant]

Your second one is close, but the very first addition in each resultX calculation will be a string concatenation instead of arithmetic add. So that means that you end up comparing something like "24xxxxx" vs. "25xxxxx" and get the results you are seeing.

Keep it simple:

sort_ipaddr: function(a,b){
	aa = a[0].split(".");
	bb = b[0].split(".");
	
        var resulta = aa[0]*0x1000000 + aa[1]*0x10000 + aa[2]*0x100 + aa[3]*1;
        var resultb = ab[0]*0x1000000 + ab[1]*0x10000 + ab[2]*0x100 + ab[3]*1;
	
	return resulta-resultb;
  },

[sephlaire]

--EDIT Removed--

I spoke too soon! Works perfectly thank you. My mistake was that in the split I used variables aa and bb. In the resultsx line aa and ab were used as variables.

[Old Pedant]

Oops...I missed that, too. But glad it works now.

If you didn't know, multiplying by anything (including 1) is one way to force the conversion of the string you get from split to become a number.

[Philip M]

Originally Posted by Old Pedant

If you didn't know, multiplying by anything (including 1) is one way to force the conversion of the string you get from split to become a number.

I thought you considered that to be a hack!

[Old Pedant]

LOL! Depends on usage. Here, the whole point was to multiply each part of the IP address by the apprpriate number. I certainly wouldn't do parseInt(ip[0[) * 0x1000000 so why not use the same pattern throughout?

Beside, if it really is an IP address we *know* it will be a number. No detection of invalid values needed, one hopes.