shoulnt this work?

kimboslice · 05-16-2010, 07:24 PM

this script shows results from a search , im trying to add a if else statement to let the users know if no matches was found
shouldnt the code work? when a search matches it shows the fields from the table but when nothing match it doesnt show the else statement

thanks Kimbo

<body>
<?php

$con = mysql_connect("localhost","xxxx","xxxxx");
if (!$con)
{
die('Could not connect: ' . mysql_error());
}

mysql_select_db("xxxxxx", $con);

$search =check($_POST['search'], "you havent enterd anything , <a href=personal.php>go back</a> ");

function check($data, $error='')

{

$data = trim($data);
$data = stripslashes($data);
$data = htmlspecialchars($data);
if ($error && strlen($data) == 0) {
die($error);
}
return $data;
}

$search=$_POST["search"];

$result = mysql_query("SELECT * FROM personal WHERE name LIKE '%$search%'");

while($r=mysql_fetch_array($result))
{

$name=$r["name"];
$adress=$r["adress"];
$areacode=$r["areacode"];
$phonenumber=$r["phonenumber"];
$email=$r["email"];
$id=$r["id"];

if($result){ //works

echo "$name $adress $area code $phonenumber 
$email ";
}

else {
echo "no records was found"; //dont work
}

}

?>

met · 05-16-2010, 07:29 PM

the reason it doesn't work is that providing a valid SQL query is provided, mysql_query will return true, regardless of results.

even if no results are found, it's still "true", so the else condition never occurs.

[snip, misread your code]

PHP Code:


			
$result = mysql_query("SELECT * FROM personal WHERE name LIKE '%$search%'");

$num_results=mysql_num_rows($result);



/* get results.. */



if($num_results>0) { // there are results..



    while($r=mysql_fetch_array($result))

    {

            $name=$r["name"];

            $adress=$r["adress"];

            $areacode=$r["areacode"];

            $phonenumber=$r["phonenumber"];

            $email=$r["email"];

            $id=$r["id"];

            echo "$name <br> $adress <br> $area code <br> $phonenumber<br /> $email <br>";

    } // while



} else {



    echo "no records was found"; //dont work



}

kimboslice · 05-16-2010, 07:51 PM

thanks alot

kimboslice · 05-16-2010, 11:20 PM

it returns else statement now both when the record doesnt match and when it does . any suggestions?

_Aerospace_Eng_ · 05-16-2010, 11:30 PM

Post your latest code.

kimboslice · 05-16-2010, 11:53 PM

thanks, current code:

<div >
<?php

include ('db_connect.php');

$search = check($_POST['search'], "you didnt enter anything, <a href=personal.php>go back</a> ");

function check($data, $error='') {

$data = trim($data);
$data = stripslashes($data);
$data = htmlspecialchars($data);
if ($error && strlen($data) == 0) / {

die($error);
}
return $data;
}

$search=$_POST["search"];

$result = mysql_query("SELECT * FROM personal WHERE name LIKE '%$search%'");

if($num_results>0)

while($r=mysql_fetch_array($result))
{

$namn=$r["name"];
$adress=$r["adress"];
$postnummer=$r["areacode"];
$telefonnummer=$r["phonenumber"];
$email=$r["email"];
$id=$r["id"];

echo "$name $adress $areacode $phonenumber 
$email ";

}
else {

echo "no records was found";

}

?>

_Aerospace_Eng_ · 05-17-2010, 12:11 AM

Looks like you missed this line

PHP Code:


			
$num_results=mysql_num_rows($result);

It goes just after $result.

kimboslice · 05-17-2010, 12:41 AM

thanks to many hours in front of the computer