Enjoy an ad free experience by logging in. Not a member yet?
Register .
PM User | 1
New Coder
Join Date: Feb 2010
Posts: 30
Thanks: 0
Thanked 0 Times in 0 Posts
HELP PLZ! new to php. Drop Down SORT by
Hi i need to have a drop down menu choose how to sort my tagboard.
Tagboard works fine.
I want to sort by either tag_date, tag_cid, or tag_name.
idk what is wrong with it.
i have error reporting and still dont understand, can someone just please point out to me what the problem is and HOW TO FIX IT!.
it has something to do with the variables, i dont think im calling the right ones? can someone jujst please fix this?
Thank you guys so much, i jsut want to get this damn project done with.
*note- i have two drop downs in there, for testing, you can remove one, just need one functional drop down*
the code:
PHP Code:
<?php
( E_ALL );
$selected = array();
$orderby = $_GET [ orderby ];
$orderby ) { $orderby = 'tag_date' ; }
$orderby == 'tag_date' )
$orderby_query = "order by tag_date" ;
$orderby == 'tag_cid' )
$orderby_query = "order by tag_cid" ;
$orderby == 'tag_name' )
$orderby_query = "order by tag_name" ;
$orderby ); }
// If $orderby was valid set the selected sort option for the form.
if( $orderby )
$selected [ $orderby ] = 'selected' ;
// Now run your SQL query with the $orderby_query variable. Ex:
$query = "select * from tagboard $orderby_query" ;
// SQL code goes here..
?>
<?
( 'HOST' , "xxxx" );
define ( 'USER' , "xxxx" );
define ( 'PASS' , "xx" );
define ( 'DB' , "xxx" );
doTags ()
$conx = mysql_connect ( HOST , USER , PASS ) or die( "Unable to connect to MySQL Server" );
mysql_select_db ( DB ) or die( "Unable to select Database" );
$stSql = "SELECT tag_name, tag_cid, tag_entry, tag_date FROM tagboard $orderby" ;
$arrResult = @ mysql_query ( $stSql );
$arrResult ) { echo "Query Failed - Unable to Retrieve tags - " . mysql_error (). " – Action Aborted" ; exit(); }
mysql_num_rows ( $arrResult ) >= 1 )
$arrRow = mysql_fetch_assoc ( $arrResult ))
?>
<? echo date ( "F j, Y, g:i a" , $arrRow [ 'tag_date' ]); ?> ] </span></td>
<? echo stripslashes ( $arrRow [ 'tag_name' ]); ?> </span></td>
<? echo stripslashes ( $arrRow [ 'tag_cid' ]); ?> </span></td>
<? echo nl2br ( stripslashes ( $arrRow [ 'tag_entry' ])); ?> </span></td>
<?
}
?>
<p style="font-family: verdana,arial,helvetica,sans-serif; font-size: 11px; background-color: #FFFFFF">No entries to display</p>
<?
}
doBoard ()
?>
<html>
<?php print $param1 ; ?> ">
<?php print $param2 ; ?> ">
<?php print $selected [ $orderby ]; ?> >Name</option>
<?php print $selected [ $orderby ]; ?> >Price (Low - High)</option>
<?php print $selected [ $orderby ]; ?> >Price (High - Low)</option>
<?php print $selected [ $orderby ]; ?> >Name</option>
<?
}
doInsert ( $__name , $__entry , $__cid )
$conx = mysql_connect ( HOST , USER , PASS ) or die( "Unable to connect to MySQL Server" );
mysql_select_db ( DB ) or die( "Unable to select Database" );
$__name = addslashes ( $__name );
$__url = addslashes ( $__cid );
$__entry = addslashes ( $__entry );
$__name ))
?>
<p style="font-family: verdana,arial,helvetica,sans-serif; font-size: 11px; background-color: #FFFFFF">Name Field Is Required</p>
<?
} elseif (empty( $__entry ))
?>
<p style="font-family: verdana,arial,helvetica,sans-serif; font-size: 11px; background-color: #FFFFFF">Entry Field Is Required</p>
<?
} else {
$stSql = "INSERT INTO tagboard(tagId, tag_name, tag_cid, tag_entry, tag_date) values('', '$__name', '$__cid', '$__entry', " . time (). ")" ;
$arrResult = @ mysql_query ( $stSql );
$arrResult ) { echo "Query Failed - Unable to Retrieve tags - " . mysql_error (). " – Action Aborted" ; exit(); }
mysql_affected_rows () == 1 )
?>
<meta http-equiv="refresh" content="3;url='board.php?do=Tags'">
<?
} else {
"Unable to Add Entry to Database" ;
?>
<meta http-equiv="refresh" content="5;url='board.php?do=Tags'">
<?
}
$do = (isset( $_GET [ 'do' ]) ? $_GET [ 'do' ] : FALSE );
$do ) {
"Board" :
doBoard ();
"Tags" :
doTags ();
"Insert" :
doInsert ( $_POST [ '__name' ], $_POST [ '__entry' ], $_POST [ '__cid' ]);
doBoard ();
?>
PM User | 2
God Emperor
Join Date: Sep 2002
Location: Saskatoon, Saskatchewan
Posts: 15,662
Thanks: 4
Thanked 2,452 Times in 2,421 Posts
Is this thread directly related to
this one ?
__________________
As of PHP 5.5, the MySQL library has been officially deprecated. It is recommended to move to either MySQLi or PDO libraries for your mysql connectivity. See here for help choosing which interface you prefer:
http://php.net/manual/en/mysqlinfo.api.choosing.php
PM User | 3
New Coder
Join Date: Feb 2010
Posts: 30
Thanks: 0
Thanked 0 Times in 0 Posts
yeah, ive posted on many forums, i guess i lost track of that one. My apologies, you can delete that one. i'm just looking for a proper solution.
fou, you've helped me before and you were a total lifesaver. Could you possibly help me find out why my code isnt working?
this is my updated code:
PHP Code:
<?php
( 'display_errors' , 1 );
error_reporting ( E_ALL | E_STRICT );
$selected = array();
$orderby = (isset( $_GET [ "orderby" ])) ? strip_tags ( $_GET [ "orderby" ]) : 'default' ;
$orderby_query = null ;
$orderby ) {
'cid' :
$orderby_query = "order by tag_cid asc" ;
'name' :
$orderby_query = "order by tag_name" ;
'default' :
'date' :
$orderby_query = "order by tag_date DESC" ;
// If $orderby was valid set the selected sort option for the form.
if( $orderby ) {
$selected [ $orderby ] = 'selected' ;}
// Now run your SQL query with the $orderby_query variable. Ex:
$query = 'SELECT tag_name, tag_cid, tag_entry, tag_date FROM tagboard SORT by tag_cid' ;
// SQL code goes here..
define ( 'HOST' , "xx" );
define ( 'USER' , "xx" );
define ( 'PASS' , "xx" );
define ( 'DB' , "xx" );
doTags ()
$orderby_query ;
$conx = mysql_connect ( HOST , USER , PASS ) or die( "Unable to connect to MySQL Server" );
mysql_select_db ( DB ) or die( "Unable to select Database" );
$stSql = "SELECT tag_name, tag_cid, tag_entry, tag_date FROM tagboard $orderby_query" ;
$arrResult = @ mysql_query ( $stSql );
$arrResult ) { echo "Query Failed - Unable to Retrieve tags - " . mysql_error (). " – Action Aborted" ; exit(); }
mysql_num_rows ( $arrResult ) >= 1 )
$arrRow = mysql_fetch_assoc ( $arrResult ))
?>
<? echo date ( "F j, Y, g:i a" , $arrRow [ 'tag_date' ]); ?> ] </span></td>
<? echo stripslashes ( $arrRow [ 'tag_name' ]); ?> </span></td>
<? echo stripslashes ( $arrRow [ 'tag_cid' ]); ?> </span></td>
<? echo nl2br ( stripslashes ( $arrRow [ 'tag_entry' ])); ?> </span></td>
<?
}
?>
<p style="font-family: verdana,arial,helvetica,sans-serif; font-size: 11px; background-color: #FFFFFF">No entries to display</p>
<?
}
doBoard ()
?>
<html>
<?php print $selected [ $orderby ]; ?> >Name</option>
<?
}
doInsert ( $__name , $__entry , $__cid )
$conx = mysql_connect ( HOST , USER , PASS ) or die( "Unable to connect to MySQL Server" );
mysql_select_db ( DB ) or die( "Unable to select Database" );
$__name = addslashes ( $__name );
$__url = addslashes ( $__cid );
$__entry = addslashes ( $__entry );
$__name ))
?>
<p style="font-family: verdana,arial,helvetica,sans-serif; font-size: 11px; background-color: #FFFFFF">Name Field Is Required</p>
<?
} elseif (empty( $__entry ))
?>
<p style="font-family: verdana,arial,helvetica,sans-serif; font-size: 11px; background-color: #FFFFFF">Entry Field Is Required</p>
<?
} else {
$stSql = "INSERT INTO tagboard(tagId, tag_name, tag_cid, tag_entry, tag_date) values('', '$__name', '$__cid', '$__entry', " . time (). ")" ;
$arrResult = @ mysql_query ( $stSql );
$arrResult ) { echo "Query Failed - Unable to Retrieve tags - " . mysql_error (). " – Action Aborted" ; exit(); }
mysql_affected_rows () == 1 )
?>
<meta http-equiv="refresh" content="3;url='board.php?do=Tags'">
<?
} else {
"Unable to Add Entry to Database" ;
?>
<meta http-equiv="refresh" content="5;url='board.php?do=Tags'">
<?
}
$do = (isset( $_GET [ 'do' ]) ? $_GET [ 'do' ] : FALSE );
$do ) {
"Board" :
doBoard ();
"Tags" :
doTags ();
"Insert" :
doInsert ( $_POST [ '__name' ], $_POST [ '__entry' ], $_POST [ '__cid' ]);
doBoard ();
?>
errors im getting:
Notice: Use of undefined constant orderby - assumed 'orderby' in /home/content/t/m/s/tmsolutions/html/board.php on line 6
Notice: Undefined index: orderby in /home/content/t/m/s/tmsolutions/html/board.php on line 6
Notice: Undefined variable: orderby in /home/content/t/m/s/tmsolutions/html/board.php on line 7
Notice: Undefined variable: orderby in /home/content/t/m/s/tmsolutions/html/board.php on line 50
Fou, Thank you my friend.
PM User | 4
God Emperor
Join Date: Sep 2002
Location: Saskatoon, Saskatchewan
Posts: 15,662
Thanks: 4
Thanked 2,452 Times in 2,421 Posts
These two code blocks do not match. The second one will also have notices though.
As for the first block:
- Constant here is $orderby = $_GET[orderby]; , use $_GET['orderby']
- Index doesn't exist, ensure that you're defaulting it with:
$orderby = isset($_GET['orderby']) ? $_GET['orderby'] : 'tag_date';
The remaining ones occur because you're else statement is unsetting the $orderby variable. That should happen as long as you don't have a valid match:
if (!$orderby) should be false, so it will never default with that code.
Also, as you start executing you're functions, you will find that more and more notices will pop up. You'll need to look at properly handling
scope .
__________________
As of PHP 5.5, the MySQL library has been officially deprecated. It is recommended to move to either MySQLi or PDO libraries for your mysql connectivity. See here for help choosing which interface you prefer:
http://php.net/manual/en/mysqlinfo.api.choosing.php
PM User | 5
New Coder
Join Date: Feb 2010
Posts: 30
Thanks: 0
Thanked 0 Times in 0 Posts
I changed the first block you said, and im still getting errors. i dont know what the issue is?
if you can jsut alter the code, so i know what the issue is? i;ve psoted many places, googled the heck out of this thing, and even got a book. i am just trying to move onto the next project and leave this one done and over with.
Fou Lou, can u like copy my code into your software, and just fix this please? i know im asking alot, but ive been on this for over 8 hours and im just looking to resolve this issue.
you can change names to whatever u want.
aslong as it sorts by the tag_date,tag_cid,tag_name.
or if you want to just leave the tagbaord,and just add a drop down option that will work - thatd be amazing.
Thanks in advance, Fou-Lou you are a god among men.
joey
PM User | 6
God Emperor
Join Date: Sep 2002
Location: Saskatoon, Saskatchewan
Posts: 15,662
Thanks: 4
Thanked 2,452 Times in 2,421 Posts
PHP Code:
$selected = array();
$orderby = isset( $_GET [ 'orderby' ]) ? $_GET [ 'orderby' ] : 'tag_date' ;
// Looks to me like tag_date should be the default, this is beter of using either an else with the tag_date or a switch
$orderby_query = 'ORDER BY ' ;
$orderby )
'tag_cid' :
$orderby_query .= 'tag_cid' ;
'tag_name' :
$orderby_query .= 'tag_name' ;
$orderby_query .= 'tag_date' ;
That replaces this
PHP Code:
$selected = array();
$orderby = $_GET [ orderby ];
$orderby ) { $orderby = 'tag_date' ; }
$orderby == 'tag_date' )
$orderby_query = "order by tag_date" ;
$orderby == 'tag_cid' )
$orderby_query = "order by tag_cid" ;
$orderby == 'tag_name' )
$orderby_query = "order by tag_name" ;
$orderby ); }
Post back with the errors after thats been corrected. You'll have more once you start trying you're functions because of the scope issues.
__________________
As of PHP 5.5, the MySQL library has been officially deprecated. It is recommended to move to either MySQLi or PDO libraries for your mysql connectivity. See here for help choosing which interface you prefer:
http://php.net/manual/en/mysqlinfo.api.choosing.php
PM User | 7
New Coder
Join Date: Feb 2010
Posts: 30
Thanks: 0
Thanked 0 Times in 0 Posts
Parse error: syntax error, unexpected '{' in /home/content/t/m/s/tmsolutions/html/board2.php on line 10
this is my current code:
is it possible for you just copy it into your software and fix and post back? i think the issues are with the scope, how do i put it into a variable or function or wahteveR? im so new at php, its not even funny, i just need this project done to get it over with! :d ha thanks.
PHP Code:
<?php
( E_ALL ); // Allowed Order Bys, Map these keys to these field names
$orderMap = array( 'date' => 'tag_date' ,
'cid' => 'tag_cid' ,
'name' => 'tag_name' ,
$orderBy = 'date' ; // Default Key
if ( array_key_exists ( $_GET [ 'orderby' ], $orderMap ) {
$orderBy = $_GET [ 'orderby' ];
$query = "select * from tagboard ORDER BY " . $orderMap [ $orderBy ]; /* No SQL injection is possible, because we verified it was in our array */
if( $orderby == 'date' ) {
$orderby_query = "order by tag_date" ;
$orderby == 'cid' ) {
$orderby_query = "order by tag_cid" ;
$orderby == 'name' ) { $orderby_query = "order by tag_name" ;
$orderby = null ;}
// SQL code goes here..
define ( 'HOST' , "xx" );
define ( 'USER' , "xx" );
define ( 'PASS' , "xx
xx ");
Unable to connect to MySQL Server ");
Unable to select Database ");
SELECT tag_name , tag_cid , tag_entry , tag_date FROM tagboard $orderby_query ";
Query Failed - Unable to Retrieve tags - ".mysql_error()." – Action Aborted "; exit(); }
100 % " height=" 47 " border=" 0 " align=" center " bgcolor=" #FFFFFF">
< tr >
td width = "30%" height = "30" >< span style = "font-family: verdana,arial,helvetica,sans-serif; font-size: 9px; color: #666666" > [<? echo date ( "F j, Y, g:i a" , $arrRow [ 'tag_date' ]); ?> ] </span></td>
<? echo stripslashes ( $arrRow [ 'tag_name' ]); ?> </span></td>
<? echo stripslashes ( $arrRow [ 'tag_cid' ]); ?> </span></td>
<? echo nl2br ( stripslashes ( $arrRow [ 'tag_entry' ])); ?> </span></td>
<?
}
?>
<p style="font-family: verdana,arial,helvetica,sans-serif; font-size: 11px; background-color: #FFFFFF">No entries to display</p>
<?
}
doBoard ()
?>
<html>
<?php if ( $orderBy == 'cid' ) { echo 'selected' ; } ?> >CID</option> <option value="date" <?php if ( $orderBy == 'date' ) { echo 'selected' ; } ?> >Date</option> </select> </td>
<?php print $selected [ $orderby ]; ?> >Name</option>
<?
}
doInsert ( $__name , $__entry , $__cid )
$conx = mysql_connect ( HOST , USER , PASS ) or die( "Unable to connect to MySQL Server" );
mysql_select_db ( DB ) or die( "Unable to select Database" );
$__name = addslashes ( $__name );
$__url = addslashes ( $__cid );
$__entry = addslashes ( $__entry );
$__name ))
?>
<p style="font-family: verdana,arial,helvetica,sans-serif; font-size: 11px; background-color: #FFFFFF">Name Field Is Required</p>
<?
} elseif (empty( $__entry ))
?>
<p style="font-family: verdana,arial,helvetica,sans-serif; font-size: 11px; background-color: #FFFFFF">Entry Field Is Required</p>
<?
} else {
$stSql = "INSERT INTO tagboard(tagId, tag_name, tag_cid, tag_entry, tag_date) values('', '$__name', '$__cid', '$__entry', " . time (). ")" ;
$arrResult = @ mysql_query ( $stSql );
$arrResult ) { echo "Query Failed - Unable to Retrieve tags - " . mysql_error (). " – Action Aborted" ; exit(); }
mysql_affected_rows () == 1 )
?>
<meta http-equiv="refresh" content="3;url='board.php?do=Tags'">
<?
} else {
"Unable to Add Entry to Database" ;
?>
<meta http-equiv="refresh" content="5;url='board.php?do=Tags'">
<?
}
$do = (isset( $_GET [ 'do' ]) ? $_GET [ 'do' ] : FALSE );
$do ) {
"Board" :
doBoard ();
"Tags" :
doTags ();
"Insert" :
doInsert ( $_POST [ '__name' ], $_POST [ '__entry' ], $_POST [ '__cid' ]);
doBoard ();
?>
PM User | 8
God Emperor
Join Date: Sep 2002
Location: Saskatoon, Saskatchewan
Posts: 15,662
Thanks: 4
Thanked 2,452 Times in 2,421 Posts
No, I'm at work and can't test any php code.
PHP Code:
if ( array_key_exists ( $_GET [ 'orderby' ], $orderMap ) {
$orderBy = $_GET [ 'orderby' ];
You're missing a closing ) on that if.
__________________
As of PHP 5.5, the MySQL library has been officially deprecated. It is recommended to move to either MySQLi or PDO libraries for your mysql connectivity. See here for help choosing which interface you prefer:
http://php.net/manual/en/mysqlinfo.api.choosing.php
PM User | 9
New Coder
Join Date: Feb 2010
Posts: 30
Thanks: 0
Thanked 0 Times in 0 Posts
heh ok well..this is my most current code.
it's pieced from working codes..so
PHP Code:
<?php
= array();
$sortby = $_GET [ orderby ];
$orderby ) { $orderby = 'tag_name' ; }
$orderby == 'tag_name' )
$orderby_query = "order by tag_date" ;
$orderby == 'tag_date' )
$orderby_query = "order by tag_cid" ;
$orderby == 'tag_cid' )
$orderby_query = "order by tag_name" ;
$orderby ); }
// If $orderby was valid set the selected sort option for the form.
if( $orderby )
$selected [ $orderby ] = 'selected' ;
// Now run your SQL query with the $orderby_query variable. Ex:
$query = "select * from tagboard $orderby_query" ;
// SQL code goes here..
define ( 'HOST' , "xx" );
define ( 'USER' , "xx" );
define ( 'PASS' , "xxx" );
define ( 'DB' , "xx" );
doTags ()
$orderby_query ;
$conx = mysql_connect ( HOST , USER , PASS ) or die( "Unable to connect to MySQL Server" );
mysql_select_db ( DB ) or die( "Unable to select Database" );
$stSql = "SELECT tag_name, tag_cid, tag_entry, tag_date FROM tagboard order by $sortby" ;
$arrResult = @ mysql_query ( $stSql );
$arrResult ) { echo "Query Failed - Unable to Retrieve tags - " . mysql_error (). " – Action Aborted" ; exit(); }
mysql_num_rows ( $arrResult ) >= 1 )
$arrRow = mysql_fetch_assoc ( $arrResult ))
?>
<table align="center" width="100%" bgcolor="#FFFFFF">
<? echo stripslashes ( $arrRow [ 'tag_url' ]); ?> "><? echo stripslashes ( $arrRow [ 'tag_name' ]); ?> </a></td>
<? echo nl2br ( stripslashes ( $arrRow [ 'tag_entry' ])); ?> </td>
<? echo date ( "F j, Y, g:i a" , $arrRow [ 'tag_date' ]); ?> </span></td>
<?
}
?>
<p style="font-family: verdana,arial,helvetica,sans-serif; font-size: 11px; background-color: #FFFFFF">No entries to display</p>
<?
}
doBoard ()
?>
<html>
<?php print $param1 ; ?> ">
<?php print $param2 ; ?> ">
<?php print $selected [ $orderby ]; ?> >Name</option>
<?php echo $orderby ?> >Price (Low - High)</option>
<?php echo $orderby ?> >Price (High - Low)</option>
<?
}
doInsert ( $__name , $__entry , $__url )
$conx = mysql_connect ( HOST , USER , PASS ) or die( "Unable to connect to MySQL Server" );
mysql_select_db ( DB ) or die( "Unable to select Database" );
$__name = addslashes ( $__name );
$__url = addslashes ( $__url );
$__entry = addslashes ( $__entry );
$__name ))
?>
<p style="font-family: verdana,arial,helvetica,sans-serif; font-size: 11px; background-color: #FFFFFF">Name Field Is Required</p>
<?
} elseif (empty( $__entry ))
?>
<p style="font-family: verdana,arial,helvetica,sans-serif; font-size: 11px; background-color: #FFFFFF">Entry Field Is Required</p>
<?
} else {
$stSql = "INSERT INTO tagboard(tagId, tag_name, tag_url, tag_entry, tag_date) values('', '$__name', '$__url', '$__entry', " . time (). ")" ;
$arrResult = @ mysql_query ( $stSql );
$arrResult ) { echo "Query Failed - Unable to Retrieve tags - " . mysql_error (). " – Action Aborted" ; exit(); }
mysql_affected_rows () == 1 )
?>
<meta http-equiv="refresh" content="3;url='board.php?do=Tags'">
<?
} else {
"Unable to Add Entry to Database" ;
?>
<meta http-equiv="refresh" content="5;url='board.php?do=Tags'">
<?
}
$do = (isset( $_GET [ 'do' ]) ? $_GET [ 'do' ] : FALSE );
$do ) {
"Board" :
doBoard ();
"Tags" :
doTags ();
"Insert" :
doInsert ( $_POST [ '__name' ], $_POST [ '__entry' ], $_POST [ '__url' ]);
doBoard ();
?>
the errors i am getting are:
Notice: Use of undefined constant orderby - assumed 'orderby' in /home/content/t/m/s/tmsolutions/html/board.php on line 6
Notice: Undefined index: orderby in /home/content/t/m/s/tmsolutions/html/board.php on line 6
Notice: Undefined variable: orderby in /home/content/t/m/s/tmsolutions/html/board.php on line 7
Notice: Undefined variable: orderby in /home/content/t/m/s/tmsolutions/html/board.php on line 50
so it has soemthing to do with that. what should i change those names to, so that it'll work?
thanks
Jump To Top of Thread
Thread Tools
Rate This Thread
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts
HTML code is Off
All times are GMT +1. The time now is 06:12 PM .
Advertisement
Log in to turn off these ads.
Before you post, read our: 
