![]() |
|
|
|||||||
![]() |
|
|
Thread Tools | Rate Thread |
|
|
PM User | #1 |
|
New Coder ![]() Join Date: Mar 2008
Posts: 11
Thanks: 3
Thanked 1 Time in 1 Post
![]() |
Little review please! :)
Hi guys-
http://teamspeak.gyorn.com/ Making a site for a buddy. My first attempt at making a site using only css for the layout and only 1 or 2 tables for some small things. Not completely done yet, just want to see what the consensus is on appearance and functionality before I get everything else in there. Currently, the "Order" button only gives an alert to your order, which will be replaced soon by a redirect to Paypal. Left, right, header and footer was included using server-side html include statements. Everything else you can see from view source as I'm sure you all know. My feelings don't get hurt easily so feel free to critique this site and the code as much as you want! I'm trying to get better! ![]() Thanks a lot everyone! Edit: I realize it doesn't validate anymore. Does anyone know how to use onClick and stuff like that with XHTML? I just tried revalidating it and saw it has some name convention errors and stuff like that which I'll fix tomorrow. Time for sleep though.
![]() Last edited by Chaoticx; 03-22-2008 at 10:05 AM.. |
|
|
|
|
|
PM User | #2 | |
|
Master Coder ![]() Join Date: Mar 2007
Location: God's own country
Posts: 8,976
Thanks: 142
Thanked 1,192 Times in 1,184 Posts
![]() ![]() ![]() ![]() |
In xHtml, all attributes and tags mmust be of lower case, say div,span,table..... and id,name,class,
onclick, onblur .... The total size in KB of the home page seems to be large, you could use http://www.websiteoptimization.com/services/analyze/ to check this
__________________
Quote:
Last edited by abduraooft; 03-22-2008 at 10:24 AM.. |
|
|
|
|
| Users who have thanked abduraooft for this post: | Chaoticx (03-25-2008) |
|
|
PM User | #3 | |
|
Senior Coder ![]() ![]() Join Date: Dec 2007
Posts: 4,658
Thanks: 374
Thanked 562 Times in 551 Posts
![]() ![]() |
hi,
Quote:
Usualy the validator show more errors then really are because some of them triggers others. If you start from the ttop you avoid a lot of trouble with fixing. Probably there are also other methods/tools. Edit: for javascript, debugers, also for firefox, firebug extension and venkman. I just forgot, ![]() I realise that some people don't know about this: http://browsershots.org/http://www.nautilus.ky/main.php could help to see how your site look in different browsers. best regards Last edited by oesxyl; 03-22-2008 at 10:25 AM.. |
|
|
|
|
|
|
PM User | #4 |
|
New Coder ![]() Join Date: Mar 2008
Posts: 11
Thanks: 3
Thanked 1 Time in 1 Post
![]() |
Alright, it validates again. Lot of naming convention errors for names of divs, couldn't start with a number. Whoops!
Anyway, I really appreciate the site links and stuff guys but I was hoping for more of an opinion on the layout/functionality of the site? I knew about browsershots and have been using it during the development of this site and it's been amazing help showing me the layout on different browsers. So do you guys have any tips/critique for the layout/functionality? |
|
|
|
|
|
PM User | #5 |
|
Senior Coder ![]() ![]() Join Date: Dec 2007
Posts: 4,658
Thanks: 374
Thanked 562 Times in 551 Posts
![]() ![]() |
- maybe you can optimize the speed, look to the image size in speed report
- remove "Navigation" from menu bar, ... or write "Link" before each link, ![]() - don't forget metatags, now you don't have - I suppose it's not the case to talk about content I like the layout and the site seems functional, I don't see anything else that could be improved. Good luck with it, ![]() best regards |
|
|
|
| Users who have thanked oesxyl for this post: | Chaoticx (03-25-2008) |
|
|
PM User | #6 |
|
Comrade Grammar Nazi ![]() ![]() Join Date: Oct 2007
Location: Do you know where Nazi Zombies come from?
Posts: 2,216
Thanks: 13
Thanked 182 Times in 180 Posts
![]() |
You put it all in lowercase, e.g. onclick="event();"
__________________
Cyan Light Industries | It's Firefox, just easier on the eyes Follow me on Twitter |
|
|
|
|
|
PM User | #9 |
|
Supreme Master coder! ![]() ![]() Join Date: Dec 2004
Location: In a place far, far away...
Posts: 17,190
Thanks: 2
Thanked 732 Times in 713 Posts
![]() ![]() ![]() ![]() |
Those two buttons you have on the left side that changes the prices need to have return false; in the onclick part after your function call. Without that if you scroll down and hit a button it returns to the top of the page. I would also get rid of the word "Navigation:" and center the links.
__________________
||||If you are getting paid to do a job, don't ask for help on it!||||
|
|
|
|
| Users who have thanked _Aerospace_Eng_ for this post: | Chaoticx (03-25-2008) |
![]() |
| Bookmarks |
| Thread Tools | |
| Rate This Thread | |
|
|