Enjoy an ad free experience by logging in. Not a member yet?
Register .
PM User | 1
New Coder
Join Date: Jan 2005
Posts: 62
Thanks: 1
Thanked 0 Times in 0 Posts
php and user form
Hello, I'm having trouble with the following code. I know there's something small that's wrong with the code, but I can't find the error. When I submit the form, it doesn't seem to pass the variables to the proper function. The live version of this code can be accessed at:
http://www.rndpig.com/register.php . Note that all the variables that aren't currently being used, WILL be used eventually.
Thanks,
Ryan
PHP Code:
<?php
function Register (){
$name , $email , $address , $city , $state , $zip , $phone , $name_mt , $email_mt , $address_mt , $city_mt , $state_mt , $zip_mt , $phone_mt , $invalid ;
$a2dfam , $a2dind , $a2dstu , $a1dfam , $a1dind , $a1dstu , $na2dfam , $na2dind , $na2dstu , $na1dfam , $na1dind , $na1dstu ;
$dec2dfam , $dec2dind , $dec2dstu , $dec1dfam , $dec1dind , $dec1dstu , $banquet , $pizza , $brunch , $dues ;
RegisterForm ();
RegisterForm (){
$name , $email , $address , $city , $state , $zip , $phone , $name_mt , $email_mt , $address_mt , $city_mt , $state_mt , $zip_mt , $phone_mt , $invalid ;
$a2dfam , $a2dind , $a2dstu , $a1dfam , $a1dind , $a1dstu , $na2dfam , $na2dind , $na2dstu , $na1dfam , $na1dind , $na1dstu ;
$dec2dfam , $dec2dind , $dec2dstu , $dec1dfam , $dec1dind , $dec1dstu , $banquet , $pizza , $brunch , $dues ;
"<form method='POST' name='register' action='../register.php' enctype='multipart/form-data'>
;
CheckInfo (){
$name , $email , $address , $city , $state , $zip , $phone , $name_mt , $email_mt , $address_mt , $city_mt , $state_mt , $zip_mt , $phone_mt , $invalid ;
$a2dfam , $a2dind , $a2dstu , $a1dfam , $a1dind , $a1dstu , $na2dfam , $na2dind , $na2dstu , $na1dfam , $na1dind , $na1dstu ;
$dec2dfam , $dec2dind , $dec2dstu , $dec1dfam , $dec1dind , $dec1dstu , $banquet , $pizza , $brunch , $dues ;
$name ) || empty( $email ) || empty( $address ) || empty( $city ) || empty( $state ) || empty( $zip ) || empty( $phone )){
$name == "" ){ $name_mt = "<span style='color:#000000;'>< required field</span>" ; }
$email == "" ){ $email_mt = "<span style='color:#000000;'>< required field</span>" ; }
$address == "" ){ $address_mt = "<span style='color:#000000;'>< required field</span>" ; }
$city == "" ){ $city_mt = "<span style='color:#000000;'>< required field</span>" ; }
$state == "" ){ $state_mt = "<span style='color:#000000;'>< required field</span>" ; }
$zip == "" ){ $zip_mt = "<span style='color:#000000;'>< required field</span>" ; }
$phone == "" ){ $phone_mt = "<span style='color:#000000;'>< required field</span>" ; }
Register ();
eregi ( "^[[:alnum:]][a-z0-9_.-]*@[a-z0-9.-]+\.[a-z]{2,6}$" , stripslashes ( trim ( $email )))){
$invalid = "<span style='color:#000000;'>< invalid entry</span>" ;
Register ();
Verify ();
Verify (){
$name , $email , $address , $city , $state , $zip , $phone , $name_mt , $email_mt , $address_mt , $city_mt , $state_mt , $zip_mt , $phone_mt , $invalid ;
$a2dfam , $a2dind , $a2dstu , $a1dfam , $a1dind , $a1dstu , $na2dfam , $na2dind , $na2dstu , $na1dfam , $na1dind , $na1dstu ;
$dec2dfam , $dec2dind , $dec2dstu , $dec1dfam , $dec1dind , $dec1dstu , $banquet , $pizza , $brunch , $dues ;
"<br><br><form method='post' name='verify' action='../register.php' enctype='multipart/form-data'>
;
Submit (){
$name , $email , $address , $city , $state , $zip , $phone ;
$a2dfam , $a2dind , $a2dstu , $a1dfam , $a1dind , $a1dstu , $na2dfam , $na2dind , $na2dstu , $na1dfam , $na1dind , $na1dstu ;
$dec2dfam , $dec2dind , $dec2dstu , $dec1dfam , $dec1dind , $dec1dstu , $banquet , $pizza , $brunch , $dues ;
$to = "Ryan <test@test.com>" ;
$from = $name . "<" . $email . ">" ;
$headers = "MIME-Version: 1.0\r\n" .
"Content-type: text/plain; charset='iso-8859-1'\n" .
"From: $from\r\n" .
"Date: " . date ( "r" ). "\r\n" ;
$subject = "Registration" ;
$message = "Below is information from a recently submitted Registration.\n\n" .
"Name(s): " . $name . "\nE-mail: " . $email . "\n\n" .
"Address: \n" . $address . "\n" . $city . ", " . $state . " " . $zip . "\n\nPhone: " . $phone . "" ;
mail ( $to , $subject , $message , $headers );
"<br><br><table align='center' class='black bold'><tr><td align='center'>
;
$action ){
"Register" :
Register ();
"RegisterForm" :
RegisterForm ();
"CheckInfo" :
CheckInfo ();
"Verify" :
Verify ();
"Submit" :
Submit ();
Register ();
?>
PM User | 2
UE Antagonizer
Join Date: Dec 2005
Location: Utah, USA, Northwestern hemisphere, Earth, Solar System, Milky Way Galaxy, Alpha Quadrant
Posts: 7,687
Thanks: 42
Thanked 637 Times in 625 Posts
Does your PHP install have register_globals turned on?
PM User | 3
New Coder
Join Date: Jan 2005
Posts: 62
Thanks: 1
Thanked 0 Times in 0 Posts
Well, that was easy enough to diagnose. Register_globals always USED to be turned on, but now it is turned off. Is there an easy way that I can modify this code to get around this issue?
PM User | 4
New Coder
Join Date: Jan 2005
Posts: 62
Thanks: 1
Thanked 0 Times in 0 Posts
I apologize for bumping this post. I am still learning php and need a little assistance with this problem.
PM User | 5
Senior Coder
Join Date: Jan 2007
Posts: 1,648
Thanks: 1
Thanked 58 Times in 54 Posts
I think your primary goal right now should be to learn some proper PHP techniques.
PM User | 6
Regular Coder
Join Date: Sep 2007
Location: Grahamstown, South Africa
Posts: 237
Thanks: 6
Thanked 17 Times in 17 Posts
I hate to say it, but theres something about your code that makes it horribly inefficient. Sorry about that, but its just true. Your use of functions is inappropriate. Not a huge balls up though!
PM User | 7
Senior Coder
Join Date: Jan 2007
Posts: 1,648
Thanks: 1
Thanked 58 Times in 54 Posts
Quote:
Could anyone please tell me how I can modify the above code to get around using global variables? Do I need to pass variables directly in the function parameters?
The problem is your use of register_globals. As this is a means of coding too lazy (one should always be as lazy as possible, but not too lazy).
There already is a global variable made available to you with all the GET and POST variables, ($_GET, $_POST or $_REQUEST). So you can use those directly.
Quote:
PHP Code:
if ( $zip == "" ){ $zip_mt = "<span style='color:#000000;'>< required field</span>" ; } $phone == "" ){ $phone_mt = "<span style='color:#000000;'>< required field</span>" ; }
Lines like that are perfect candidates for arrays.
Jump To Top of Thread
Thread Tools
Rate This Thread
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts
HTML code is Off
All times are GMT +1. The time now is 02:00 PM .
Advertisement
Log in to turn off these ads.
Before you post, read our: 
