problems deleting from database

[amylou111770]

hi i am fairly new to php/mysql i have this program that does not want to delete from the database. at first it was telling me that the file had been delete and when i checked the database it was still there. no i get two different errors depending on what i do to the code.
the delete code

<?PHP
ini_set('display_errors', 1);
error_reporting(E_ALL);

include 'mysqlconnectsitel.inc.php';// this has my database connection stuff

if($_GET['m'] == 'del' )// one error i get is right here
{

$requestId = $_GET['id'];
//$last=$_GET['last'];
//$first=$_GET['first'];
$query ="DELETE FROM timeoff WHERE requestId = '$requestId' ";// if i change this to last ='$last' AND first ='$first' o get undefined variables not pulling the data

$result= mysql_query($query) or die(mysql_error());

echo" <center><font color=\"#000000\">Your Info Was Deleted!</font></center> ";
echo "<p><strong>To start at the begining page.<a href='members.php'>Click here</a></strong></p>";
echo "<p><strong>To check your dates again.<a href ='checkdates.php'>Click here</a></strong></p>";

}
else{

echo "No selection was made. please try again.";
 

echo "<p><strong>To start at the begining page.<a href='members.php'>Click here</a></strong></p>";
echo "<p><strong>To check your dates again.<a href ='checkdates.php'>Click here</a></strong></p>";
}
 ?>

this code is activated from a link on a page that has check boxes and a link for delete that uses this. please help have been trying for a few days to get this.

[Inigoesdr]

What are the errors you're getting?

[amylou111770]

the errors are the following


Notice: Undefined index: m in C:\apache2triad\htdocs\index.php on line 7 No selection was made. please try again.

i did have something selected

right now cause i just tried it, the above error is all that i am getting


i fixed the error i took that out a replaced it with something else, but now when i run it a check a ckeck box hit delete link it say no selection was made.

[Inigoesdr]

Are you POST'ing the form? <form method="post"
If so, you should be using $_POST instead of $_GET.
If not, your variable isn't being passed in the URL or isn't the correct name.

[amylou111770]

here is the code that does the sql query and shows the results with check boxes. the delete is a link

if(isset($_POST['action'])){$action=$_POST['action'];}else{$action="";}
if( $action == 'updated' )
{
  extract ($_POST);
  $todaysDate = date("Y-m-d",time());
  
        

//	Need to query database to see if this request is valid

	
	echo "<p><strong>These are the dates that you have requested off!!!!</strong></p>";
	
	
	$sql ="SELECT first, last, requestedDate FROM timeoff WHERE last = '$last' and first = '$first' ";
$query=mysql_query($sql) or die("Query failed : " . mysql_error());
while($row = mysql_fetch_assoc($query)) {
	echo "<p>";
	echo $row['first'] ." ". $row['last']. " ". "  ". $row['requestedDate'];	
	echo "<td><input type=\"checkbox\" name=\"deleted_items[]\" "; 
	echo "</p>";
}
        
 $action="";
 
 $_html ="<tr> 
    <td>$_rw->requestId</td>
    <td>$_rw->first</td>
	<td>$_rw->last</td>
	<td>$_rw->requestedDate</td>
     <td>
  		 <a href=\"index.php?id\">DELETE </a></td>

    </tr>";
	echo $_html;
	

}
else
     
{
  
  
?>

here is the link for the delete code

 td>
  		 <a href=\"index.php?id\">DELETE </a></td>

is there a tutitorial that shows how to delete this way with check boxes?

[Inigoesdr]

Well, that delete link isn't going to do anything because it's just passing "id" as the query string. If you want to use checkboxes you have to provide each with the id of the MySQL row you want to remove. ie.

PHP Code:

echo '<td><input type="checkbox" name="deleted_items[' . $row['id'] . ']" />'; // just noticed you didn't close your tag either 


And loop through them on the next page. $_POST['deleted_items'] should be an array of the checkboxes that were checked(or nothing if none were checked).

PHP Code:

if(!empty($_POST['deleted_items']))
{
    foreach($_POST['deleted_items'] as $id => $on)
    {
        $query = 'DELETE FROM `table` WHERE `id` = ' . $id;
        // mysql_query()
    }
} 


[amylou111770]

i tried that and its still telling me that no selection is made when i did.

[Inigoesdr]

Your inputs need to be wrapped in:

<form action="page.php?m=del" method="post">

<!-- checkbox inputs here -->

<input type="submit" value="Delete" />
</form>

So the while loop would look something like this:

PHP Code:

<?php
// code...
?>
<form action="page.php?m=del" method="post"> <!-- <-- change the page name.. -->
<?php

while($row = mysql_fetch_assoc($query))
{
    echo '<p>' . $row['first'] . ' ' . $row['last'] . ' ' . $row['requestedDate'];    
    echo '<td><input type="checkbox" name="deleted_items[' . $row['id'] . ']" />'; // I put "id" here, you need to change this to your id field, and make sure you select it in your query 
    echo '</p>';
}
?>

<!-- checkbox inputs here -->

<input type="submit" value="Delete" />
</form>
<?php
// code...
?>

Also, whenever you make changes, please post the code so we can see what the latest version looks like, and be able to spot errors easier.

[amylou111770]

can i use this even though the delete code is on a different page then the code for the check boxes

[Inigoesdr]

Yes, as long as the delete page is set in the <form action=""

[amylou111770]

it now tells me that it has been deleted but still not taking it out of the database i have changed what needed to be changed. any other ideas

thank you for all your help

[Inigoesdr]

Try echo'ing mysql_affected_rows() and $query:

PHP Code:

$query = ''; // your query

echo $query . '<br />';
$result = mysql_query($query) or die(mysql_error());
echo 'Records deleted: ' . mysql_affected_rows() . '<br />'; 


Post both here, and try to run the query in phpMyAdmin to see if you get any errors.

[amylou111770]

DELETE FROM `timeoff` WHERE requestId = 0
Records deleted: 0

this is what i got when i echoed the query and the mysql_affected_rows

[amylou111770]

and if i select all of them to delelte the

requestId = 0

becomes a 3 and the records deleted stays the same

[Inigoesdr]

Ok, so $requestId isn't being set on the delete page. Did you make that loop I posted earlier? Post the delete page.

Also, look at the source of the page with the checkboxes and see if there are numbers in the name="deleted_items[#]". Post that page too if there aren't any numbers. If there are numbers then all we need to fix is the loop on the delete page.