Changing CheckBox With a VAR [Should be Easy - Please Help]

[Jutboy]

I tired to slim this down as much as I could..... I'm trying to make a function that will change the checkboxs that I pass to it..

<script type="text/javascript">
function checkBoxValidate(Engine_Var){
document.new_car_script.Engine_Var.checked = true;
}


The check box is named Engine3 and the variable is getting passed properly from an alert that I had in there. If I change Engine_Var to Engine3 it works.

Please Help - Jutboy

[JayStang]

hmmm.. try something like this.

<script>
     function checkBoxValidate(Engine_Var){
          var CheckboxElement = eval("document.new_car_script." + Engine_Var);
          CheckboxElement.checked = true;
     }
</script>

[Jutboy]

Your the freaking man!!!!!

[JayStang]

haha... glad i could help and welcome to the board.

[glenngv]

eval method is not efficient and is confusing for new coders.
Try this instead:

function checkBoxValidate(Engine_Var){
  document.new_car_script.elements[Engine_Var].checked = true;
}

I've used the javascript square bracket notation. See my sig for more info on this. This technique is very useful.

[JayStang]

whats not efficient about it? not saying your wrong, just courious. I've used it plenty without a problem.

[glenngv]

This has been discussed lengthily here in CF.

http://www.codingforums.com/showthread.php?t=20143

[Jutboy]

Wow, this board is great....lots of info here

This is actually my code... I put in php so I could just loop it and save myself lots of time.....its designed for lots and lots of parts.

echo "<script type='text/javascript'>";
echo "function checkBoxValidate(part0,condition0,part1,condition1,part2,condition2,part3,condition3){";

for ($i=0;$i<=3;$i++){
echo "var CheckboxElement = eval('document.new_car_script.' + part$i + '[' + condition$i + ']');";
echo "CheckboxElement.checked = true;";

The thing is I couldn't get glenngv's method to work....seems js doesn't like you putting a variable/or combining variables/strings into a document command? i would like to be as efficent as possible however. Please advise.

Thanks - Jman

[glenngv]

echo "var CheckboxElement = document.new_car_script.elements[part$i][condition$i];";

I don't know php so I may have inserted the $i variable incorrectly.

[Jutboy]

Your the man too!!!! You basically got it....

echo "var CheckboxElement = document.new_car_script.elements[part$i"."][condition$i"."];";
echo "CheckboxElement.checked = true;";

Hehe......Please notice I gave both of you rep points!