basic javascript issue: onclick script not working

[merrymac]

hey everyone!!! im a total noob with javascript and am having trouble making this implementation work:

<button onclick='
<script type="text/javascript">
document.write("


Position: <input id="job_position_past_2" name="job_position_past_2" style="border:2px #12146B solid;" size="28" maxlength="50" type="text" />
<br/>
Company: <input id="job_company_past_2" name="job_company_past_2" style="border:2px #12146B solid;" size="28" maxlength="50" type="text" />
<br/>
")
</script>

' >Add job</button>

I'm running this in an html form on a local apache server. I'm just trying to include one of those "Add ___" buttons on forms that automatically insert another few input boxes. Javascript is enabled in the browser I'm using but I'm not sure if it is different because I'm on localhost.

WHen i click the button it says

"Object not found!

The requested URL was not found on this server. The link on the referring page seems to be wrong or outdated. Please inform the author of that page about the error.

If you think this is a server error, please contact the webmaster.
Error 404
localhost
Apache/2.4.2 (Win32) OpenSSL/1.0.1c PHP/5.4.4 "

[WolfShade]

You can't do an onclick like that. You can create a JavaScript function and use the onclick to evoke it, though.

[merrymac]

oh didn't realize only functions were allowed. THanks!!!!

[merrymac]

OK I've tried this now:

<script type="text/javascript">
function add_job(){
document.write("
Position: <input id=&quot;job_position_past_2&quot; name=&quot;job_position_past_2&quot; style=&quot;border:2px #12146B solid;&quot; size=&quot;28&quot; maxlength=&quot;50&quot; type=&quot;text&quot; />
<br/>
Company: <input id=&quot;job_company_past_2&quot; name=&quot;job_company_past_2&quot; style=&quot;border:2px #12146B solid;&quot; size=&quot;28&quot; maxlength=&quot;50&quot; type=&quot;text&quot; />
<br/>"
)
}
</script>

which i call with

<button onclick='add_job()' >Add job</button>

the quotes within quotes were messing it all up so I took the advice of another post and used the " from html. Its still giving the same error though. Whats goin on!?

[WolfShade]

Technically, you can do a little more than just functions, but the main point is that events like onclick are already JavaScript-related (ie, you don't have to start with "javascript:" in order for it to work) and a function would be much easier. Just write your function (for example, call it "doThis();") and in the button put onclick="doThis();" to evoke the function.

[WolfShade]

Originally Posted by merrymac

the quotes within quotes were messing it all up so I took the advice of another post and used the " from html. Its still giving the same error though. Whats goin on!?

document.write is not the best way. Use innerHTML. You have to escape the double quotes with a backslash "\".

" Position: <input id=\"job_position_past_2\" name=\"job_position_past_2\" style=\"border:2px #12146B solid;\" size=\"28\" maxlength=\"50\" type=\"text\" /> <br/>"