if statment problem

adi501 · 09-11-2008, 10:26 PM

Hi the if statement in my code is not getting executed. It is moving to the else statement.

Please help me

Code:

Vector vRocks = cr.getRocks();
    for (int j=0; j<10; j++)
    {
      String sShowHide = j<(vRocks.size()+1)?"block":"none";
      String sRockName = "";
      int rockId = -1;

      if ( j<vRocks.size() )
      {
        BigRock br = (BigRock)vRocks.get(j);
        sRockName = br.getName();
        rockId    = br.getID();
      }

%>
<td class=formPromptSmall > <% if ( j==0 ) { %> Big Rocks: &nbsp; <% } %> </td>
<%
    
    if (sRockName == "physical" || sRockName == "social" || sRockName == "mental" || sRockName == "spiritual")
      {
%>
   <td class=formInput17> <div id="rock2_<%=i%>_<%=j%>" style="display: <%=sShowHide%>;">
     <input type=text name="rockname_<%=i%>_<%=j%>" class=textInput size=40 value="<%=sRockName%>" onFocus="javascript:ToggleSet('rock2_<%=i%>_<%=j+1%>','block');" disabled>
     <input type=hidden name="rockid_<%=i%>_<%=j%>" class=textInput value="<%=rockId%>">
    </div>
   </td>
  <%
      }
   else
     {
 %>
  <td class=formInput17> <div id="rock2_<%=i%>_<%=j%>" style="display: <%=sShowHide%>;"> 
    <input type=text name="rockname_<%=i%>_<%=j%>" class=textInput size=40 value="<%=sRockName%>" onFocus="javascript:ToggleSet('rock2_<%=i%>_<%=j+1%>','block');">
    <input type=hidden name="rockid_<%=i%>_<%=j%>" class=textInput value="<%=rockId%>">
   </div>
  </td>
</tr>
<%
        }
    }

The values i asssigned physical, mental , spiritual, social are the values of the sRockName which i found while debugging. Please let me know if anybody know the solution.

Thanks in Advance

shyam · 09-12-2008, 11:32 AM

Quote:

Originally Posted by adi501

Code:

<%
    
    if (sRockName == "physical" || sRockName == "social" || sRockName == "mental" || sRockName == "spiritual")
      {
%>

In java you use the equals method for string comparison like so

Code:

if ( "physical".equals(sRockName) || ...) {
}