JS for loop Helppppp

iLuvNerds · 02-27-2013, 06:27 PM

I am trying to get my for loop to work to print the results and I have no clue on how...if anyone can help or at least give me a hint I would appreciate it!

<!DOCTYPE HTML>
<html>
<head>
<meta charset="UTF-8">
<title>Midterm Sum of Integers</title>
<script type="text/javascript">
//Midterm

function calcSum() {
var box1 = parseInt(document.calculator.txtBox1.value);
var box2 = parseInt(document.calculator.txtBox2.value);
var box3 = parseInt(document.calculator.txtBox3.value);
var box4 = parseInt(document.calculator.txtBox4.value);
var box5 = parseInt(document.calculator.txtBox5.value);
var sum = (box1 + box2 + box3 + box4 + box5);

var calcResult = sum;
document.calculator.Result.value = calcResult;

for(var count = 1; count < calcSum.length; ++count){document.write(count+"<br/>");}

}

</script>
</head>

<body>
<h1>PLEASE ENTER NUMBERS AND PRESS THE TAB KEY</h1>
<form name="calculator">
<input type="text" name="txtBox1" value="0" onchange="calcSum()" /><br>
<input type="text" name="txtBox2" value="0" onchange="calcSum()" /><br>
<input type="text" name="txtBox3" value="0" onchange="calcSum()" /><br>
<input type="text" name="txtBox4" value="0" onchange="calcSum()" /><br>
<input type="text" name="txtBox5" value="0" onchange="calcSum()" /><br><br>
<h1>SUM:</h1><input type="text" name="Result"/>
</form>
</body>
</html>

WolfShade · 02-27-2013, 06:31 PM

calcSum is a function and doesn't have a length.

document.write is long deprecated. Create a div, give it an ID, and set the innerHTML to the value.

felgall · 02-27-2013, 06:32 PM

the problem is the document.write statement which overwrites the entire page the first time through. Replace the long dead document.write with more modern JavaScript and your code will then work.

Philip M · 02-27-2013, 07:00 PM

Prefer to use Number() rather than parseInt() - parseInt() is intended for conversion of numbers from one base to another. If you do use parseInt() you ought to specify the radix (10).

You ask the user to enter numbers, but then change them to integers. Why can the user not enter 2.5, 3.7 and so on? And what if the user enters "XYZ" or something? You can trap NaN entries with

Code:

var box1 = Number(document.calculator.txtBox1.value) || 0;   // assign 0 if the value entered is not a number.
box1 = parseInt(box1,10);  // if you really do want integers.  10 is the radix (number base - i.e. decimal)
document.calculator.txtBox1.value = box1;  // write it back to the field

Not sure what your document.write() is intended to output, but simply scrap it.