multiple window.onload function issue

[naveendk.55]

I have Javascript functions called start() that have multiple functions to load using window.onload function. However, I have below function that works independently fine. However, if I write it inside the window.onload, then it doesn't work.

PHP Code:

//START()     
window.onload = start;

function start()
{
    loadValues();
    showState4();
} 


Code that does work independently fine.

PHP Code:

window.onload=function(){
    document.getElementById("src2TargetAll").onclick = function() {
        sureTransfer(document.getElementById("net"), document.getElementById("target"), true);
    };
}; 


I tried re-writing the code as follows in window.onload but it doesn't work. How to re-write the below code in single window.onload function.

PHP Code:


window.onload = start;

function start()
{
    loadValues();
    showState4();
    sendValuess();
}


function sendValuess(){
    document.getElementById("src2TargetAll").onclick = function() {
        sureTransfer(document.getElementById("net"), document.getElementById("target"), true);
    };
}; 


Error that I get after adding sendValues() to window.onload is as follows:

STOP RUNNING THIS SCRIPT?
A SCRIPT ON THIS PAGE IS CAUSING YOUR WEB BROWSER TO RUN SLOWLY. IF IT CONTINUES TO RUN, YOUR COMPUTER MIGHT BECOME UNRESPONSIVE.

[Logic Ali]

Originally Posted by naveendk.55

I tried re-writing the code as follows in window.onload but it doesn't work. How to re-write the below code in single window.onload function.

There's nothing wrong with the onload handler as such; the problem must be in one of the functions that you're calling but haven't shown.

[naveendk.55]

below is the code for loadValues and other functions

PHP Code:

function showState4(){
        var me = document.getElementById('stk1');
         var values = ''; //populate selected options
         for (var i=0; i<me.length; i++)
             if (me.options[i].selected)
                 values += me.options[i].value + ',';
         values = values.substring(0, values.length-1);
         var selected=[values];

         var temp= new Array();
            temp = values.split(",");

         var del = document.getElementById('StakeHolder');

         for(var i=0; i<del.length; i++)
           {
             for(var j=0;j<temp.length;j++)
              {  

                  if(temp[j] == del.options[i].value)
                    {

                       del.options[i].selected = true;
                    }
               }  
           }
         }

     function loadValues()
     {
    var  RD_REQ_RT_ID = "<%=RD_REQ_RT_ID %>";
    if(RD_REQ_RT_ID=="null")
     {
    document.getElementById('requestType').value="";
     }
     else{
    document.getElementById('requestType').value=RD_REQ_RT_ID;
    }
    )


_

     function sureTransfer(from, to, all) {
    if ( from.getElementsByTagName && to.appendChild ) {
        while ( getCount(from, !all) > 0 ) {
            transfer(from, to, all);
        }
    }
     }
     function getCount(target, isSelected) {
    var options = target.getElementsByTagName("option");
    if ( !isSelected ) {
        return options.length;
    }
    var count = 0;
    for ( i = 0; i < options.length; i++ ) {
        if ( isSelected && options[i].selected ) {
            count++;
        }
    }
    return count;
    }
    function transfer(from, to, all) {
    if ( from.getElementsByTagName && to.appendChild ) {
        var options = from.getElementsByTagName("option");
        for ( i = 0; i < options.length; i++ ) {
            if ( all ) {
                to.appendChild(options[i]);
            } else {
                if ( options[i].selected ) {
                    to.appendChild(options[i]);
                }
            }
        }
    }
     } 


[Logic Ali]

I would guess that one of your loops isn't being allowed to termninate, probably this:

  while ( getCount(from, !all) > 0 ) {
            transfer(from, to, all);
        }

if I understand, when getCount is passed !all (false) it will always return options.length, which if non-zero will give an infinite loop.


Also you have two functions sharing a global loop variable i, probably not the cause but fix it.

[naveendk.55]

loadValues() and showState4() works fine without sendValues() in window.onload function. Also, I tested sendValues() without above two functions and that also works fine. but three functions in window.onload creates a problem. So it should not be due to the while loop. However, if any code change that you suggest on while loop, then let me know. I am willing to give it a try.

[Airblader]

Sometimes debugging can be simple. Just comment the loop out and see if it works. If it does, the loop is the problem. Debugging without even so much as trying to understand the code.

[felgall]

Originally Posted by naveendk.55

loadValues() and showState4() works fine without sendValues() in window.onload function. Also, I tested sendValues() without above two functions and that also works fine. but three functions in window.onload creates a problem. So it should not be due to the while loop. However, if any code change that you suggest on while loop, then let me know. I am willing to give it a try.

That sounds like you have sendValues() using the same global variable or variables as the other functions use but for a different purpose.