returning out the parent function from a foreach function

[nikos101]

This is typescript but works similarly to JS.

How can I get the main function hasEnemyLeftBounds to return true. In the for each it currently only leaves the current for each

   hasEnemyLeftBounds(): bool {
        this.enemies.forEach(function (enemy: GameObjects.GameObjects.Enemy) {
            if ((enemy.x <= 0 || enemy.x >= Game.CANVAS_WIDTH)) {
                return true;
            }
        });
        return false;
    }

[AndrewGSW]

Presumably it should return true if any one of the enemies has left? In JS:

hasEnemyLeftBounds(): bool {
        var hasLeft = false; // TypeScript: bool hasLeft = false; ??
        this.enemies.forEach(function (enemy: GameObjects.GameObjects.Enemy) {
            if ((enemy.x <= 0 || enemy.x >= Game.CANVAS_WIDTH)) {
                hasLeft = true;
                // has TypeScript a 'break' statement to break out of the forEach?
            }
        });
        return hasLeft;
    }

Currently, it will continue searching even if the current enemy has left. You might investigate to see if 'break', or similar, will break out of the forEach loop; there's no point checking the rest. Added: Yeah, a 2 second search tells me that you can just add break; to break out of the loop. Added Again: Actually, I don't think you can(?).

[AndrewGSW]

var wibble: bool; // TypeScript
wibble = false;

Seems a bit unnecessary to me

[nikos101]

seems I should just use a for (int i" instead for simplicity

[AndrewGSW]

Originally Posted by nikos101

seems I should just use a for (int i" instead for simplicity

Unless you are unfortunate enough to have hundreds of enemies then it is not a big deal. But, yes, the forEach is designed to look at each/EVERY item, so it does not have an inbuilt method (or simple way) to break out of the sequence.

[AndrewGSW]

This TypeScript/JS/Array business is confusing me a little, but if this.enemies is an array then you might be able to do

for (index in this.enemies) {
    if (this.enemies[index].x < 0 || etc..) {
        hasLeft = true;
        break;
    }
}
return hasLeft;

[rnd me]

function hasEnemyLeftBounds(enemies) {
       return enemies.every( function(enemy) {
                return enemy.x <= 0 || enemy.x >= Game.CANVAS_WIDTH ;
        } );
}

where enemies is an array and you want to know if all enemies satisfy the condition.
every() terminates upon the first falsy return value, so you don't need a collector or status var like you would if you tried to use .forEach(), and you can bail-out early, which is much faster in practice.

if you want all enemies that satisfy the condition, replace the word "every" with "filter".

if you want to end iteration when the first condition is trueish (as opposed to falsy), use .some() instead of .every().