JavaScript Validation Error.

Coding123 · 12-17-2012, 10:13 AM

I have a code with me, and everything works fine (JavaScript) excluding the validation; I think I may have made an error somewhere which could possibly relate to the curly braces I've used. I was wondering if anybody could correct this code. I'm using Notepad++, if that helps.

Code:

<head>
<title>Exam entry</title>

<script language="javascript" type="text/javascript">

function validateForm() {
var result = true;
var msg="";
}

if (document.ExamEntry.name.value=="") {
msg+="You must enter your name \n";
document.ExamEntry.name.focus();
document.getElementById('name').style.color="red";
result = false;
}

if (document.ExamEntry.subject.value=="") {
msg+="You must enter the subject \n";
document.ExamEntry.subject.focus();
document.getElementById('subject').style.color="red";
result = false;
}

if (document.ExamEntry.examination number.value="") {
msg+="You must enter the examination number \n";
document.ExamEntry.examinationnumber.focus();
document.getElementById('examinationnumber').style.color="red";
result = false;
}

if (msg=="") {
return result;
}

{
window.alert(msg)
return result;
}
</script>
</head>
<body>
<p>
<font face="Candara">
<font size="2">
<h1><u>Exam Entry Form</u></h1>
<fieldset>
<form name="ExamEntry" method="post" action="success.html">
<table width="50%" border="0">
<tr>
<td id="name">Name</td>
<td><input type="text" name="name" /></td>
</tr>
<tr>
<td id="subject">Subject</td>
<td><input type="text" name="subject" /></td>
</tr>
<tr>
<tr>
<td id="examination number">Examination Number</td>
<td><input type="text" name="examinationnumber" /></td>
</tr>
<tr>
</tr>
<td><input type="submit" name="Submit" value="Submit" onclick="return validateForm();" /></td>
<td><input type="reset" name="Reset" value="Reset" /></td>
</tr>
</fieldset>
</table>
</form>
</p></font></size></body>

Thanks in advance.

Philip M · 12-17-2012, 11:06 AM

Have you tried using your error console?

function validateForm() {
var result = true;
var msg="";
} // end of function

And other errors, including obsolete HTML <font> tags and no !DOCTYPE.

Form validation of the pattern if (document.formname.formfield.value == "") - that is blank - is barely worthy of the name, and virtually useless, as even a single space, an X or a ? will return false, that is pass the validation. A proper name may only contain letters, hyphen, space and apostrophe.
Numeric values, such as zip codes and phone numbers, should be validated as such. Ditto email addresses. This topic has been covered many times before in this forum.

It is your responsibility to die() if necessary….. - PHP Manual

vikram1vicky · 12-22-2012, 08:10 AM

Post ur full code or link where it is hosted.

Philip M · 12-22-2012, 09:54 AM

Quote:

Originally Posted by vikram1vicky

Post ur full code or link where it is hosted.

He has posted his full code.What do you think is missing (apart from <html> and </html>)?

felgall · 12-22-2012, 08:17 PM

The code looks fine except for the </size> tag. Netscape 2 doesn't understand doctype tags so with the rest of the code written for that browser it is essential then a doctype not be specified.

If targetting more recent browsers such as IE5 the first thing you should do is to rewrite the HTML to a more recent version as the version being used became obsolete in 1997.

If you want it to work properly in modern browsers you should also move the script to just before the </body> tag and get rid of the alert() call as they can no longer be used in live web pages. You should also learn how to use the debugger built into the browser to work out what your JavaScript errors are - as well as feeding your JavaScript through a service such as http://www.jslint.com/ (created by JavaScript expert Douglas Crockford).