javascript basic card match game

[Old Pedant]

Originally Posted by javasnip

My knowledge is limited.. and that is how it was being explained and I personally thought it was me lacking and being confused.. but it seems his way is very awkward.. He was saying that if you named the images that way like 1-J etc. it would show the images instead of the text. But obviously not. does this bit a code from above make sense

cardname1=rands1+"-"+randn1+".jpg";

Yes, but *ONLY* if you then did something like

   document.getElementById("card1").src = cardname1;

where you ALREADY have, on your page, something like

    <img id="card1"/>

You *could*, instead, do something like

    <div id="card1"></div>
    ...
   document.getElementById("card1").innerHTML = '<img src="' + cardname1 + '" alt="random card" />';

but that's not recommended coding.

[Old Pedant]

By the by...there is a fatal flaw in my code...*AND* in your original code!

There is *NOTHING* to prevent the SAME CARD from being picked for both cards!!!

That's because you pick the two cards completely independently of each other.

The *right* way to do this is to shuffle the deck and then just deal the top two cards off the top of the deck.

But if you only ever need two cards, it's sufficient to just check the 2nd against the 1st and loop until the 2nd doesn't match the 1st.

[Philip M]

You don't need images - you could use the HTML codes.
&hearts &clubs &diams &spades


Shuffle is probably a bit advanced for you at this stage, but

<script type = "text/javascript">
var imgArray = new Array('Ace',2,3,4,5,6,7,8,9,10,'Jack','Queen','King'); 

Array.prototype.shuffle = function() {
var s = [];
while (this.length) s.push(this.splice(Math.random() * this.length, 1));
while (s.length) this.push(s.pop());
return this;
}

imgArray.shuffle();
var card1 = imgArray[0];
alert (card1);
imgArray.shuffle();
var card2 = imgArray[0];
alert (card2);

if (card1 == card2) {
alert ("The cards match!");
}
</script>