PHP mysql error

[amcf1992]

I am having the following error:

PHP Parse error: syntax error, unexpected T_ENCAPSED_AND_WHITESPACE, expecting T_STRING or T_VARIABLE or T_NUM_STRING in /public_html/path1/path2/ on line 10

Introduction: I am building a PHP text messaging service. Db connect to mysql, script selects the user information from the database and uses it to send the sms to that person.

PHP Code:

<?php
$con = mysql_connect("localhost","friendko_admin","Macbookpro17#");
 if (!$con)
   {
   die('Could not connect: ' . mysql_error());
   }
 
mysql_select_db("friendko_text", $con);
$query = "SELECT id, email, key FROM friendko_text WHERE key = $_POST['key']";
$result = mysql_query($query);
while($row = mysql_fetch_array($result))
{
  echo '11 Digit Key: ' . $row['key'] . '<br>';
  echo 'Email: ' . $row['email'] . '<br>';
  echo '<br>';
}
 
 
 
$to = $_POST['to'];
$carrier = $_POST['carrier'];
$message = stripslashes($_POST['message']);
if ((empty($from)) || (empty($to)) || (empty($message))) {
header ("Location: sms_error.php");
}
else if ($carrier == "verizon") {
$formatted_number = $to."@vtext.com";
mail("$formatted_number", "SMS", "$message"); 
header ("Location: sms_success.php");
}
else if ($carrier == "tmobile") {
$formatted_number = $to."@tomomail.net";
mail("$formatted_number", "SMS", "$message");
header ("Location: sms_success.php");
}
else if ($carrier == "sprint") {
$formatted_number = $to."@messaging.sprintpcs.com";
mail("$formatted_number", "SMS", "$message");
header ("Location: sms_success.php");
}
else if ($carrier == "att") {
$formatted_number = $to."@txt.att.net";
mail("$formatted_number", "SMS", "$message");
header ("Location: sms_success.php");
}
else if ($carrier == "virgin") {
$formatted_number = $to."@vmobl.com";
mail("$formatted_number", "SMS", "$message");
header ("Location: sms_success.php");
}
?>

[Fou-Lu]

You cannot do this:

PHP Code:

$query = "SELECT id, email, key FROM friendko_text WHERE key = $_POST['key']"; 


Either break from the string and apply the variable through standard evaluation, or wrap the complex type with {} to evaluate them within a string.

It appears that you have whitespace preceding your code as well. You may want to remove that if you decide to use sessions, cookies, or redirection headers (which you have used), as they will only work if output buffering is enabled at a system level. I can't be 100% sure its there, but my count puts your error on line 9, not 10.

[tangoforce]

The simple version of what Fou is saying is that this:
"SELECT id, email, key FROM friendko_text WHERE key = $_POST['key']";

Should be this:

"SELECT id, email, key FROM friendko_text WHERE key = '$_POST[key]'";

[Fou-Lu]

That should work, and even without error if I'm not mistaken.
But I don't like that. The 'key' in my eyes is now a constant which should be a string.
What I mean is to do as:

PHP Code:

$query = "SELECT id, email, key FROM friendko_text WHERE key = {$_POST['key']}";
// or
$query = "SELECT id, email, key FROM friendko_text WHERE key = " . $_POST['key']; 


[nomanic]

hi tangoforce

this is purely a question

would '$_POST['key']' work in this instance?

shouldn't it either be '".$_POST['key']."'

or {$_POST['key']}

???

only asking

[Fou-Lu]

Originally Posted by nomanic

hi tangoforce

this is purely a question

would '$_POST['key']' work in this instance?

shouldn't it either be '".$_POST['key']."'

or {$_POST['key']}

???

only asking

It will, the issue that PHP is having is the use of [''] inside of the string where it is aware that you have a complex datatype but isn't sure how to deal with it now (since strings are scalar). Best I know it actually does so without error since the inner associate index is already a part of a string, so it should work without triggering an undefined constant error.

Still, I don't like it, and never have. I prefer the complex evaluation or the print formatters.

Edit:
Sorry it won't, missed your example quotations. The inner ones are the problem, they can be removed without error.

[tangoforce]

Originally Posted by nomanic

hi tangoforce

this is purely a question

would '$_POST['key']' work in this instance?

Hi

No.

Originally Posted by nomanic

shouldn't it either be '".$_POST['key']."'

Possibly though after the final "' you'd need another " to terminate the string.

Originally Posted by nomanic

or {$_POST['key']}

It its still inside a double quoted string, again yes, possibly.

I only say possibly because its one of 3 different methods that would work. I used the simplest / easiest to understand method earlier. Fou isn't keen on the in-string (as I call it) method whereas I find it rather useful and it saves a few seconds to type.

[nomanic]

I didnt see
you took the quotes out of your suggestion
thats why I was confused
I didint think it would work with them in, but you took them out!
sorry!

[tangoforce]

Ok ..

[amcf1992]

Thanks for everyones responses, I did make the change as mentioned but its still redirection me to sms_error.php

Here my code so far

PHP Code:

<?php
$con = mysql_connect("localhost","friendko_admin","Macbookpro17#");
 if (!$con)
   {
   die('Could not connect: ' . mysql_error());
   }
 
mysql_select_db("friendko_text", $con);

$query = "SELECT id, email, key FROM friendko_text WHERE key = {$_POST['key']}";
$result = mysql_query($query);
while($row = mysql_fetch_array($result))
{
  echo '11 Digit Key: ' . $row['key'] . '<br>';
  echo 'Email: ' . $row['email'] . '<br>';
  echo '<br>';
}







$to = $_POST['to'];
$carrier = $_POST['carrier'];
$message = stripslashes($_POST['message']);

if ((empty($from)) || (empty($to)) || (empty($message))) {
header ("Location: sms_error.php");
}

else if ($carrier == "verizon") {
$formatted_number = $to."@vtext.com";
mail("$formatted_number", "SMS", "$message"); 
// Currently, the subject is set to "SMS". Feel free to change this.

header ("Location: sms_success.php");
}

else if ($carrier == "tmobile") {
$formatted_number = $to."@tomomail.net";
mail("$formatted_number", "SMS", "$message");

header ("Location: sms_success.php");
}

else if ($carrier == "sprint") {
$formatted_number = $to."@messaging.sprintpcs.com";
mail("$formatted_number", "SMS", "$message");

header ("Location: sms_success.php");
}

else if ($carrier == "att") {
$formatted_number = $to."@txt.att.net";
mail("$formatted_number", "SMS", "$message");
header ("Location: sms_success.php");
}

else if ($carrier == "virgin") {
$formatted_number = $to."@vmobl.com";
mail("$formatted_number", "SMS", "$message");

header ("Location: sms_success.php");
}
?>

[AndrewGSW]

If key is a string then enclose the value in apostrophes:

PHP Code:

$query = "SELECT id, email, key FROM friendko_text WHERE key = '{$_POST['key']}'";
$result = mysql_query($query);
while($row = mysql_fetch_array($result, MYSQL_ASSOC)) 


If you are only using $row as an associative array that it is better to explicitly return such an array by specifying MYSQL_ASSOC (or use mysql_fetch_assoc()).

But I'm not sure about the re-direction. Use echo $to; etc. to check these values.

[_Aerospace_Eng_]

Where is $from defined? I don't see that anywhere in your code which will always cause you go to to the sms_error page.

[amcf1992]

Originally Posted by _Aerospace_Eng_

Where is $from defined? I don't see that anywhere in your code which will always cause you go to to the sms_error page.

Here is my updated code:

HTML FORM

PHP Code:

<html>
<head>
</head>
<body>
<form id="sms" name="sms" method="post" action="send.php">
<table width="400">
  <tr>
    <td align="right" valign="top">11 Digit ID:</td>
    <td align="left"><input name="to" type="text" id="to" size="11" /></td>
  </tr>
 
    <td align="right" valign="top">Message:</td>
    <td align="left"><textarea name="message" cols="40" rows="5" id="message"></textarea></td>
  </tr>
  <tr>
    <td colspan="2" align="right"><input type="submit" name="Submit" value="Submit" /></td>
    </tr>
</table>
</form>
</body>
</html> 


Here's the php

PHP Code:

<?php
$con = mysql_connect("localhost","friendko_admin","Macbookpro17#");
 if (!$con)
   {
   die('Could not connect: ' . mysql_error());
   }
 
mysql_select_db("friendko_text", $con);



$query = "SELECT id, email, key FROM friendko_text WHERE key = '{$_POST['key']}'";
$result = mysql_query($query);
while($row = mysql_fetch_array($result, MYSQL_ASSOC))  
{
  echo '11 Digit Key: ' . $row['key'] . '<br>';
  echo 'Email: ' . $row['email'] . '<br>';
  echo 'Carrier: ' . $row['carrier'] . '<br>';
}

?>

Once I can successfully echo the variables i can proceed to the rest of the code.

[_Aerospace_Eng_]

$_POST['key'] will always be empty. You have no form input with name="key". You probably got some kind of key from the place letting you use their SMS service that you need to provide to their api.

[amcf1992]

Its not an api key, its a mysql value