Syntax error problem

[MasterRenny]

Not sure if this is the right place but im having problems getting this to work

PHP Code:

        // superFish
        $('ul.sf-menu').superfish(); 
            autoArrows: true,
            animation:   {opacity:'show',height:'show'},
                //remove current menu class from drop-downs
        $("ul.sf-menu ul li").removeClass("current-menu-item");

        });
    }); 


on the animation line there is the error, if i remove the removeClass line it works fine and adds the little arrow to drop down menu, but if i add the removeClass line the script dont work and it stops all my other scripts from working.

Here it is in full

PHP Code:

<script type="text/javascript">  
jQuery(function($){
      $(document).ready(function() {
                  
          // Horizontal Sliding Tabs
          $('div#st_horizontal').slideTabs({              
            // Options              
            contentAnim: 'fade',
            autoHeight: true,
            contentAnimTime: 600,
            contentEasing: 'easeInOutExpo',
            tabsAnimTime: 300            
          });                            
      
      });        
    
        // superFish
        $('ul.sf-menu').superfish(); 
            autoArrows: true,
            animation:   {opacity:'show',height:'show'},
                //remove current menu class from drop-downs
        $("ul.sf-menu ul li").removeClass("current-menu-item");

        });
    });

   // ToolTip Facebook style
    
  $(function() {
    
      $('#fb').tipsy({gravity: 's'});
    $('#twitter').tipsy({gravity: 's'});
    $('#pin').tipsy({gravity: 's'});
    $('#yt').tipsy({gravity: 's'});
    $('#email').tipsy({gravity: 's'});
    $('#rss').tipsy({gravity: 's'});
  });
</script> 


Though im not a wiz at javascript and know very little on structure and how syntaxs..etc work

Kind regards,
Renny

[alykins]

wrong place buddy- you want javascript section of forum A mod will move this thread- please don't cross post

[Inigoesdr]

Moved

[MasterRenny]

Originally Posted by Inigoesdr

Moved

Thank you

[devnull69]

Syntax is the most essential part of a programming language so you should start to learn about it.

Generally you should check that every opening bracket/parenthesis has a corresponding closing one and vice versa.

You want to call superfish() with parameters, but before you give any parameter, you already close the "parameter parentheses". It should be more like

        $('ul.sf-menu').superfish({ 
            autoArrows: true,
            animation:   {opacity:'show',height:'show'}
        });

but I dunno if this will work, though. Because on top of the Syntax, also the documentation of your frameworks and plug-ins is important. And I don't know anything about the superfish documentation ....

[WolfShade]

I could be wrong, but I think the comma at the end of the last parameter might be causing your issue, as well.

^_^

[MasterRenny]

The script works fine until i added $("ul.sf-menu ul li").removeClass("current-menu-item"); which i need in to be able to stop it from showing the blue hover when you go though the menu


www.masterrenny.com is where im using it

as you can see its removing the class, but it isnt allowing//showing the superfish arrow

[devnull69]

Unfortunately, this is wrong. Although it should be common sense to not use a comma after the final entry of an object literal, every current Javascript engine will just ignore it :-)

[MasterRenny]

But even without it i cant get it to work

[devnull69]

Originally Posted by MasterRenny

The script works fine until i added $("ul.sf-menu ul li").removeClass("current-menu-item");

Sorry, but this is not possible, because even without this line the code is just wrong

jQuery(function($){
      $(document).ready(function() {
                  
          // Horizontal Sliding Tabs
          $('div#st_horizontal').slideTabs({              
            // Options              
            contentAnim: 'fade',
            autoHeight: true,
            contentAnimTime: 600,
            contentEasing: 'easeInOutExpo',
            tabsAnimTime: 300            
          });                            
      
      });        
    
        // superFish
        $('ul.sf-menu').superfish(); 
            autoArrows: true,
            animation:   {opacity:'show',height:'show'},
                //remove current menu class from drop-downs

        });
    });

   // ToolTip Facebook style
    
  $(function() {
    
      $('#fb').tipsy({gravity: 's'});
    $('#twitter').tipsy({gravity: 's'});
    $('#pin').tipsy({gravity: 's'});
    $('#yt').tipsy({gravity: 's'});
    $('#email').tipsy({gravity: 's'});
    $('#rss').tipsy({gravity: 's'});
  });

There are 23 opening and 24 closing parentheses
There are 11 opening and 12 closing curly brackets

This would never ever work!

[MasterRenny]

Urgh not one of you are helping your all just saying the same thing...:/

[devnull69]

This should make you start thinking ... you know like a motorist driving against the traffic and every other driver is flashing the lights at him ... you are doing some very essential things very wrong and you need to do a U turn

[MasterRenny]

No because your all missing the point, this;

PHP Code:

        // superFish
        $('ul.sf-menu').superfish(); 
            autoArrows: true,
            animation:   {opacity:'show',height:'show'}
                //remove current menu class from drop-downs
        $("ul.sf-menu ul li").removeClass("current-menu-item");

        });
    }); 


Is what im having problems with getting working, the rest of the code isnt the problem and actually works fine if i remove this part of the code from the file

[devnull69]

What does the superfish documentation tell you? Can you at least point us to the site where you got it from?

[felgall]

Originally Posted by MasterRenny

No because your all missing the point, this;

PHP Code:

        // superFish
        $('ul.sf-menu').superfish(); 
            autoArrows: true,
            animation:   {opacity:'show',height:'show'}
                //remove current menu class from drop-downs
        $("ul.sf-menu ul li").removeClass("current-menu-item");

        });
    }); 


Is what im having problems with getting working, the rest of the code isnt the problem and actually works fine if i remove this part of the code from the file

That code is completely invalid syntax - the only reason the autoArrows and animation lines don't throw an error before you added the extra line is because JavaScript is able to interpret them in a completely different way to how you expect.

autoArrows: true, <== a label of "autoArrows" followed by a statement that is true - the true result is discarded because it isn't assigned to anything

animation: {opacity:'show',height:'show'} <== a label of "animation" followed by the creation of an anonymous object with opacity and height properties. The anonymous object is also immediately discarded because it isn't assigned to anything.

Commenting out those two lines will not affect the original code.

What you need to do BEFORE adding the statement that created the error is to work out where those two lines have to be moved to in order for them to actually do anything at all.

The following statement is what produces the syntax error when you add the extra code into the end of the statement.

{opacity:'show',height:'show'} $("ul.sf-menu ul li").removeClass("current-menu-item");

Possibly what you intended is as follows (which would pass an object with autoArrows and animation properties into superfish:

PHP Code:

$('ul.sf-menu').superfish({autoArrows: true, animation: {opacity:'show',height:'show'}}); 
//remove current menu class from drop-downs 
$("ul.sf-menu ul li").removeClass("current-menu-item");