Disabling a text field depending on 2 options

jcdevelopment · 08-30-2011, 08:37 PM

Not 100% sure why or how to make this work.

I have 5 options in a select drop-down. Only two of them are to disable a text field. I have written it successfully to disable on one option. How would I add the second option? I have tried many different ways, and i know its something small that i am missing.

Below is the code that does not work but shows the 2 options that disable my text field.

Code:

<script type="text/javascript">
    function type_disable() {
		var qr_type = document.getElementById('qr_type');
    var qr_owner = document.getElementById('qr_owner');
    if(qr_type.value == 'bio' || 'rebrand')
        qr_owner.disabled = true
    else
        qr_owner.disabled = false
}
	
</script>

Code:

<tr>
	
	<td align="right"><span class="re">*</span>Type: </td>
	<td align="left"> &nbsp;<select id="qr_type"  name="qr_type" onChange="type_disable()">
	
	<option value="0">Select Type</option>
		 <option value="property">Property Code</option> 
		 <option value="ipw">IPW Code</option> 
		 <option value="bio">Biography Code</option> 
		 <option value="rebrand">Rebrand Code</option> 
		 <option value="property_rebrand">Property-rebrand Code</option> 
		 </select>
	 
	 </td>
	<td ></td>
	</tr>

	
	<tr>
	
	<td align="right"><span class="re">*</span>Owner: </td>
	<td align="left"> &nbsp;<input type="textbox" name="qr_owner" id="qr_owner" size="30" value=""/></td>
	<td ></td>
	</tr>

Thanks for any help!

Tails · 08-30-2011, 08:49 PM

The || separates statements, not values. Do this instead:

Code:

 if(qr_type.value == 'bio' || qr_type.value == 'rebrand')

It may be easier to assign numeric values to the options so that you check if the value is greater than 0.

jcdevelopment · 08-30-2011, 09:08 PM

If only i got paid for my "brain farts"! thanks.

Philip M · 08-31-2011, 08:21 AM

var qr_type = document.getElementById('qr_type');

Just a comment, be aware that in Internet Explorer, names and IDs are global variables and thus you should NEVER use a global variable or function name which is the same as an HTML element name or ID.

Here your variables are local, not global scope, but even so it is perhaps unwise or confusing to assign the same name.