CodingForums.com - View Single Post

WA · 05-16-2005, 02:37 AM

I've just tested this script some more. Some feedback:

1) Does the links[] array work at the moment? I tried inputting URLs, but the images remain unlinked.

2) In IE, users who have JS debugging turned on and misconfigure the script will be bombarded with errors. I'd recommend perhaps adding a line like:

window.onerror=function(){if (document.all){window.status='An error has occured'; return true}}

to the top of the script.

3) It's difficult to get the slideshow to show the images in their original, undistorted dimension without a lot of trial and error with the width/height parameters. I think a good idea may be to just ask for the true dimension of the images (making the assumption each one is the same size), and then based on sides and direction, display an image slideshow with the ideal dimensions.

I'm writing up the page for this script on DD, though may wait for the next revision when some of the above are solved before actually publishing it.

Thanks!

05-16-2005, 02:37 AM	PM User \| #12
WA Administrator Join Date: Mar 2002 Posts: 2,596 Thanks: 2 Thanked 19 Times in 18 Posts	I've just tested this script some more. Some feedback: 1) Does the links[] array work at the moment? I tried inputting URLs, but the images remain unlinked. 2) In IE, users who have JS debugging turned on and misconfigure the script will be bombarded with errors. I'd recommend perhaps adding a line like: window.onerror=function(){if (document.all){window.status='An error has occured'; return true}} to the top of the script. 3) It's difficult to get the slideshow to show the images in their original, undistorted dimension without a lot of trial and error with the width/height parameters. I think a good idea may be to just ask for the true dimension of the images (making the assumption each one is the same size), and then based on sides and direction, display an image slideshow with the ideal dimensions. I'm writing up the page for this script on DD, though may wait for the next revision when some of the above are solved before actually publishing it. Thanks! __________________ - George - JavaScript Kit- JavaScript tutorials and 400+ scripts! - JavaScript Reference- JavaScript reference you can relate to.