CodingForums.com - View Single Post - Resolved appending to string variable while looping through records

Old Pedant · 01-30-2013, 09:27 PM

I have to ask: Why are you opening the recordset with a static cursor??? You then only move forward through the recordset so you are wasting the performance expense of the cursor.

And why do you use

Code:

else
if objRs.BOF then

instead of

Code:

Elseif objRs.BOF then

(Not a big deal, but expresses what you are doing better.)

And by the by: You write out mnheader and overlayPH and more even when you have an error or you find no records (so there isn't really any slideshow). Is that intentional?

01-30-2013, 09:27 PM	PM User \| #4
Old Pedant Supreme Master coder! Join Date: Feb 2009 Posts: 23,172 Thanks: 59 Thanked 3,995 Times in 3,964 Posts	I have to ask: Why are you opening the recordset with a static cursor??? You then only move forward through the recordset so you are wasting the performance expense of the cursor. And why do you use Code: else if objRs.BOF then instead of Code: Elseif objRs.BOF then (Not a big deal, but expresses what you are doing better.) And by the by: You write out mnheader and overlayPH and more even when you have an error or you find no records (so there isn't really any slideshow). Is that intentional? __________________ An optimist sees the glass as half full. A pessimist sees the glass as half empty. A realist drinks it no matter how much there is.