CodingForums.com

CodingForums.com (http://www.codingforums.com/index.php)
-   PHP (http://www.codingforums.com/forumdisplay.php?f=6)
-   -   TIP: Quotes / Parse error: syntax error, unexpected T_CONSTANT_ENCAPSED_STRING in.. (http://www.codingforums.com/showthread.php?t=229961)

tangoforce 06-21-2011 01:56 AM

TIP: Quotes / Parse error: syntax error, unexpected T_CONSTANT_ENCAPSED_STRING in..
 
Many new PHP coders will come across this error and will be a bit confused by what it means so I thought I would supply a quick topic to cover the issue in more detail.

Lets suppose we have the following code:
PHP Code:

$sql "INSERT INTO wall (author, message) VALUES ("' .$author. '", "'. $message. '")"

That is one line of PHP containing an SQL statement. To the experienced eye its defective but to a lot of new PHP programmers this looks fine.

First there seems to be some confusion about the quotation marks so I will go into those here.

Single ' quotes are handled by PHP literally. That means what you see inside the ' marks is exactly what you get. Example:
PHP Code:

$Author 'Joe Bloggs';

print 
'Comment written by $Author'

The above will print like this:
Quote:

Comment written by $Author
This is because the single quotes tell PHP that it should be handled exactly as it is without changing anything.

Double " quotes are where our magic happens. Double quotes tell PHP to examine the string inside it and if there are any variables found, replace them with their values. There is however a trade-off: PHP checks double quoted strings for variables it needs to replace - this uses more CPU cycles. Example:
PHP Code:

//Not good (but it does work):
$Author "Joe Bloggs";

//Better - Uses less CPU (PHP doesn't need to check the string)
$Author 'Joe Bloggs';

print 
"Comment written by $Author"

The above will print like this:
Quote:

Comment written by Joe Bloggs
Simple right? I'm glad you agree but read on because many people still get confused especially when trying to use them within the string.

When you need to use the single ' or double " inside a single quoted string you need to tell PHP to ignore it. The way this is done is to escape the quote within the string. To escape a character we use the \ slash. Example:
PHP Code:

//Single quote example
print 'This comment is from Joe Bloggs\'s blog.';
//Note the use of \'

//Double quote example
$Author 'Joe Bloggs';
print 
"$Author said \"This is my comment.\""

The two examples above will output the following:
Quote:

This comment is from Joe Bloggs's blog.
Joe Bloggs said "This is my comment."
Ok, so you've see how to escape quotes to use them within their own type of quotes but what happens if we want to use the the opposite quote in our string? Well with single quotes anything you use there is handled literally so using a double quote inside a single quoted string will produce exactly that - a double quote. Inside a double quoted string a single quote can also be used with no escaping required.

Now what about using the \ within a string?
In single quoted strings you don't need to worry. Sometimes in double quoted strings you may need to escape it.
PHP Code:

//This will work
$Comment "I installed PHP on my c:\ drive.<br>";
print 
$Comment;

//This will also work:
$Comment "I installed PHP on my c:\\ drive.<br>";
print 
$Comment

The output from both of the above is the same in this scenario:
Quote:

I installed PHP on my c:\ drive.
I installed PHP on my c:\ drive.
It is only in some special situations you may need to escape the backslash but I've mentioned it just in case you need it.

So, lets return to the SQL above:
PHP Code:

$sql "INSERT INTO wall (author, message) VALUES ("' .$author. '", "'. $message. '")"

This will raise a parse error looking like:
Quote:

Parse error: syntax error, unexpected T_CONSTANT_ENCAPSED_STRING in.. <file name> <line number>
So, whats wrong with that then?
If you look at the SQL after the word VALUES it becomes clear that there is some complex quoting going on:
Code:

//We're already inside double quotes at the beginning and end of the SQL.
"' .$author. '", "'. $message. '"

As you can see, PHP see's double quotes there and does not know if you're terminating the string or trying to add something. Then we have a single quote, plus the addition of a variable before trying to add on another string containing another double quote.. before trying it all again!

So, what do we do with this? Well there are 3 ways really:
PHP Code:

//Put the single quotes inside the doubles
$sql "INSERT INTO wall (author, message) VALUES ('" .$author"', '"$message"')";

//But remember inside double quotes $Variables work.. So..
//Remove the excess double quotes and make it tidy:
$sql "INSERT INTO wall (author, message) VALUES ('$author', '$message')";

//Or..:
$sql 'INSERT INTO wall (author, message) VALUES (\'' .$author'\', \''$message'\')'

Now I'll quickly mention arrays here as there also seems to be a little confusion with those. There is no need to ever use double quotes UNLESS your Key is text with a variable (EG: "Key$I" - Where $I is a number):
PHP Code:

//Not needed - It will work but it will waste CPU cycles checking the Key for a variable:
$Array["Comment"] = 'This is a test.';

//Better way using less CPU cycles:
$Array['Comment'] = 'This is a test';

//With variables:
$Key 'Comment';

//Not great but it works:
$Array["$Key"] = 'This is a test.';

//Better:
$Array[$Key] = 'This is a test.'

All of the above will work but you don't always need the double quotes.

There may also be times when you wish to use functions or PHP commands in conjunction with your quoted text. The general thing you must realise is that a string (thats quoted text) is just a string of text. It is seen by PHP as just that - text. PHP will check double quoted strings for variables and replace them but it will not run PHP commands or functions inside a string. You should realise that single quoted strings will not to anything magical so the following example uses double quoted strings. Example:
PHP Code:

//This will not work:
$Comment "Joe blogg's latest blog is: print get_comment()";

//This will work:
$Comment "Joe blogg's latest blog is: " get_comment();

//This will work:
$Comment "Joe blogg's latest blog is: ";
print 
get_comment(); 


abduraooft 06-21-2011 09:14 AM

Quote:

//But remember inside double quotes $Variables work.. So..
//Remove the excess double quotes and make it tidy:
$sql = "INSERT INTO wall (author, message) VALUES ('$author', '$message')";
When using an associative array variable inside the string, wrap it by curly braces, like

PHP Code:

$sql "INSERT INTO wall (author, message) VALUES ('{$Data['author']}', '{$Data['message']}')"


bullant 06-21-2011 10:09 AM

Quote:

Originally Posted by tangoforce (Post 1103738)
Many new PHP coders will come across this error and will be a bit confused by what it means so I thought I would supply a quick topic to cover the issue in more detail.

Lets suppose we have the following code:
PHP Code:

$sql "INSERT INTO wall (author, message) VALUES ("' .$author. '", "'. $message. '")"

That is one line of PHP containing an SQL statement. To the experienced eye its defective but to a lot of new PHP programmers this looks fine.

More often than not, when a query is not returning the results you expect, there is a syntax error in the query itself.

I find the easiest and quickest way to check what the actual query about to be run is, is to echo it to the browser and syntax errors should then be fairly obvious.

For more complex queries a good practice imo is to first get the query working in the SQL GUI of your choice and then transfer the query to your server side script.

Debugging an sql statement in an sql gui is usually a lot easier than trying to debug it in the server side script.

Dormilich 06-21-2011 10:46 AM

Quote:

Originally Posted by tangoforce (Post 1103738)
Double quotes tell PHP to examine the string inside it and if there are any variables found, replace them with their values. There is however a trade-off: PHP checks double quoted strings for variables it needs to replace - this uses more CPU cycles.

regarding the execution time, there is no indication that this would matter at all. (ref.)

tangoforce 06-21-2011 11:15 AM

Quote:

Originally Posted by bullant (Post 1103876)
I find the easiest and quickest way to check what the actual query about to be run is, is to echo it to the browser and syntax errors should then be fairly obvious.

For more complex queries a good practice imo is to first get the query working in the SQL GUI of your choice and then transfer the query to your server side script.

I agree I frequently test SQL through phpmyadmin to see if it will work as expected and I always use mysql_error() where appropriate too.

It was rather late at night when I created this tip for the noobs so it's not perfect and the SQL was taken from another topic here as it looked like a good example to demonstrate with. Obviously in hindsight I may have got that wrong but hey ho I tried!

bullant 06-21-2011 11:28 AM

Quote:

Originally Posted by tangoforce (Post 1103899)
Obviously in hindsight I may have got that wrong but hey ho I tried!

no problem :)

I wasn't trying to suggest anything you posted was wrong. You made very valid points which should help at least noobies.

The purpose of my post was basically to add to your tips but it may not have come across as so :(.

tangoforce 06-21-2011 12:17 PM

No, no, you got it right, it was a bit daft of me in hindsight to use SQL as an example but I found it in another topic and it looked perfect for a tip topic! In hindsight SQL, strings and quotes are entirely different but there we go, thats the kind of silly things i do at 1am!

When I first started learning php I never had access to a reliable connection so I had to learn a lot the hard way using localhost and a local copy of the php manual. I had to figure out a lot of stuff myself with no-one to ask (you know, the silly things that take hours to figure out like the IE bug in my sig) so I figured these tip topics could be pretty useful in helping others and answering those little silly things that aren't always immediately obvious.

Fou-Lu 06-21-2011 02:45 PM

Good.
Added to the FAQ thread.

TrevorWeaver 07-01-2011 06:24 PM

Thanks for your concise explanation.

Seems I was wrong but that is nothing new....was just trying to be helpful....so thanks for pointing me in the right direction.

Regards Trevor

coin 10-06-2011 04:37 PM

You accidentally threw an extra double quote in on your last example.
PHP Code:

//This will work:
$Comment "Joe blogg's latest blog is: " .get_comment()"; 

Should be
PHP Code:

//This will work:
$Comment "Joe blogg's latest blog is: " .get_comment(); 


tangoforce 10-06-2011 04:58 PM

Yes I'm aware of that but unfortunately I can't edit the post. The forum locks it after a few minutes.

It's not the only one, if you look closely there is also a few ' marks too but I did submit the article at 1:56am ;)

Inigoesdr 10-06-2011 05:53 PM

Fixed.

tangoforce 10-06-2011 06:05 PM

Thanks Inigoesdr, Any chance you could fix these two as well? - They're quotes:

Comment written by $Author'
Comment written by Joe Bloggs'

Both have an ' at the end. Sorry about that, no idea how I missed those when I previewed so many times :confused:

Fou-Lu 10-06-2011 06:23 PM

Quote:

Originally Posted by tangoforce (Post 1144411)
Thanks Inigoesdr, Any chance you could fix these two as well? - They're quotes:

Comment written by $Author'
Comment written by Joe Bloggs'

Both have an ' at the end. Sorry about that, no idea how I missed those when I previewed so many times :confused:

Done. Not a huge deal with the output, but easier than explaining after its a typo lol.

tangoforce 10-06-2011 06:38 PM

Thanks Fou ;)


All times are GMT +1. The time now is 06:19 AM.

Powered by vBulletin®
Copyright ©2000 - 2013, Jelsoft Enterprises Ltd.