Hello and welcome to our community! Is this your first visit?
Register
Enjoy an ad free experience by logging in. Not a member yet? Register.
Results 1 to 6 of 6
  1. #1
    New Coder
    Join Date
    Aug 2011
    Posts
    25
    Thanks
    5
    Thanked 0 Times in 0 Posts

    sql syntax error

    i always got this error everytime i run my website : 1064 - You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '' at line 1

    select value from currencies WHERE currencies_id =



    here's the featured_products.php page



    PHP Code:

    <?php
    /*
      $Id: featured_products.php,v 1.5.8 2003/06/09 22:35:33 hpdl Exp $

      osCommerce, Open Source E-Commerce Solutions
      http://www.oscommerce.com

      Copyright (c) 2003 osCommerce

      Released under the GNU General Public License
    */

      
    require('includes/application_top.php');

      require(
    DIR_WS_LANGUAGES $language '/' FILENAME_FEATURED_PRODUCTS);

      
    $breadcrumb->add(NAVBAR_TITLEtep_href_link(FILENAME_FEATURED_PRODUCTS));
    ?>
    <!doctype html public "-//W3C//DTD HTML 4.01 Transitional//EN">
    <html <?php echo HTML_PARAMS?>>
    <head>
    <meta http-equiv="Content-Type" content="text/html; charset=<?php echo CHARSET?>">
    <title><?php echo TITLE?></title>
    <base href="<?php echo (($request_type == 'SSL') ? HTTPS_SERVER HTTP_SERVER) . DIR_WS_CATALOG?>">
    <link rel="stylesheet" type="text/css" href="stylesheet.css">
    </head>
    <body marginwidth="0" marginheight="0" topmargin="0" bottommargin="0" leftmargin="0" rightmargin="0">
    <!-- header //-->
    <?php require(DIR_WS_INCLUDES 'header.php'); ?>
    <!-- header_eof //-->

    <!-- body //-->
    <table border="0" width="100%" cellspacing="3" cellpadding="3">
      <tr>
        <td width="<?php echo BOX_WIDTH?>" valign="top"><table border="0" width="<?php echo BOX_WIDTH?>" cellspacing="0" cellpadding="2">
    <!-- left_navigation //-->
    <?php require(DIR_WS_INCLUDES 'column_left.php'); ?>
    <!-- left_navigation_eof //-->
        </table></td>
    <!-- body_text //-->
        <td width="100%" valign="top"><table border="0" width="100%" cellspacing="0" cellpadding="0">
          <tr>
            <td><table border="0" width="100%" cellspacing="0" cellpadding="0">
              <tr>
                <td class="pageHeading"><?php echo HEADING_TITLE?></td>
                <!--td class="pageHeading" align="right"><?php //echo tep_image(DIR_WS_IMAGES . 'table_background_products_new.gif', HEADING_TITLE, HEADING_IMAGE_WIDTH, HEADING_IMAGE_HEIGHT); ?></td-->
              </tr>
            </table></td>
          </tr>
          <tr>
            <td><?php echo tep_draw_separator('pixel_trans.gif''100%''10'); ?></td>
          </tr>
    <?php
    ///// To random featured products
    //  list($usec, $sec) = explode(' ', microtime());
    //  srand( (float) $sec + ((float) $usec * 100000) );
    //  $mtm= rand();
    //////  
       
    $featured_products_array = array();
       
    $featured_products_query_raw "select p.products_id, pd.products_name, p.products_image, p.products_price, p.products_tax_class_id, IF(s.status, s.specials_new_products_price, NULL) as specials_new_products_price, p.products_date_added, m.manufacturers_name
       from " 
    TABLE_PRODUCTS " p left join " TABLE_MANUFACTURERS " m on p.manufacturers_id = m.manufacturers_id
       left join " 
    TABLE_PRODUCTS_DESCRIPTION " pd on p.products_id = pd.products_id and pd.language_id = '" $languages_id "'
       left join " 
    TABLE_SPECIALS " s on p.products_id = s.products_id
       left join " 
    TABLE_FEATURED " f on p.products_id = f.products_id
       where p.products_status = '1' and f.status = '1' order by p.products_date_added DESC, pd.products_name"
    ;
    // to random//  $featured_products_query_raw = "select p.products_id, pd.products_name, p.products_image, p.products_price, p.products_tax_class_id, IF(s.status, s.specials_new_products_price, NULL) as specials_new_products_price, p.products_date_added, m.manufacturers_name from " . TABLE_PRODUCTS . " p left join " . TABLE_MANUFACTURERS . " m on p.manufacturers_id = m.manufacturers_id left join " . TABLE_PRODUCTS_DESCRIPTION . " pd on p.products_id = pd.products_id and pd.language_id = '" . $languages_id . "' left join " . TABLE_SPECIALS . " s on p.products_id = s.products_id left join " . TABLE_FEATURED . " f on p.products_id = f.products_id where p.products_status = '1' and f.status = '1' order by rand($mtm)";
       
    $featured_products_split = new splitPageResults($featured_products_query_rawMAX_DISPLAY_FEATURED_PRODUCTS);

      if ((
    $featured_products_split->number_of_rows 0) && ((PREV_NEXT_BAR_LOCATION == '1') || (PREV_NEXT_BAR_LOCATION == '3'))) {
    ?>
          <tr>
            <td><table border="0" width="100%" cellspacing="0" cellpadding="2">
              <tr>
                <td class="smallText"><?php echo $featured_products_split->display_count(TEXT_DISPLAY_NUMBER_OF_FEATURED_PRODUCTS); ?> </td>
                <td align="right" class="smallText"><?php echo TEXT_RESULT_PAGE ' ' $featured_products_split->display_links(MAX_DISPLAY_PAGE_LINKStep_get_all_get_params(array('page''info''x''y'))); ?></td>
              </tr>
            </table></td>
          </tr>
          <tr>
            <td><?php echo tep_draw_separator('pixel_trans.gif''100%''10'); ?></td>
          </tr>
    <?php
      
    }
    ?>
          <tr>
            <td> <!-- Featured Products Main Page Box -->
             <table bgcolor="ffffff" border="0" width="100%" cellspacing="0" cellpadding="2">
    <?php
      
    if ($featured_products_split->number_of_rows 0) {
        
    $featured_products_query tep_db_query($featured_products_split->sql_query);
        while (
    $featured_products tep_db_fetch_array($featured_products_query)) {
            if (
    tep_not_null($featured_products['specials_new_products_price'])) {
            
    $products_price '<s>' $currencies->display_price($featured_products['products_price'], tep_get_tax_rate($featured_products['products_tax_class_id'])) . '</s><br>';
               
    $products_price .= '<span class="productSpecialPrice">' $currencies->display_price($featured_products['specials_new_products_price'], tep_get_tax_rate($featured_products['products_tax_class_id'])) . '</span>';
          } else {
            
    $products_price $currencies->display_price($featured_products['products_price'], tep_get_tax_rate($featured_products['products_tax_class_id']));
          }
    ?>
              <tr>
                <td width="<?php echo SMALL_IMAGE_WIDTH 10?>" valign="top" class="main"><?php echo '<a href="' tep_href_link(FILENAME_PRODUCT_INFO'products_id=' $featured_products['products_id']) . '">' tep_image(DIR_WS_IMAGES $featured_products['products_image'], $featured_products['products_name'], SMALL_IMAGE_WIDTHSMALL_IMAGE_HEIGHT) . '</a>'?></td>
                <td valign="top" class="main"><?php echo '<a href="' tep_href_link(FILENAME_PRODUCT_INFO'products_id=' $featured_products['products_id']) . '"><b><u>' $featured_products['products_name'] . '</u></b></a><br>' TEXT_DATE_ADDED ' ' tep_date_long($featured_products['products_date_added']) . '<br>' TEXT_MANUFACTURER ' ' $featured_products['manufacturers_name'] . '<br><br>' TEXT_PRICE ' ' $products_price?></td>
                <td align="right" valign="middle" class="main"><?php echo '<a href="' tep_href_link(FILENAME_FEATURED_PRODUCTStep_get_all_get_params(array('action')) . 'action=buy_now&products_id=' $featured_products['products_id']) . '">' tep_image_button('button_in_cart.gif'IMAGE_BUTTON_IN_CART) . '</a>'?></td>
              </tr>
              <tr>
                <td colspüan="3"><?php echo tep_draw_separator('pixel_trans.gif''100%''10'); ?></td>
              </tr>
    <?php
        
    }
      } else {
    ?>
              <tr>
                <td class="main"><?php echo TEXT_NO_NEW_PRODUCTS?></td>
              </tr>
              <tr>
                <td><?php echo tep_draw_separator('pixel_trans.gif''100%''10'); ?></td>
              </tr>
    <?php
      
    }
    ?>
            </table>
            </td>
          </tr>
    <?php
      
    if (($featured_products_split->number_of_rows 0) && ((PREV_NEXT_BAR_LOCATION == '2') || (PREV_NEXT_BAR_LOCATION == '3'))) {
    ?>
          <tr>
            <td>
              <table border="0" width="100%" cellspacing="0" cellpadding="2">
              <tr>
                <td class="smallText"><?php echo $featured_products_split->display_count(TEXT_DISPLAY_NUMBER_OF_FEATURED_PRODUCTS); ?></td>
                <td align="right" class="smallText"><?php echo TEXT_RESULT_PAGE ' ' $featured_products_split->display_links(MAX_DISPLAY_PAGE_LINKStep_get_all_get_params(array('page''info''x''y'))); ?></td>
              </tr>
            </table>
           </td>
          </tr>
    <?php
      
    }
    ?>
        </table></td>
    <!-- body_text_eof //-->
        <td width="<?php echo BOX_WIDTH?>" valign="top"><table border="0" width="<?php echo BOX_WIDTH?>" cellspacing="0" cellpadding="2">
    <!-- right_navigation //-->
    <?php require(DIR_WS_INCLUDES 'column_right.php'); ?>
    <!-- right_navigation_eof //-->
        </table></td>
      </tr>
    </table>
    <!-- body_eof //-->

    <!-- footer //-->
    <?php require(DIR_WS_INCLUDES 'footer.php'); ?>
    <!-- footer_eof //-->
    <br>
    </body>
    </html>
    <?php require(DIR_WS_INCLUDES 'application_bottom.php'); ?>

  • #2
    Senior Coder
    Join Date
    Jul 2011
    Posts
    1,226
    Thanks
    3
    Thanked 171 Times in 171 Posts
    An sql syntax problem is not a php problem, it's an sql problem

    Specifically, it's a problem with your query. Your query is not built correctly. You have specified this query - select value from currencies WHERE currencies_id = - yet I don't see that anywhere in the page you quoted. I'm guessing the error is coming from an 'or die(mysql_error())' but we need to actually see exactly the query that is causing the issue. I'm not sure about joins, so I can't really tell you anything about the query on that quoted page apart from the fact it's coming from a standard library, so I'm guessing it's fine.

    Let us know the exact query and make sure you've given us the code from the exact page that gives this error. The error could be in your includes, so bear that in mind.

  • #3
    New Coder
    Join Date
    Aug 2011
    Posts
    25
    Thanks
    5
    Thanked 0 Times in 0 Posts
    so what would be the exact solutions that i need to do to trace the problem? any suggestions? thanks..

  • #4
    Senior Coder
    Join Date
    Jul 2011
    Posts
    1,226
    Thanks
    3
    Thanked 171 Times in 171 Posts
    Start on the components you've wrote yourself or modified. Also, where did you get that query from that you quoted in your original post?

  • #5
    Senior Coder
    Join Date
    Apr 2010
    Posts
    1,423
    Thanks
    69
    Thanked 102 Times in 101 Posts
    Yeah it's this query causing it.

    PHP Code:
    WHERE currencies_id 
    The variable after the equal sign is empty, could be the variable name is wrong, remember $name and $Name are two different variables.

  • #6
    Senior Coder
    Join Date
    Jul 2011
    Posts
    1,226
    Thanks
    3
    Thanked 171 Times in 171 Posts
    Quote Originally Posted by myfayt View Post
    Yeah it's this query causing it.

    PHP Code:
    WHERE currencies_id 
    The variable after the equal sign is empty, could be the variable name is wrong, remember $name and $Name are two different variables.
    We don't know where that has come from though - it's not in his pasted code snippet.

    You are correct, it's wrong, but without knowing where it actually came from we can't be sure that's the problem


  •  

    Posting Permissions

    • You may not post new threads
    • You may not post replies
    • You may not post attachments
    • You may not edit your posts
    •