Hello and welcome to our community! Is this your first visit?
Register
Enjoy an ad free experience by logging in. Not a member yet? Register.
Results 1 to 12 of 12
  1. #1
    Regular Coder
    Join Date
    Apr 2006
    Location
    UK, England
    Posts
    268
    Thanks
    2
    Thanked 0 Times in 0 Posts

    Small modification to be made, is this price right?

    I have a script which requires a minor modification to be made and I have been quoted £30/$60 for this modification to be done. The work will be done by the publisher themselves, so its a bit of a monopoly. Though, they are fine with myself altering it.

    Well, its s checkout script, the section requiring mofdification is the discount part. Right now, the discount is applied to everything - the grand total. However, insted, I would like the discount to be only applied to one item through the checkout.

    For eg, lets say, the script is for web hosting. First the customer selects the domain, then a package, then any extras, then checkout. So I would like this discount code to take affect on the web hosting price only - not the grand total as it is currently configured.

    Here is the Code that needs to be editted:

    PHP Code:
    <?php

    $empty 
    mysql_db_query($db"delete from table_discountlog where identifier='$my_session'"$connection);
    check_mysql($empty);

    # CHECK FOR ACCOUNT TYPE DISCOUNT

    $query mysql_db_query($db"SELECT inddiscount from table_customers where username='$username'"$connection);
    while (
    $row mysql_fetch_array($query)) {
    $inddiscount $row["inddiscount"];
    }

    if(
    $inddiscount 0) { $first_discount = ($total_price/100) * $inddiscount; }

    # CHECK FOR SET FEE DISCOUNTS
    $query mysql_db_query($db"SELECT discount from table_discounts where type='Set Fee' and code='$discount'"$connection);
    while (
    $row mysql_fetch_array($query)) {
    $set_discount_value $row["discount"];
    }

    if(
    $set_discount_value 0) { $second_discount $set_discount_value; }

    # CHECK FOR PERCENTAGE DISCOUNTS
    $query mysql_db_query($db"SELECT discount from table_discounts where type='Percentage' and code='$discount'"$connection);
    while (
    $row mysql_fetch_array($query)) {
    $discount_value $row["discount"];
    }

    if(
    $discount_value 0) { $third_discount $total_price * ($discount_value/100); }

    $total_discount $first_discount $second_discount $third_discount;

    # $total_discount = currency_format("%.2f",$total_discount);

    if($total_discount 0) {
    $now time();
    $insert mysql_db_query($db"INSERT into table_discountlog (discount, identifier, added) VALUES ('$total_discount', '$my_session', '$now')"$connection);
    }


    ?>
    So, am I being ripped off for this alteration, or is it something I can do myself. I get help from you guys with

  • #2
    Senior Coder
    Join Date
    Jan 2007
    Posts
    1,648
    Thanks
    1
    Thanked 58 Times in 54 Posts
    Although I'm not replying about the price (which sounds right I suppose, depending on the level of surrounding complexity), I've never seen tables prefixed with ... table.

    Other than that this is bad quality code. Shell style comments, old mysql_db_query() statement, no error checking on queries.

  • #3
    Super Moderator Inigoesdr's Avatar
    Join Date
    Mar 2007
    Location
    Florida, USA
    Posts
    3,642
    Thanks
    2
    Thanked 405 Times in 397 Posts
    Removed
    Last edited by Inigoesdr; 03-13-2007 at 11:19 PM.

  • #4
    Regular Coder
    Join Date
    Apr 2006
    Location
    UK, England
    Posts
    268
    Thanks
    2
    Thanked 0 Times in 0 Posts
    Quote Originally Posted by aedrin View Post
    Although I'm not replying about the price (which sounds right I suppose, depending on the level of surrounding complexity), I've never seen tables prefixed with ... table.

    Other than that this is bad quality code. Shell style comments, old mysql_db_query() statement, no error checking on queries.
    Thanks for your input.

    If this is such a bad quality script I dont think he should be charging such a price. I mean, I but the whole script for a little bit more than what he charging for this work.

    I just need to get this code modified!

  • #5
    Senior Coder
    Join Date
    Sep 2005
    Posts
    1,791
    Thanks
    5
    Thanked 36 Times in 35 Posts
    £30 doesn't sound like a lot to me, I'd probably charge more
    The guy is probably assuming about 30mins actual coding, another 15 in correspondence with you and then the remainder to cover the time eaten in correspondence with people that never led to anything.
    My thoughts on some things: http://codemeetsmusic.com
    And my scrapbook of cool things: http://gjones.tumblr.com

  • #6
    Senior Coder
    Join Date
    Jan 2007
    Posts
    1,648
    Thanks
    1
    Thanked 58 Times in 54 Posts
    Although you bought it for the same price, I'm guessing the person resells it often. So the comparison is not fair.

    But yeah, judging from the quality that price shouldn't be more than 2 hours of work. If he is planning less than 2 hours, it's overcharging.

  • #7
    Regular Coder
    Join Date
    Apr 2006
    Location
    UK, England
    Posts
    268
    Thanks
    2
    Thanked 0 Times in 0 Posts
    Quote Originally Posted by aedrin View Post
    But yeah, judging from the quality that price shouldn't be more than 2 hours of work. If he is planning less than 2 hours, it's overcharging.
    2 Hours?!

    No way - I received an email from him, and in it he was indirectly tell me it will take less than half and hour, but they charge a minimum of £30 + VAT

  • #8
    Regular Coder the-dream's Avatar
    Join Date
    Mar 2007
    Location
    Northamptonshire, UK
    Posts
    477
    Thanks
    8
    Thanked 4 Times in 4 Posts
    if its less than half an hour work to them you are getting ripped off. Big time.

  • #9
    Regular Coder
    Join Date
    Apr 2006
    Location
    UK, England
    Posts
    268
    Thanks
    2
    Thanked 0 Times in 0 Posts
    Its just a question of making the discount effect a different price, it shouldnt take that long.

    If it cant be done here, I guess I have no other choice but to pay up.

  • #10
    UE Antagonizer Fumigator's Avatar
    Join Date
    Dec 2005
    Location
    Utah, USA, Northwestern hemisphere, Earth, Solar System, Milky Way Galaxy, Alpha Quadrant
    Posts
    7,691
    Thanks
    42
    Thanked 637 Times in 625 Posts
    I'm not going to make the changes for you and cut the legs off a fellow professional programmer, sorry.

    If you attempt the change yourself and get stuck, feel free to ask questions about what specifically you are struggling with.

    60 bucks is completely reasonable for a custom script modification, regardless of how long it takes. You're not paying an hourly wage, you're paying for a specific enhancement.

  • #11
    Regular Coder the-dream's Avatar
    Join Date
    Mar 2007
    Location
    Northamptonshire, UK
    Posts
    477
    Thanks
    8
    Thanked 4 Times in 4 Posts
    Quote Originally Posted by Fumigator View Post
    I'm not going to make the changes for you and cut the legs off a fellow professional programmer, sorry.

    If you attempt the change yourself and get stuck, feel free to ask questions about what specifically you are struggling with.

    60 bucks is completely reasonable for a custom script modification, regardless of how long it takes. You're not paying an hourly wage, you're paying for a specific enhancement.
    That is a point!

  • #12
    Regular Coder
    Join Date
    Apr 2006
    Location
    UK, England
    Posts
    268
    Thanks
    2
    Thanked 0 Times in 0 Posts
    This 'professional programmer' is not your friend. I also think he should be charging on the intensity of the work to be done, its just easy money...and we both know it.

    But yes, any pointers would be nice - any suggestions on what I should be looking at for change?

    I got this value out from the code:

    Code:
    ($total_price/100)
    I guess on that line the discount is being applied to the total price as the value shows. I dont know what value will point to the specific item.

    Are there many things to change within this code to get the desired result?


  •  

    Posting Permissions

    • You may not post new threads
    • You may not post replies
    • You may not post attachments
    • You may not edit your posts
    •