Hello and welcome to our community! Is this your first visit?
Register
Enjoy an ad free experience by logging in. Not a member yet? Register.
Results 1 to 2 of 2
  1. #1
    New to the CF scene
    Join Date
    Sep 2012
    Location
    Vermont
    Posts
    2
    Thanks
    0
    Thanked 0 Times in 0 Posts

    Multiple javascript codes in same html not working, not sure why?

    I am trying to include numerous javascripts into one html page but one of them is giving me a headache and it is falling fall leaves. The best I can get is one in the upper left hand corner and then my clock doesn't work. I tried doing it the way the tutorial in another site explained by adding "onload do this();onload do that()" but it didn't work.

    Help!



    <SCRIPT LANGUAGE="JavaScript">
    <!-- Clock --
    var timerID = null
    var timerRunning = false

    function stopclock(){
    if(timerRunning)
    clearTimeout(timerID)
    timerRunning = false
    }

    function startclock(){
    stopclock()
    showtime()
    }

    function showtime(){
    var now = new Date()
    var hours = now.getHours()
    var minutes = now.getMinutes()
    var seconds = now.getSeconds()
    var timeValue = "" + ((hours > 12) ? hours - 12 : hours)
    timeValue += ((minutes < 10) ? ":0" : ":") + minutes
    timeValue += ((seconds < 10) ? ":0" : ":") + seconds
    timeValue += (hours >= 12) ? " P.M." : " A.M."
    document.clock.face.value = timeValue
    timerID = setTimeout("showtime()",1000)
    timerRunning = true
    }
    //-->
    </SCRIPT>
    <br />
    <br />
    <BODY onLoad="startclock()window.fall=">
    <!-------------------------------------------------------------------------------------------->
    <form name="clock" onSubmit="0">
    <INPUT TYPE="text" NAME="face" SIZE=11 VALUE ="....Initializing....">
    <br />
    <script src=http://fastonlineusers.com/online.php?d=www.mohager.co.sr></script>
    <br>
    <font face="Tahom/"><span style="font-size: 8pt; text-decoration: none"></span></a></font>
    </form>
    <br />
    <br />
    <br />
    <br />
    <div id="example"></div>
    <br />
    <script>
    txt = "<p>Browser CodeName: " + navigator.appCodeName + "</p>";
    txt+= "<p>Browser Name: " + navigator.appName + "</p>";
    txt+= "<p>Browser Version: " + navigator.appVersion + "</p>";
    txt+= "<p>Cookies Enabled: " + navigator.cookieEnabled + "</p>";
    txt+= "<p>Platform: " + navigator.platform + "</p>";
    txt+= "<p>User-agent header: " + navigator.userAgent + "</p>";
    document.getElementById("example").innerHTML=txt;
    </script>
    <script language="JavaScript1.2">

    //Pre-load your image below!
    grphcs=new Array(6)
    Image0=new Image();
    Image0.src=grphcs[0]="http://javascriptfreecode.com/images/barg.gif";
    Image1=new Image();
    Image1.src=grphcs[1]="http://javascriptfreecode.com/images/barg.gif"
    Image2=new Image();
    Image2.src=grphcs[2]="http://javascriptfreecode.com/images/barg.gif"
    Image3=new Image();
    Image3.src=grphcs[3]="http://javascriptfreecode.com/images/barg.gif"
    Image4=new Image();
    Image4.src=grphcs[4]="http://javascriptfreecode.com/images/barg.gif"
    Image5=new Image();
    Image5.src=grphcs[5]="http://javascriptfreecode.com/images/barg.gif"

    Amount=8;
    Ypos=new Array();
    Xpos=new Array();
    Speed=new Array();
    Step=new Array();
    Cstep=new Array();
    ns=(document.layers)?1:0;
    ns6=(document.getElementById&&!document.all)?1:0;

    if (ns){
    for (i = 0; i < Amount; i++){
    var P=Math.floor(Math.random()*grphcs.length);
    rndPic=grphcs[P];
    document.write("<LAYER NAME='sn"+i+"' LEFT=0 TOP=0><img src="+rndPic+"></LAYER>");
    }
    }
    else{
    document.write('<div style="position:absolute;top:0px;left:0px"><div style="position:relative">');
    for (i = 0; i < Amount; i++){
    var P=Math.floor(Math.random()*grphcs.length);
    rndPic=grphcs[P];
    document.write('<img id="si'+i+'" src="'+rndPic+'" style="position:absolute;top:0px;left:0px">');
    }
    document.write('</div></div>');
    }
    WinHeight=(ns||ns6)?window.innerHeight:window.document.body.clientHeight;
    WinWidth=(ns||ns6)?window.innerWidth-70:window.document.body.clientWidth;
    for (i=0; i < Amount; i++){
    Ypos[i] = Math.round(Math.random()*WinHeight);
    Xpos[i] = Math.round(Math.random()*WinWidth);
    Speed[i]= Math.random()*5+3;
    Cstep[i]=0;
    Step[i]=Math.random()*0.1+0.05;
    }
    function fall(){
    var WinHeight=(ns||ns6)?window.innerHeight:window.document.body.clientHeight;
    var WinWidth=(ns||ns6)?window.innerWidth-70:window.document.body.clientWidth;
    var hscrll=(ns||ns6)?window.pageYOffset:document.body.scrollTop;
    var wscrll=(ns||ns6)?window.pageXOffset:document.body.scrollLeft;
    for (i=0; i < Amount; i++){
    sy = Speed[i]*Math.sin(90*Math.PI/180);
    sx = Speed[i]*Math.cos(Cstep[i]);
    Ypos[i]+=sy;
    Xpos[i]+=sx;
    if (Ypos[i] > WinHeight){
    Ypos[i]=-60;
    Xpos[i]=Math.round(Math.random()*WinWidth);
    Speed[i]=Math.random()*5+3;
    }
    if (ns){
    document.layers['sn'+i].left=Xpos[i];
    document.layers['sn'+i].top=Ypos[i]+hscrll;
    }
    else if (ns6){
    document.getElementById("si"+i).style.left=Math.min(WinWidth,Xpos[i]);
    document.getElementById("si"+i).style.top=Ypos[i]+hscrll;
    }
    else{
    eval("document.all.si"+i).style.left=Xpos[i];
    eval("document.all.si"+i).style.top=Ypos[i]+hscrll;
    }
    Cstep[i]+=Step[i];
    }
    setTimeout('fall()',20);
    }

    window.onload=fall
    //-->
    </script>

    <br />
    <!-- Search Google -->
    <center>
    <FORM method=GET action="http://www.google.com/search">

    <IMG SRC="http://www.google.com/logos/Logo_40wht.gif" <br></A>
    <INPUT TYPE=text name=q size=31 maxlength=255 value="">
    <INPUT TYPE=hidden name=hl value="en">
    <INPUT type=submit name=btnG VALUE="Google Search">
    </td></tr></TABLE>
    </FORM>
    </center>
    <!-- Search Google -->

  • #2
    Supreme Master coder! Philip M's Avatar
    Join Date
    Jun 2002
    Location
    London, England
    Posts
    17,898
    Thanks
    203
    Thanked 2,530 Times in 2,508 Posts
    <script language=javascript> is long deprecated. Use <script type = "text/javascript"> instead (in fact also deprecated but still necessary for IE<9).
    The <!-- and //--> comment (hiding) tags have not been necessary since IE3 (i.e. since September 1997). If you see these in some published script it is a warning that you are looking at ancient and perhaps unreliable code.

    Netscape browser is long one with Nineveh and Tyre. Using eval() is considered very bad coding. The eval() function in Javascript is a way to run arbitrary code at run-time. In almost all cases, eval() should never be used. If it exists in your page, there is almost always a more correct way to accomplish what you are doing.

    In short - go for a more modern script.

    As you say, you may not have multiple onload statements.

    Code:
    <body onload="startclock(); fall()">
    You can simply fire a set of functions when the page loads rather than <body onload = ...

    Code:
    <script type="text/javascript">
    window.onload = function() {
    startclock();
    fall();
    }
    </script>
    All advice is supplied packaged by intellectual weight, and not by volume. Contents may settle slightly in transit.
    Last edited by Philip M; 10-01-2012 at 09:03 AM.

    All the code given in this post has been tested and is intended to address the question asked.
    Unless stated otherwise it is not just a demonstration.


  •  

    Tags for this Thread

    Posting Permissions

    • You may not post new threads
    • You may not post replies
    • You may not post attachments
    • You may not edit your posts
    •