Hello and welcome to our community! Is this your first visit?
Register
Enjoy an ad free experience by logging in. Not a member yet? Register.
Results 1 to 2 of 2
  1. #1
    New to the CF scene
    Join Date
    Dec 2009
    Posts
    3
    Thanks
    0
    Thanked 0 Times in 0 Posts

    Question Javascript issue: new browser window

    Dear All,
    I have downloaded some code from a javascript programmers website but having trouble making it work!

    I have some javascript:

    [CODE]

    <SCRIPT TYPE="text/javascript">
    <!--
    function dropdown(mySel)
    {
    var myWin, myVal;
    myVal = mySel.options[mySel.selectedIndex].value;
    if(myVal)
    {
    if(mySel.form.target)myWin = parent[mySel.form.target];
    else myWin = window;
    if (! myWin) return true;
    myWin.location = myVal;
    }
    return false;
    }
    //-->
    </SCRIPT>

    [CODE]

    Within the main body, my code reads:
    [CODE]

    <FORM
    ACTION="../cgi-bin/redirect.pl"
    METHOD=POST onSubmit="return dropdown(this.gourl)">
    <SELECT NAME="gourl">
    <OPTION VALUE="">Please select your event...
    <OPTION VALUE="http://www.yahoo.co.uk"> preview yahoo UK</option>
    <OPTION VALUE="http://www.yahoo.com"> preview yahoo US</option>
    <OPTION VALUE="http://www.yahoo.fr"> preview yahoo FR</option>
    <OPTION VALUE="http://www.expedia.co.uk"> preview Expedia</option>
    <OPTION VALUE="http://www.travelocity.co.uk"> preview Travelocity</option>
    <OPTION VALUE="http://www.onlinepictureproof.com"> preview online pics</option>
    </SELECT>
    <INPUT TYPE=SUBMIT VALUE="Go">
    </FORM>

    [CODE]

    On selection of "preview yahoo UK" from drop-down box, it takes me to the correct webpage (www.yahoo.co.uk), so no issue there. However, it opens this page up in a new window. I'm pretty sure this is because the javascript code is telling it to. However, I want the www.yahoo.co.uk page to be displayed in the same window from where the request came from? (i.e. I don't want it to open a new browser window)!

    What do I have to change in the javascript to make this happen? I tried using the TARGET functionality taught to me many many moons ago, but it still fires up a new window: <OPTION VALUE="http://www.yahoo.co.uk" TARGET="_top"> preview yahoo UK</option>

    I am testing this on my PC, so perhaps it could be that redirect.pl isn't held locally on my home pc, i.e. it would work once we upload the web pages to the web server?!

    any help/guidance would be greatly appreciated.

  • #2
    Supreme Master coder! Philip M's Avatar
    Join Date
    Jun 2002
    Location
    London, England
    Posts
    17,919
    Thanks
    203
    Thanked 2,531 Times in 2,509 Posts



    Try this:-

    Code:
    <script type = "text/javascript">
    
    function dropdown(mySel) {
    var myVal = mySel.options[mySel.selectedIndex].value;
    if (myVal){
    window.location = myVal;
    return false;
    }
    }
    
    </script>

    The <!-- and //--> comment (hiding) tags have not been necessary since IE3. If you see these in some published script it is a warning that you are looking at ancient and perhaps unreliable code.




    Protestors Tried To Spoil Play But Actors Succeeded - London Evening News
    Last edited by Philip M; 12-11-2009 at 04:41 PM.


  •  

    Posting Permissions

    • You may not post new threads
    • You may not post replies
    • You may not post attachments
    • You may not edit your posts
    •