Hello and welcome to our community! Is this your first visit?
Register
Enjoy an ad free experience by logging in. Not a member yet? Register.
Page 1 of 2 12 LastLast
Results 1 to 15 of 17
  1. #1
    New Coder
    Join Date
    Apr 2013
    Posts
    13
    Thanks
    1
    Thanked 0 Times in 0 Posts

    marquee issue each image linking to same page

    so ive made this marquee

    for some reason each image is linking to the same page (first mentioned in the marquee)

    anyone have any ideas on how to fix this?

    <MARQUEE scrollamount="1" behavior="scroll" direction="up" width="100"><a href="hd-tropical-island-beach-paradise-wallpapers.htm"><img src="ta_siteimages/tropical.jpg" width="100" height="62"<a href="hd-garfield-and-friends-comic-desktop-wallpapers.htm" width="120" height="90"><img src="ta_siteimages/garfield.jpg" width="100" height="62"<a href="very-funny-pics-of-cats-and-photo-wallpapers.htm"><img src="ta_siteimages/cats.jpg" width="100" height="62"<a href="hd-supernatural-desktop-wallpapers-1920x1080-sam-and-dean"><img src="ta_siteimages/supernatural.jpg" width="100" height="62"<a href="the-augusta-national-golf-course-wallpapers-hd.htm"><img src="ta_siteimages/augusta.jpg" width="100" height="62"<a href="banjo-kazooie-wallpapers-hd-nuts-and-bolts-and-nintendo-64.htm"><img src="ta_siteimages/banjo.jpg" width="100" height="62"<a href="the-legend-of-zelda-twilight-princess-hd-wallpapers-skyward-sword.htm"><img src="ta_siteimages/zelda.jpg" width="100" height="62"<a href="vw-combie-van-hd-wallpapers-volkswagen-hippie-bus.htm"><img src="ta_siteimages/combi.jpg" width="100" height="62"</MARQUEE width="120" height="90">

  • #2
    Senior Coder whizard's Avatar
    Join Date
    Jan 2005
    Location
    Philadelphia, PA, USA
    Posts
    1,662
    Thanks
    14
    Thanked 76 Times in 76 Posts
    a) The MARQUEE element is an abhorrent tag introduced by IE (not part of a standard). Other browsers support it for legacy compatibility reasons only. It has not been in mainstream use for 10 years. Using it is not advisable. Use javascript instead to achieve that behavior on your site.

    b) At a glance, I'm confused as to why you have the height and width properties in the closing marquee tag. Closing tags as a rule don't take any properties.

    c) You haven't closed you <a> tags, this is most likely the root cause of the problem you are experiencing. Indenting your code would help you out here.

    Basic syntax should be:

    Code:
    <marquee>
       <a><img /></a>
       <a><img /></a>
       <a><img /></a>
       <a><img /></a>
       <a><img /></a>
       etc..
    </marquee>
    I am NOT endorsing use of the marquee tag. It has no place in any 21st century website.

    Edit:
    d) Dude you're not even closing your image tags. <img src="blah" width="blah" height="blah" />


    Dan
    Last edited by whizard; 07-24-2013 at 02:05 PM.
    PHP Tip: If you want to use short tags (<? or <?=$var) then make sure short_open_tag is set to "1". It really helps.

    Don't forget to save everyone time and mark your thread as Resolved :)

    "Also note that it is your responsibility to die() if necessary."

    DON'T USE THE MYSQL_ EXTENSION

  • #3
    New Coder
    Join Date
    Apr 2013
    Posts
    13
    Thanks
    1
    Thanked 0 Times in 0 Posts

    new idea

    Ok thanks im switching to javascript

    question on this

    http://www.javascriptkit.com/howto/cscroll2.shtml

    thats what im using

    so im putting it in an external js

    ive put everything upto the </script> in it

    do i put the div stuff at the bottom in the js file too?

  • #4
    Senior Coder whizard's Avatar
    Join Date
    Jan 2005
    Location
    Philadelphia, PA, USA
    Posts
    1,662
    Thanks
    14
    Thanked 76 Times in 76 Posts
    No, all the DIV stuff is the HTML code to put where you want the scrolling div.

    HTH
    Dan
    PHP Tip: If you want to use short tags (<? or <?=$var) then make sure short_open_tag is set to "1". It really helps.

    Don't forget to save everyone time and mark your thread as Resolved :)

    "Also note that it is your responsibility to die() if necessary."

    DON'T USE THE MYSQL_ EXTENSION

  • Users who have thanked whizard for this post:

    techagesite (07-25-2013)

  • #5
    New Coder
    Join Date
    Apr 2013
    Posts
    13
    Thanks
    1
    Thanked 0 Times in 0 Posts
    Ah ok thanks
    sort of a pain i was hoping to make it easier to update the scrolling div from an external js

  • #6
    New Coder
    Join Date
    Apr 2013
    Posts
    13
    Thanks
    1
    Thanked 0 Times in 0 Posts
    so ive putt the div bit in the page and my content in the div. where abouts in the div do i put the code to call the js file?

  • #7
    Senior Coder whizard's Avatar
    Join Date
    Jan 2005
    Location
    Philadelphia, PA, USA
    Posts
    1,662
    Thanks
    14
    Thanked 76 Times in 76 Posts
    Edit: See Below
    Last edited by whizard; 07-25-2013 at 08:56 PM.
    PHP Tip: If you want to use short tags (<? or <?=$var) then make sure short_open_tag is set to "1". It really helps.

    Don't forget to save everyone time and mark your thread as Resolved :)

    "Also note that it is your responsibility to die() if necessary."

    DON'T USE THE MYSQL_ EXTENSION

  • #8
    Master Coder felgall's Avatar
    Join Date
    Sep 2005
    Location
    Sydney, Australia
    Posts
    6,616
    Thanks
    0
    Thanked 645 Times in 635 Posts
    If you use a properly written marquee JavaScript then you can include any HTML you like within the marquee and have it function the same as if it were not in the marquee.

    Almost all properly written JavaScript goes just before the </body> tag. I know of exactly two exceptions that need to go in the head where they run before the page loads.
    Stephen
    Learn Modern JavaScript - http://javascriptexample.net/
    Helping others to solve their computer problem at http://www.felgall.com/

    Don't forget to start your JavaScript code with "use strict"; which makes it easier to find errors in your code.

  • #9
    Senior Coder whizard's Avatar
    Join Date
    Jan 2005
    Location
    Philadelphia, PA, USA
    Posts
    1,662
    Thanks
    14
    Thanked 76 Times in 76 Posts
    Thanks for clearing that up...I learned something
    PHP Tip: If you want to use short tags (<? or <?=$var) then make sure short_open_tag is set to "1". It really helps.

    Don't forget to save everyone time and mark your thread as Resolved :)

    "Also note that it is your responsibility to die() if necessary."

    DON'T USE THE MYSQL_ EXTENSION

  • #10
    Master Coder felgall's Avatar
    Join Date
    Sep 2005
    Location
    Sydney, Australia
    Posts
    6,616
    Thanks
    0
    Thanked 645 Times in 635 Posts
    If you are looking for a flexible marquee script that allows multiple marquees in the same page then take a look at my script at http://www.felgall.com/jstip109.htm which allows you to convert any part of the content into a marquee simply by adding a class and which also allows you to add start/stop buttons to anywhere in the page by giving an empty tag a class of 'marquess'
    Stephen
    Learn Modern JavaScript - http://javascriptexample.net/
    Helping others to solve their computer problem at http://www.felgall.com/

    Don't forget to start your JavaScript code with "use strict"; which makes it easier to find errors in your code.

  • #11
    New Coder
    Join Date
    Apr 2013
    Posts
    13
    Thanks
    1
    Thanked 0 Times in 0 Posts
    got that sorted but having a few issues

    www. techagesite. com/aaa%20template22.htm

    local the marquee is scrolling
    online it isnt
    the images arent linking to their pages

  • #12
    Senior Coder whizard's Avatar
    Join Date
    Jan 2005
    Location
    Philadelphia, PA, USA
    Posts
    1,662
    Thanks
    14
    Thanked 76 Times in 76 Posts
    Ok.

    a) You have no DOCTYPE
    b) You have an enormous amount of illegal code inside your <head>, code which SHOULD be in your <body>.
    c) You have an unclosed <a> tag which is messing up the next link tag.
    d) You are using the font tag, which was deprecated in HTML 4.01 in 2000. It is not supported in HTML 5.

    All of that not to mention you are using tables to lay out your site, which is an old, discredited strategy. Tables are intended for data.

    The fact that your code renders at all close to what you expect is a minor miracle. It's not even worth trying to debug your JS until you fix your errors, and there are many.

    Go to the HTML Validator to find out what your errors are, and begin fixing them.

    HTH
    Dan
    PHP Tip: If you want to use short tags (<? or <?=$var) then make sure short_open_tag is set to "1". It really helps.

    Don't forget to save everyone time and mark your thread as Resolved :)

    "Also note that it is your responsibility to die() if necessary."

    DON'T USE THE MYSQL_ EXTENSION

  • #13
    New Coder
    Join Date
    Apr 2013
    Posts
    13
    Thanks
    1
    Thanked 0 Times in 0 Posts
    at the end of the day the page does render, layout is how i want and overall im happy with it. as for doctype the page isnt finished and is still subject to change and im not worried about html 5

    where is this unclosed link?
    its not in the div content

  • #14
    Senior Coder whizard's Avatar
    Join Date
    Jan 2005
    Location
    Philadelphia, PA, USA
    Posts
    1,662
    Thanks
    14
    Thanked 76 Times in 76 Posts
    It's in this snippet, beginning on line 305. The bold link is the messed up one:

    Code:
    <!-- AddThis Button BEGIN -->
    <div class="addthis_toolbox addthis_default_style " style="width: 700; height: 18">
    <p style="margin-top: 0; margin-bottom: 0">
    <a class="addthis_button_facebook_like" fb:like:layout="button_count"></a>
    <a class="addthis_button_tweet"></a>
    <a class="addthis_button_pinterest_pinit">
    <a class="addthis_button_google_plusone" g:plusone:size="medium"></a>
    <a class="addthis_button_linkedin_counter"></a>
    <a class="addthis_button_hyves_respect"></a>
    <a class="addthis_counter addthis_pill_style"></a>
    </div>
    At the end of the day you page renders, but your JS doesn't work and there's no point trying to make the JS work on a broken page.

    I get you're not interested in HTML 5 but your page is just...broken. It's not right. It will never fully work as you want it to.

    IMHO
    Dan
    PHP Tip: If you want to use short tags (<? or <?=$var) then make sure short_open_tag is set to "1". It really helps.

    Don't forget to save everyone time and mark your thread as Resolved :)

    "Also note that it is your responsibility to die() if necessary."

    DON'T USE THE MYSQL_ EXTENSION

  • #15
    New Coder
    Join Date
    Apr 2013
    Posts
    13
    Thanks
    1
    Thanked 0 Times in 0 Posts
    anyone willing to help or are we just going to point out so called problems that arent affecting my site or do i need to call a dr to prescribe you valium for you 2013 coding dos and donts phobias?

    fact is my site does well despite how old my techniques are are il take joy in the fact that it down right pisses alot of you off


  •  
    Page 1 of 2 12 LastLast

    Posting Permissions

    • You may not post new threads
    • You may not post replies
    • You may not post attachments
    • You may not edit your posts
    •