Hello and welcome to our community! Is this your first visit?
Register
Enjoy an ad free experience by logging in. Not a member yet? Register.
Results 1 to 2 of 2
  1. #1
    New Coder
    Join Date
    Mar 2013
    Posts
    79
    Thanks
    45
    Thanked 0 Times in 0 Posts

    Please Review the website

    Please let me know is there is anything wrong with the website, i'm beginner in css

    Preview
    https://dl.dropbox.com/u/28490184/we...015/index.html

  • #2
    Master Coder Excavator's Avatar
    Join Date
    Dec 2006
    Location
    Alaska
    Posts
    9,673
    Thanks
    22
    Thanked 1,827 Times in 1,811 Posts
    Hello h123er2,
    I like the site, it looks really good so I'll give it a go. Short and to the point so please don't get offended.

    From the top then:
    • no point with zeroing out padding on body since there is no default padding
    • 100% height on #wrapper may not be doing what you think it is
    • Sami Designs is not a paragraph
    • #nav li is invalid
    • 500px height on #content-right doesn't really work since there is more than 500px of content there. It's always best not to specify a height and let the element expand to contain what you put in it. In this case, you float #updates but you don't put anything beside #updates...sort of the whole point of floats. At any rate, if an element contains floats you will need to understand how and when to clear them.
    • .line should be a horizontal rule. See examples here.
    • what is auto margins supposed to do on a full width element like #footer-content?
    • #footer-title is so important you don't even style it. See divitis here.
    • Extra contents is not a paragraph
    • Website designed by ... is not a paragraph
    • All those <div class="clear"></div> are just added markup. See the link above about clearing floats.


    I think some padding on your .paragraph's p.line-right might help, the text is right up next to the border right now.


    To show you why you need to clear your floats, look at your #footer-content with a background color like this -
    Code:
     #footer-content {
        background: #f00;
        margin: auto;
        width: 1100px;
    }
    Then clear the floats like this and see the difference -
    Code:
    #footer-content {
        background: #f00;
        margin: auto;
        overflow: auto;
        width: 1100px;
    }
    Last edited by Excavator; 04-07-2013 at 12:32 AM.
    Validate often DURING development - Use it like a splelchecker | Debug during Development |Write it for FireFox, ignore IE
    Use the right DocType | Validate your markup | Validate your CSS | Why validating is good | Why tables are bad

  • Users who have thanked Excavator for this post:

    h123er2 (04-07-2013)


  •  

    Posting Permissions

    • You may not post new threads
    • You may not post replies
    • You may not post attachments
    • You may not edit your posts
    •