Hello and welcome to our community! Is this your first visit?
Register
Enjoy an ad free experience by logging in. Not a member yet? Register.
Results 1 to 5 of 5
  1. #1
    New Coder
    Join Date
    Mar 2013
    Posts
    80
    Thanks
    45
    Thanked 0 Times in 0 Posts

    Made a webpage Review please

    I'm really a beginner.
    Comment and criticize please.
    Btw, when I click on Videos link is it okay for the whole page to refresh cuz ive seen on some websites only the content refreshes while navigation stays there.

    http://h123er2.cwahi.net/

  • #2
    Regular Coder
    Join Date
    Mar 2012
    Posts
    168
    Thanks
    5
    Thanked 11 Times in 11 Posts
    The layout is well done, the only problem I see is when I view your page in IE the word "Our" is displayed to the right of the image. Perhaps a <br/> before the header will fix that. As for the navigation, you will learn about includes when you study PHP. Add some styles to the design and fix some minor bugs and I think it'll be ready to go.

  • Users who have thanked KULP for this post:

    h123er2 (03-26-2013)

  • #3
    Regular Coder
    Join Date
    Mar 2013
    Posts
    262
    Thanks
    4
    Thanked 67 Times in 67 Posts
    It's perfectly fine if the whole page refreshes. There's nothing wrong with that, and tons of sites do that. In fact, it's easier for search engines to crawl your site if it's just a static pages. Anyway, you're still learning so just keep trying to learn everyday and take baby steps. Nobody will get everything at once.

    Under your PC World picture, there is this: .clear{clear:both;}. You can't see it unless you highlight it with the mouse. I'm not sure what that's doing there, but I think that's there by mistake. Lol.

    You should also try to format your pages. You have a layout, but there's no general structure to it right now. For example, you don't have to do this, but try thinking of it like this:

    1. Header
    2. Main Content
    3. Footer


    Put everything that belongs in the header inside the header. Header images, main navigation, logo, etc. could go in there.

    Main content should have your content. Things like teasers, information on your products, etc. could go in there.

    Your footer should have all other content like copyright information, a secondary navigation for about, contact, etc.

    Also, try to use some paragraph tags for your content.

  • Users who have thanked ttkim for this post:

    h123er2 (03-26-2013)

  • #4
    Master Coder Excavator's Avatar
    Join Date
    Dec 2006
    Location
    Alaska
    Posts
    9,675
    Thanks
    22
    Thanked 1,827 Times in 1,811 Posts
    Please don't use HTML tags like <br /> and &nbsp; to move your layout around! That's what CSS is for.

    To keep your heading from going up next to your banner.png give it a width or a clear ... like this -
    Code:
    #title h1{
    color: green;
    font-family: arial;
    clear: both;
    }
    ...
    You should check your code in the validators. Both your CSS and your markup have some errors that could be easily fixed.

    ...
    When I click on Videos, the new page loads without the menu or logo even flickering. The browser cache just reloads it on the newly rendered videos.html without downloading it again.

    ...
    Your use of a div element to clear things is just more added markup. CSS can clear floats for you.

    ...
    Just as an example, your image can be presented as src on it's own. You don't need to have every image in it's own div element and there are many times you may not want an image to be a background. Try it like this once -
    Code:
    <!doctype html>
    <html>
    <head>
    <meta charset="utf-8">
    <title>Untitled Document</title>
    <style type="text/css">
    html, body {
    	margin: 0;
    	background: #000;
    	font: 100% Arial, Helvetica, sans-serif;
    }
    #wrapper {
    	width: 1000px;
    	margin: 0 auto;
    }
    #header {
    	padding: 20px 0 0;
    	overflow: auto;
    }
    #header h1 {
    	float: left;
    	color: #fff;
    }
    #header h1 span { font-weight: bold; }
    #header img {
    	margin: 20px 20px 0 0;
    	float: right;
    }
    </style>
    </head>
    <body>
    	<div id="wrapper">
    		<div id="header">
    			<h1>Website <span> Productions</span></h1>
    			<img src="http://h123er2.cwahi.net/logobmw.png" alt="BMW logo" width="100" height="100">
    		<!--end header--></div>
    	<!--end wrapper--></div>
    </body>
    </html>
    Validate often DURING development - Use it like a splelchecker | Debug during Development |Write it for FireFox, ignore IE
    Use the right DocType | Validate your markup | Validate your CSS | Why validating is good | Why tables are bad

  • Users who have thanked Excavator for this post:

    h123er2 (03-26-2013)

  • #5
    Regular Coder
    Join Date
    Mar 2012
    Posts
    168
    Thanks
    5
    Thanked 11 Times in 11 Posts
    Thanks for the correction, Excavator.


  •  

    Posting Permissions

    • You may not post new threads
    • You may not post replies
    • You may not post attachments
    • You may not edit your posts
    •