Hello and welcome to our community! Is this your first visit?
Register
Enjoy an ad free experience by logging in. Not a member yet? Register.
Results 1 to 6 of 6
  1. #1
    New Coder
    Join Date
    May 2011
    Location
    Chicago, IL
    Posts
    19
    Thanks
    2
    Thanked 0 Times in 0 Posts

    Question Could you take a look at my markup?

    You all are so helpful from time to time whenever I post as to add that my markup is either correct or incorrect or needing adjustment. Well, I am still building my site but for the time could you offer any insights on my markups be it corrections or adjustments? Greatly appreciated.

    Website: http://www.richandbalanced.com

    Markup:

    Code:
    <!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN"
    
    "http://www.w3.org/TR/html4/loose.dtd">
    
    
    
    
    
    <html>
    
    
    
    <head><link rel="canonical" href="http://www.richandbalanced.com/"/><title>Rich and Balanced&trade;</title>
    
    
    
    <meta name="description" content="Create your rich and balanced life today!" >
    
    <meta name="keywords" content="Rich, Balanced, Life, Money, Health" >
    
    <meta name="author" content="Samuel Sweis" >
    
    
    
    </head>
    
    
    
    <link rel="shortcut icon" href="image-files/"> 
    
    
    
    <link rel="stylesheet" type="text/css" href="http://www.richandbalanced.com/support-files/style.css"> 
    
     
    
    <body> 
    
    
    
    <img class="displayed" src="http://www.richandbalanced.com/image-files/richandbalanced.jpg" width="498" height="108" alt="Rich and Balanced logo" border="0">
    
     
    
    
    
    <div class="reight">  
    
    
    
    <div id="rbleft_sidebar">
    
    <br /><br /><br />
    
    <p class="welcometab"><a  href="http://www.richandbalanced.com/index.html">Welcome</a> &nbsp &nbsp</p>
    
    <p class="exploretab"><a  href="http://www.richandbalanced.com/rich.html">Overview</a> &nbsp &nbsp</p>
    
     </div> 
    
    
    
    
    
    <div id="rbcontent"> 
    
    <h1>Rich and Balanced</h1>
    
    <p>
    
    Hello and welcome to Rich and Balanced&trade; my name is <a href="http://www.facebook.com/alwayslearningonline" target="_blank" onClick="window.open('http://www.richandbalanced.com/cgi-bin/counter.pl?url=http%3A%2F%2Fwww%2Efacebook%2Ecom%2Falwayslearningonline&referrer=http%3A%2F%2Fwww%2Erichandbalanced%2Ecom%2Findex%2Ehtml'); return false;">Sam Sweis</a>. Did you know that we all have the ability to change and create the life of our dreams? Did you know that no matter what is going on right now or happening in your life that <span class="underline">it is</span> possible?
    
    </p>
    
    
    
    <p>
    
    Five years ago...I was an alcoholic, a smoker, and a drug user.  A terrible husband in a marriage that ended in divorce.  Buried with debt.  In and out of school and in and out of jobs.  I was out of shape, obese, and depressed.  Always angry and in broken relationships with family and friends.  The future was a mystery to me.
    
    </p>
    
    
    
    <p>
    
    Today, I'm a proud father.  My financial life is a dream come true.  I have no major debt, my income is always growing, and I'm an excited business owner.  My relationships with family and friends are overflowing with love and happiness.  I'm tobacco free, drug free, alcohol free, and gambling free.  I've slimmed down my weight and put on muscle.  I'm healthy, fit, and confident.  But most of all, I get to spend my time the way I want doing what I want.
    
    </p>
    
    
    
    <p>
    
    Welcome to the place I call home.  Rich and Balanced&trade; was designed with you in mind.  Revealed for the first time in my life are the documents I use in private and secrecy that have changed my life and continue turning my dreams into a reality.  I put together this entire site, from the web designing to the graphics, and I couldn't be happier at transforming my knowledge to you.</p>
    
    
    
    <p>
    
    <a  href="http://www.richandbalanced.com/rich.html">Click here</a> for an overview of Rich and Balanced&trade;, or take a second and bookmark this page to save for later viewing.  Thank you for visiting Rich and Balanced&trade;.</p> 
    
    
    
    <p class="center"><a href="http://twitter.com/share" class="twitter-share-button" data-text="Create your Rich and Balanced Life™ today! Visit:" data-count="horizontal" data-via="richandbalanced" onClick="window.location.href='http://www.richandbalanced.com/cgi-bin/counter.pl?url=http%3A%2F%2Ftwitter%2Ecom%2Fshare&referrer=http%3A%2F%2Fwww%2Erichandbalanced%2Ecom%2Findex%2Ehtml'; return false;">Tweet</a><script type="text/javascript" src="http://platform.twitter.com/widgets.js"></script></p>
    
    
    
    </div> 
    
    
    
        <div id="rbright_sidebar"></div> 
    
    
    
    <div id="rbfooter">
    
    
    
    <div id="fb-root"></div><script src="http://connect.facebook.net/en_US/all.js#appId=205838536125629&amp;xfbml=1"></script><fb:like href="facebook.com/richandbalanced" send="true" layout="button_count" width="15" show_faces="true" font=""></fb:like></div>
    
    </div> 
    
    
    
    </div>
    
    
    
    <iframe src="balanced.html" width="100%" height="100" frameborder="0"></iframe>
    
    
    
    </body>
    
    </html>

  • #2
    New Coder
    Join Date
    Jun 2011
    Location
    Denver, CO
    Posts
    23
    Thanks
    0
    Thanked 7 Times in 7 Posts
    Your meta tags and link tags in the head as well as image tags in the body should be self-closing <stuff here... />

    Those are the glaring ones that I see. Some of the attributes (like data-text and data-via) I don't know and they're showing up invalid, but maybe they're part of something that I don't know, so I can't say one way or the other on those. I would run it through validator.w3.org and they will point out the main problems.

  • #3
    Senior Coder coothead's Avatar
    Join Date
    Jan 2004
    Location
    chertsey, a small town 25 miles south west of london, england.
    Posts
    1,696
    Thanks
    0
    Thanked 232 Times in 227 Posts
    Hi there spencerr3,
    Your meta tags and link tags in the head as well as image tags in the body should be self-closing
    Not with this dtd...
    Code:
    
    <!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN"
       "http://www.w3.org/TR/html4/loose.dtd">
    
    coothead

  • #4
    New Coder
    Join Date
    Jun 2011
    Location
    Denver, CO
    Posts
    23
    Thanks
    0
    Thanked 7 Times in 7 Posts
    Ah, didn't see that, I'm just used to following the strict guides haha.

  • #5
    Senior Coder
    Join Date
    Aug 2010
    Location
    High Point, NC
    Posts
    3,335
    Thanks
    5
    Thanked 363 Times in 360 Posts
    Well if its critique you're asking for...I would at least let users know when there is a linked text in your document. The text "Click here" in a paragraph may not be noticable enough if a user is not really looking for it. You could underline it or change its color or both, but it needs to stand out more than the rest of the text.
    Teed

  • #6
    New Coder
    Join Date
    May 2011
    Location
    Chicago, IL
    Posts
    19
    Thanks
    2
    Thanked 0 Times in 0 Posts

    Thumbs up

    Quote Originally Posted by teedoff View Post
    Well if its critique you're asking for...I would at least let users know when there is a linked text in your document. The text "Click here" in a paragraph may not be noticable enough if a user is not really looking for it. You could underline it or change its color or both, but it needs to stand out more than the rest of the text.
    Thank you, I have since taken action, great recommendation!

    And as always thanks again to everyone here at the forums.
    Last edited by SamuelSweis; 06-09-2011 at 05:06 PM.


  •  

    Posting Permissions

    • You may not post new threads
    • You may not post replies
    • You may not post attachments
    • You may not edit your posts
    •