Hello and welcome to our community! Is this your first visit?
Register
Enjoy an ad free experience by logging in. Not a member yet? Register.
Results 1 to 4 of 4
  1. #1
    New Coder
    Join Date
    Jan 2007
    Posts
    37
    Thanks
    1
    Thanked 0 Times in 0 Posts

    How does my code look>?

    How does my coding look?

    http://www.dhfolio.com

    I know I have only done the splash page but I wanted to be sure I was doing things right before I moved on and reused some of my code. By right I mean semantically.

    Thanks!

  • #2
    The fat guy next door VIPStephan's Avatar
    Join Date
    Jan 2006
    Location
    Halle (Saale), Germany
    Posts
    8,624
    Thanks
    6
    Thanked 1,001 Times in 974 Posts
    Wow, that code is a feast for my spoiled eyes. It’s heart-warming to see such nicely written, semantic, and well formatted code among the crap that I come across each day.

    The design is beautiful as well, by the way.

    One question, though: Why is the page title (headline 1) in a list within a div in the header? That’s about the only thing that doesn’t really makes sense (has no semantic meaning). And you’re not even using it to apply styles. Hence, the list and the div with ID logo ain’t necessary at all. Oh and the same goes for the navigation. The wrapping div is not necessary.

    I’d also suggest to use “skip to content/top” links for accessibility which you hide for screen layouts (but will be visible e.g. for small screen devices).

    Edit:
    Well, now that I’m looking closer (and with styles disabled) I see that you have been using headlines for all your content. Why is that? Headlines are only meant for… well, headlines. If you look at it without styles it’s gotta make sense as well. This also means that you should put the website screenshots as actual images into the HTML. A headline can be used for the project name/title but the rest should be regular text (in divs or lists if that applies). Have a look at my portfolio to get an idea (and look at it in Firefox or Opera with styles switched off). I also separated the projects with a horizontal rule.
    But after all, good work!
    Last edited by VIPStephan; 09-20-2007 at 08:52 PM.

  • Users who have thanked VIPStephan for this post:

    Dave.H (09-20-2007)

  • #3
    eak
    eak is offline
    Regular Coder eak's Avatar
    Join Date
    Jun 2002
    Location
    Nashville, TN
    Posts
    354
    Thanks
    0
    Thanked 26 Times in 26 Posts
    Looks good. Its nice to see someone else that indents.
    You wouldn't believe all crappy code I see on a regular basis at work.
    I see no indentation, no CSS, and non-semantic garbage.
    eak | "Doing a good deed is like wetting your pants; every one can see the results, but only you can feel the warmth."

  • #4
    New Coder
    Join Date
    Jan 2007
    Posts
    37
    Thanks
    1
    Thanked 0 Times in 0 Posts
    Great Thanks for all your help! I am still pretty new to xhtml css layouts so I'm happy to see that I'm doing things right! Ill make the header adjustments the only reason I used them is because I thought it was important for SEO use not semantics.

    Thanks Again.


  •  

    Posting Permissions

    • You may not post new threads
    • You may not post replies
    • You may not post attachments
    • You may not edit your posts
    •