Hello and welcome to our community! Is this your first visit?
Register
Enjoy an ad free experience by logging in. Not a member yet? Register.
Results 1 to 4 of 4
  1. #1
    New Coder
    Join Date
    Feb 2004
    Posts
    30
    Thanks
    0
    Thanked 0 Times in 0 Posts

    Question NN4 Section of script not working

    Hi Everyone,

    I have a script that is designed to dynamically position page elements. It is working very well in IE6 and NN7. However I have tried the script in NN4 and it is not working at all. I have not yet had the opportunity to test this script on IE4! Please see the code below, the largely commented section toward the bottom of the script is where the NN4 commands are located. If you can help me with working out what is wrong with the way I have written this script I will be greatly appreciative.

    <html>
    <title> Simple Element Positioning Script </title>
    <head>
    <style type="text/css">
    #car
    {
    position: absolute;
    }
    </style>
    <script language="javascript" type="text/javascript">
    // <!--
    // Set an indicator variable to determine DOM supported by current browser.

    var domIndicator = 0;

    if(document.getElementById)
    {
    // IE5+ or NS6+ Browser detected.
    domIndicator = 1;
    }
    else
    if(document.all)
    {
    // IE4 Browser detected.
    domIndicator = 2;
    }
    else
    if(document.layers)
    {
    // NS4 Browser detected.
    domIndicator = 3;
    }

    function posElem(elementID, xPos, yPos)
    {
    if(domIndicator == 1)
    {
    var element = document.getElementById(elementID);
    element.style.left = xPos;
    element.style.top = yPos;
    }
    else
    if(domIndicator == 2)
    {
    var element = document.all.item(elementID);
    element.style.posLeft = xPos;
    element.style.posTop = yPos;
    }
    else
    if(domIndicator == 3)
    {
    //When run in NN4 the following error message is produced regardless of
    //which of the following techniques is used!

    //JavaScript Error: file:/E|/Web Development/SimplePositioner.htm, line 52:
    //**** document.elementID has no properties. ******

    //document.layers[elementID].left = xPos;
    //document.layers[elementID].top = yPos;

    //document.elementID.left = xPos;
    //document.elementID.top = yPos;

    //var element = document.layers[elementID];
    //element.left = xPos;
    //element.top = yPos;
    }
    }

    // -->
    </script>
    </head>
    <body>
    <img id="car" src="car.jpg">
    <script type="text/javascript">
    posElem('car', 100, 100);
    </script>
    </body>
    </html>

    Also if you can see anything wrong with the way the IE4 section is coded can you please point it out, as I am not in a position to check this section (I don't have IE4 - I guess not many people do). Thanks heaps for your assistance.

    Regards

    Davo


  • #2
    Supreme Master coder! glenngv's Avatar
    Join Date
    Jun 2002
    Location
    Philippines
    Posts
    11,042
    Thanks
    0
    Thanked 251 Times in 247 Posts
    Put the image inside the div tag and move the id there.

    <div id="car"><img src="car.jpg" /></div>

    and then use the original code:

    document.layers[elementID].left = xPos;
    document.layers[elementID].top = yPos;

  • #3
    Regular Coder
    Join Date
    May 2004
    Location
    Alabama, USA
    Posts
    237
    Thanks
    0
    Thanked 0 Times in 0 Posts
    Another idea: Don't call posElem() in the body, call it in the onload event handler.

    Also if you can see anything wrong with the way the IE4 section...
    element = document.all[elementID];

    In NN4 if the positioned element is contained by another positioned element then you have to recurse thru document.layers[id].document.layers[id] etc. For example:

    Code:
    function xGetElementById(e) {
      if(typeof(e)!='string') return e;
      if(document.getElementById) e=document.getElementById(e);
      else if(document.all) e=document.all[e];
      else if(document.layers) e=xLayer(e);
      else e=null;
      return e;
    }
    function xLayer(id,root) {
      var i,layer,found=null;
      if (!root) root=window;
      for(i=0; i<root.document.layers.length; i++) {
        layer=root.document.layers[i];
        if(layer.id==id) return layer;
        if(layer.document.layers.length) found=xLayer(id,layer);
        if(found) return found;
      }
      return null;
    }
    // taken from the X library, licensed LGPL

  • #4
    Regular Coder
    Join Date
    May 2004
    Location
    Alabama, USA
    Posts
    237
    Thanks
    0
    Thanked 0 Times in 0 Posts

    !!!

    BTW, its almost sacrilegious to be discussing NN4 in the DOM forum ;-) LOL!


  •  

    Posting Permissions

    • You may not post new threads
    • You may not post replies
    • You may not post attachments
    • You may not edit your posts
    •