PDA

View Full Version : updateString error messages

florida
10-23-2002, 02:55 PM
this is a small calculator that keeps getting error messages when trying to run it.

Keep getting error with this saying something wrong with this part: updateString('4')

Any number I press it shows error with that number. If I input number 5 then yellow error message on:
updateString('5')

Can anyone advise what is wrong with this script?

<html>
<head>
<title>Calculator</title>
<SCRIPT LANGUAGE="JavaScript">

<!--HIDE FROM INCOMPATIBLE BROWSERS
-->
var inputString = " ";
function updateString(value) {
inputString += value;
document.Calculator.input.value = inputString

}

function backspace() {
curvalue = document.Calculator.input.value
curlength = curvalue.length;
curvalue = curvalue.substring(0, curlength-1)
document.Calculator.input.value = curvalue
}

// STOP HIDING FROM INCOMPATIBLE BROWSERS -->

</SCRIPT>

</head>
<body>
<div align="center">
<form name="Calculator">
<input type="text" name="input" size="22">
<br>
<input type="button" name="plus" value=" + "
onClick="updateString(' + ')">
<input type="button" name="minus" value=" - "
onClick="updateString(' - ')">
<input type="button" name="times" value=" x "
onClick="updateString(' * ')">
<input type="button" name="div" value=" / "
onClick="updateString(' / ')">
<input type="button" name="mod" value=" mod "
onClick="updateString(' % ')"><br>
<input type="button" name="BkSpc" value=" BkSpc "
onClick="backspace()">

<input type="button" name="clear" value=" clear "
onClick="input.value=''; inputString=''">
<input type="button" name=" parenthesis " value=" ( "
onClick="updateString(' ( ')">

<input type="button" name=" parenthesis " value=" ) "
onClick="updateString(' ) ')">

<br>

<input type="button" name="zero" value=" 0 "
onClick="updateString('0')">
<input type="button" name="one" value=" 1 "
onClick="updateString('1')">
<input type="button" name="two" value=" 2 "
onClick="updateString('2')">
<input type="button" name="three" value=" 3 "
onClick="updateString('3')">
<input type="button" name="four" value=" 4 "
onClick="updateString('4')">
<br>
<input type="button" name="five" value=" 5 "
onClick="updateString('5')">
<input type="button" name="six" value=" 6 "
onClick="updateString('6')">
<input type="button" name="seven" value=" 7 "
onClick="updateString('7')">
<input type="button" name="eight" value=" 8 "
onClick="updateString('8')">
<input type="button" name="nine" value=" 9 "
onClick="updateString('9')">
<br>
<input type="button" name="point" value=" . "
onClick="updateString('.')">
<input type="button" name="calc" value=" = "
onClick="input.value=eval(inputString);
inputString=''">
<input type="button" name="enter" value=" enter "
onClick="input.value=eval(inputString);
inputString=''">


</form>
</div>
</body>
</html>
PauletteB
10-23-2002, 03:23 PM
Remove --> at second line.

<!--HIDE FROM INCOMPATIBLE BROWSERS
-->
var inputString = " ";
beetle
10-23-2002, 03:25 PM
Delete the text in red....

<!--HIDE FROM INCOMPATIBLE BROWSERS
-->
var inputString = " ";
function updateString(value) {
inputString += value;
document.Calculator.input.value = inputString

}
florida
10-23-2002, 03:36 PM
I did as suggested but still get updatestring error. Please advise further. Thanks
beetle
10-23-2002, 03:41 PM
What is the exact text of the error?
florida
10-23-2002, 03:49 PM
beetle,

You were correct. It was my error and it works fine just as you stated. Thanks for your expertise!
beetle
10-23-2002, 03:50 PM
I copied and pasted your HTML and removed the --> that both Paulette and I suggested and it works fine for me.
beetle
10-23-2002, 03:51 PM
Ah, good!
florida
10-23-2002, 04:05 PM
ONe more question on this.

How can I validate the functions in this calculator script using <if statements, onBlur, alert>.