...

View Full Version : First 'full scale' site...opinions?



Bry Man
09-06-2005, 07:41 AM
Hey

Ive been meaning to make myself a site here for a long time now, so I went out and bought a domain name and some space over at ithium and this is what I came up with. All of it was coded by hand by me...except for the image rotator..but everything else is mine =). I did this as a way to test my newly found love for php/sql.

http://www.thecornerofmymind.com

Just tell me what you guys think, It took me about 5 days of work to do, its php/mysql driven with a admin section in where i can post new blogs/news and see whos been going over my site, I also run all user submitted information thru a few filters to remove all html code, and to escape sql code to prevent injections. Probably my favorite part of the whole site is the user -> admin messenging thing. Its not 100% done YET, you'll notice that the 'tutorials' link doesnt work...thats because im focusing efforts on the site look and function first, all ive got left is to add some custom BB codes to take the place of the removed html capabilities. But tell me what you think, ive showed it to a few friends who all loved it but perhaps a more unbiased opinion is needed.

KeZZeR
09-06-2005, 12:36 PM
It's a good start but there is going to be a lot of criticism here i think

There's a lot of grey, i'd say too much
You're using times new roman? Need I say more? ;)
The news doesn't align with the left and right hand columns in firefox
The header doesn't look right being central like that, and it stands out quite a bit from the rest of the site as it's the only bit with colour
All the text seems to be the same size throughout the whole site, different sizes make things stand out, it's a good to be a bit more variable

:)

Bry Man
09-06-2005, 06:47 PM
Ya, there is a bit of grey, I thought that it would make it more...clean, the banners provide a nice contrast, i dont find myself looking at them too long, but I do glance up at them occasionally...keeps the eyes movings...makes people less bored I suppose.


The news doesn't align with the left and right hand columns in firefox

You mean horizontally or vertically?, its not supposed to align horizontally, but then vertical alignment has been a bit of a problem for some time as it differs from IE to Firefox...so thats kind of a middle point between the differences.

Bry Man
09-07-2005, 08:45 PM
I notice a good handful of peope are coming to the site thru this thread...but nobody leaves any commentary?...anyone have anything else to say?

SpirtOfGrandeur
09-07-2005, 10:38 PM
I notice a good handful of peope are coming to the site thru this thread...but nobody leaves any commentary?...anyone have anything else to say?

Yes it is horrible. Is that a bit to honest? But luckily for you I took the time to make it better. I did not really like you attitude in the last post though so I made it work good enough, and the rest of it you are free to play with. One thing you should really fix is making col1, col3 into Ordered Lists instead of div's like they currently are.

Tested FF 1.0.6, O 8.02, IE 6.0 SP2 (XP SP2) (Did not validate it)


*snip* (Removed the code)

Bry Man
09-08-2005, 01:49 AM
I was simply asking a question, if anyones packing an attitude its you. you can take your self righteous high n mighty attitude and code and shove it if thats how your gonna act when someone asks you a question. I just want commentary, WHY is it horrible....provide more than just...it sucks please, WHY does it suck...

little_toaster
09-08-2005, 02:03 AM
i think the site is lacking in character, and sadly looks like a site made 5 years ago!, im really sorry but im being honest!

I can see ur php skills outweigh the creativity on this site!, it needs a little color, or soem nice graphics!

sorry if this is so negative, its not a bad site just rather it needs a little character!, if u wanted a template you could download one, add some spunk! :D

I just think it looks like a tabled site!, sorry this is crap response!

SpirtOfGrandeur
09-08-2005, 02:44 AM
I was simply asking a question, if anyones packing an attitude its you. you can take your self righteous high n mighty attitude and code and shove it if thats how your gonna act when someone asks you a question. I just want commentary, WHY is it horrible....provide more than just...it sucks please, WHY does it suck...

Did you even try the code? I was going to make it a link, but could not get any server space to show it off.

Number one you have broken HTML. You have ending </a> tags all over that do not need to be there. Using a fixed PX font is not the way websites are supposed to be created. I have large fonts installed on my machine therefore 12px looks horrible. Maybe 12 pt? (Was Fixed) How about the horrible JS that is 110% not needed? (Was Fixed) How about the difference between vertical heights between the side cols and the middle col? (Was Fixed) How about the use of '&nbsp;' instead of padding? (Was Fixed) And I definatly like the use of '<br />' where there is no need to be breaking. (Was Fixed) The font is hard on the eyes. (Was Fixed) You had about 8% redundant CSS. (Was Fixed). '<center>' and '<font>' tags are deperciated and should not be used. (Was Fixed)

I think that is all that I am going to post... o wait, yea you should change col1 and col3 to be lists. And the color scheme could use some updating. And the layout is nothing special. It is hard to read on my 61' HDTV even with FF scrolling the text to the largest size. (Due to color and font) Instead of writing all that up, I went ahead and coded it for you. Was that so wrong? Your right maybe it was.

For your sake I hope you saved it. So that you could learn something...

Bry Man
09-08-2005, 03:02 AM
@SpirtOfGrandeur

Actually I didnt save it...why...becuse its worthless to me, to put it nicely your quite full of yourself, Did you not pay attention to the fact taht the difference in height was intentional? Its there to provide a break in the flow...we dont want a hard block to look at do you, maybe the sites you make are like that but not mine. What usless JS? do you have any idea what that does...if you did you would know its not usless. Why use padding, &nbsp is there to take the place of content whencontent is not available...that style is used for content as well, having padding with content would be god awful on that bar. Ending </a> tags are the for a reason THEY END <a> Tags! lol.....nothing you did was of ANY use to me, sorry but you dont seem to know what your talking about.

@little_toaster

Thank you for your commentary, I know its a bit drab with the grayscale scheme, I was aiming more on getting the site operationaly and then I was gonna make a new scheme for it, I kinda liked the gray for a little bit cuz it wasnt supposed to be a birght and happy site...its a me thing i guess, i like to try and make the site look good using only code, ive never been much of a graphics guy even though ive taken several graphical design classes I prefer the beauty of code over pixel for some reason lol...at least you have the decency to not be all self righteous and not provide reason for your actions, as I said...this is my first 'full scale' site writtin in pretty much 100% php with a mysql backend, I think the line count is over 4000 lines...i guess your right...my php skills are better than my design lol...thanks again for your comment.

SpirtOfGrandeur
09-08-2005, 03:25 AM
Did you not pay attention to the fact taht the difference in height was intentional? Its there to provide a break in the flow...we dont want a hard block to look at do you, maybe the sites you make are like that but not mine.

If that is what you intend to do then fine. Because there is such a big space between the four parts of your site it is confusing to the normal user. If you want to try something a bit different why dont you make col1 and col3 be lower... then again this is just some peoples taste. If you like it keep it.


What usless JS? do you have any idea what that does...if you did you would know its not usless.

Actually I do. It changes the color of the &raquo; to a light blue. There is no need for JS to do this because you can do it in CSS in 1/2 the code. Or actually in about 1/4 the code. And people with JS turned off will not see the color where people with CSS turned on will.



Why use padding, &nbsp is there to take the place of content whencontent is not available...that style is used for content as well, having padding with content would be god awful on that bar.

Actually having padding with content on that bar looked 100 times more managable using CSS. There is never a need to start and/or end a string with a &nbsp;. You can use padding for that. And believe it or not it reads better in the code.


Ending </a> tags are the for a reason THEY END <a> Tags! lol.....nothing you did was of ANY use to me, sorry but you dont seem to know what your talking about.

Just took this off your site... Where are the starting <a> tags? It appears as though you meant to put a link in the bottom (maybe an admin edit link) and did not remove the </a>.


<div class="EntryInfo">Submitted On: 09.06.05</a></div><br />

<div class="EntryTitle">New Blog Entry!</div>
<div class="EntryContent">
<br /><center>New Blog entry added, click <a href="./blog.php?action=accepted">Here</a> to be taken to the Blog.</center><br />
</div>
<div class="EntryInfo">Submitted On: 09.05.05</a></div><br />
<div class="EntryTitle">A New Month....two days late</div>
<div class="EntryContent">
Hey, New month means time to clear the crap for the last month...except the blogs, which ive gotta devise a way to store old entrys according to month...or leave em as they are....hmm. Ive still gotta write a stupid pagination script too...so much to do. Then ill do a sweep of the code and make it more uniform, and adjust it so that the site has a bit more detail.
</div>

Bry Man
09-08-2005, 03:29 AM
heh you were right on one thing


<div class="EntryInfo">Submitted On: 09.06.05</a></div><br />

<div class="EntryTitle">New Blog Entry!</div>
<div class="EntryContent">
<br /><center>New Blog entry added, click <a href="./blog.php?action=accepted">Here</a> to be taken to the Blog.</center><br />
</div>
<div class="EntryInfo">Submitted On: 09.05.05</a></div><br />
<div class="EntryTitle">A New Month....two days late</div>
<div class="EntryContent">
Hey, New month means time to clear the crap for the last month...except the blogs, which ive gotta devise a way to store old entrys according to month...or leave em as they are....hmm. Ive still gotta write a stupid pagination script too...so much to do. Then ill do a sweep of the code and make it more uniform, and adjust it so that the site has a bit more detail.
</div>

those shouldnt be there....i dont remember ever even putting them in there.....

Lyconpire
09-22-2005, 05:38 PM
Did you even try the code? I was going to make it a link, but could not get any server space to show it off.

Number one you have broken HTML. You have ending </a> tags all over that do not need to be there. Using a fixed PX font is not the way websites are supposed to be created. I have large fonts installed on my machine therefore 12px looks horrible. Maybe 12 pt? (Was Fixed) How about the horrible JS that is 110% not needed? (Was Fixed) How about the difference between vertical heights between the side cols and the middle col? (Was Fixed) How about the use of '&nbsp;' instead of padding? (Was Fixed) And I definatly like the use of '<br />' where there is no need to be breaking. (Was Fixed) The font is hard on the eyes. (Was Fixed) You had about 8% redundant CSS. (Was Fixed). '<center>' and '<font>' tags are deperciated and should not be used. (Was Fixed)

I think that is all that I am going to post... o wait, yea you should change col1 and col3 to be lists. And the color scheme could use some updating. And the layout is nothing special. It is hard to read on my 61' HDTV even with FF scrolling the text to the largest size. (Due to color and font) Instead of writing all that up, I went ahead and coded it for you. Was that so wrong? Your right maybe it was.

For your sake I hope you saved it. So that you could learn something...


61" HDTV whats that got to do with anything?

and am sure you could becuase i have a 42" HDTV plasma with VGA connection and it was only 2000 ($4500 around) and thats fine

i also tried on my 19" moniter and 15" laptop moniter and it's ok to read did not test on psp will do tho?

o and you must of paid 4500 ($9000 around) for that or more when i went looking for HD that size they had none at all and that was about a week ago in currys (uk)when i got mine.

lets stick to topic tho. and not try to see if someone is lieing about seeing text.

mark87
09-22-2005, 05:43 PM
I think it would look alot better if you made it fixed with a border round a container to hold it all in. Perhaps a white background on the container would look good also and break it up a bit.

Bring the comments section up so its aligned with the menu and site stats.

Add more padding so the text does not hug so close to the sides. :)

Lyconpire
09-22-2005, 05:48 PM
I think it would look alot better if you made it fixed with a border round a container to hold it all in. Perhaps a white background on the container would look good also and break it up a bit.

Bring the comments section up so its aligned with the menu and site stats.

Add more padding so the text does not hug so close to the sides. :)

good review white background would look good :cool:

Bry Man
09-22-2005, 07:23 PM
Hey,

Didnt think people were still putting comments up, ive made quite a few changes since the last batch, including a new style that I copied from DeviantArt.com, ive added BBcode (so far only to the admin section) and ive fixed a few errors. You guys really think that the news blocks shouold be moved up to be aligned with the menu and stats blocks huh?, I thought it was nice to have a break. Ya ive been wanting to add more padding too, for some reason when I add padding it makes the container wider so I have to compensate by making the actual width smaller, is that supposed to happen =S.

Thanks for the reviews, I would like to apologize as I kinda came off as an *** at Spirit, but then again I took it rather offensively and that he bsaicly said 'your site sucks, here I fixed it for you so its better, use this code instead'

mark87
09-22-2005, 07:40 PM
...for some reason when I add padding it makes the container wider so I have to compensate by making the actual width smaller, is that supposed to happen =S.

Yes, http://www.w3.org/TR/REC-CSS2/box.html

Padding contributes to the overall width.

Bry Man
09-22-2005, 07:43 PM
Ah alright, Ill read that site in a bit, right now im doing a program for a friend and thats alot of reading lol.

JamieR
09-22-2005, 08:09 PM
It'd be better if you used lists for your nav ;)

Bry Man
09-22-2005, 08:17 PM
Ya, everyone keeps saying use lists, I was gonna try and switch to em later on but me and my div buddys have been together for a few years and its kinda hard to part ways haha, is there any advantage to lists over the method im using?

JamieR
09-23-2005, 03:08 PM
Yes:
It's more semantic to use lists. In XHTML 2.0, there will be a new list tag called <nl> (navigational list) which will be used for that instead of the classic unordered list - <ul>

Divs are layout divisions, which means that the power layouts, not small tiny spaces where nav links exist. :)

amaher1
09-23-2005, 06:10 PM
the color of your car scetch, clash with your site colors. Change one or the other

Bry Man
09-24-2005, 08:25 PM
Sorry for not replying, it seems the board has stoped sending me notification emails of new replys.


the color of your car scetch, clash with your site colors. Change one or the other

Theres 8 different logos, just refresh and a new one comes up =). That sketch is from my graphics final, that was the crappy version of it, I ended up doing it about 5 times until i got it perfect with more background detail and such.

Ill try and convert over to lists soon, I think i tried in the past but something went wrong =S dont remember what but for some reason I stoped using em and went back to divs.

bazz
09-24-2005, 09:07 PM
Late to this but I have a bit of time just now.

I find that the different colors used are not contrasting enough for my taste. It is easy enough to see the top of each box but the bottom of each, the sapce and then the top of the next aren't so clear. Maybe, change the colours around so that the text background is lighter than presently and then use the curreent background (for the text) as the bottom of the boxes?

Also, I would think it better if you used <dl><dt><dd> for your boxes instead of divs. and lists for menus as said too. I see at the bottom you have it optimised for 1024 or higher. its ok on 800x600 as it is a bit fluid :cool:

hth
bazz

Bry Man
09-24-2005, 09:20 PM
I tried lightining up the bottom bar and it wasnt very attractive...provided TOO much of a contrast and I found myself staring at it alot and getting this terrified feeling as if it was gonna attack me :eek: , I tried following what you were saying but I kinad got confused too :D , I was trying to copy the Deviant Art Site (http://www.deviantart.com)'s style with the mellow greens and what not. Im starting to get the feeling that nobody likes divs too. Also I just put the 'Best viewed in 1024 resoultion' because thats what I designed it on, its good to know that it looks good in smaller resolutions as well.



EZ Archive Ads Plugin for vBulletin Copyright 2006 Computer Help Forum